openstack
/
nova
Code Issues Proposed changes

Use assert(Not)Equal instead of assertTrue(A == X) 

Doing so gives richer error outputs.

Change-Id: I9a789b46d5800baeb061840624f544239f650010
This commit is contained in:
Stephen Finucane 2016-04-20 15:45:57 +01:00
parent 6debcf471c
commit 5a27cb7d1a
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
nova/tests/unit/api/openstack/test_api_version_request.py
View File

@ -88,10 +88,10 @@ class APIVersionRequestTests(test.NoDBTestCase):
self.assertGreater(vers3, vers2)
self.assertGreaterEqual(vers1, vers4)
self.assertGreaterEqual(vers3, vers2)
self.assertTrue(vers1 != vers2)
self.assertTrue(vers1 == vers4)
self.assertTrue(vers1 != v_null)
self.assertTrue(v_null == v_null)
self.assertNotEqual(vers1, vers2)
self.assertEqual(vers1, vers4)
self.assertNotEqual(vers1, v_null)
self.assertEqual(v_null, v_null)
self.assertRaises(TypeError, vers1.__lt__, "2.1")
def test_version_matches(self):

4
nova/tests/unit/virt/image/test_model.py
View File

@ -91,5 +91,5 @@ class ImageTest(test.NoDBTestCase):
["rbd.example.org"])
msg = str(img)
self.assertTrue(msg.find("braanes") == -1)
self.assertTrue(msg.find("***") != -1)
self.assertEqual(msg.find("braanes"), -1)
self.assertNotEqual(msg.find("***"), -1)