openstack/nova
Code Issues Proposed changes

Fix formatting of TODO and NOTE - should be a space after the #

Browse Source
This commit is contained in:
Justin Santa Barbara 2011-03-28 10:00:33 -07:00
parent 408de4bd5f
commit 5a80f8b3d5
1 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
nova/compute/manager.py
View File

@ -1055,16 +1055,16 @@ class ComputeManager(manager.SchedulerDependentManager):
vm_instance = vm_instances.get(name)
if vm_instance is None:
#NOTE(justinsb): We have to be very careful here, because a
#concurrent operation could be in progress (e.g. a spawn)
# NOTE(justinsb): We have to be very careful here, because a
# concurrent operation could be in progress (e.g. a spawn)
if db_state == power_state.NOSTATE:
#Assume that NOSTATE => spawning
#TODO(justinsb): This does mean that if we crash during a
#spawn, the machine will never leave the spawning state,
#but this is just the way nova is; this function isn't
#trying to correct that problem.
#We could have a separate task to correct this error.
#TODO(justinsb): What happens during a live migration?
# Assume that NOSTATE => spawning
# TODO(justinsb): This does mean that if we crash during a
# spawn, the machine will never leave the spawning state,
# but this is just the way nova is; this function isn't
# trying to correct that problem.
# We could have a separate task to correct this error.
# TODO(justinsb): What happens during a live migration?
LOG.info(_("Found instance '%(name)s' in DB but no VM. "
"State=%(db_state)s, so assuming spawn is in "
"progress.") % locals())