openstack/nova
Code Issues Proposed changes

use safer vgs call

Browse Source
This commit is contained in:
Vishvananda Ishaya
2011-01-08 10:04:22 -08:00
parent af5af61556
commit 5eb5373af5
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
nova/volume/driver.py
View File

@@ -20,7 +20,6 @@ Drivers for volumes.
"""
import os
import time
from nova import exception
@@ -80,8 +79,9 @@ class VolumeDriver(object):
def check_for_setup_error(self):
"""Returns an error if prerequisites aren't met"""
out, err = self._execute("sudo vgs")
if not FLAGS.volume_group in out:
out, err = self._execute("sudo vgs --noheadings -o name")
volume_groups = out.split()
if not FLAGS.volume_group in volume_groups:
raise exception.Error(_("volume group %s doesn't exist")
% FLAGS.volume_group)