openstack
/
nova
Code Issues Proposed changes

Merge "Replace assertTrue(not *) with assertFalse(*)"

This commit is contained in:
Jenkins 2014-07-19 10:24:15 +00:00 committed by Gerrit Code Review
parent 568f9b3226 acaf3bc419
commit 64d0c42289
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
nova/tests/db/test_migrations.py
View File

@ -865,4 +865,4 @@ class ProjectTestCase(test.NoDBTestCase):
helpful_msg = (_("The following migrations are missing a downgrade:"
"\n\t%s") % '\n\t'.join(sorted(missing_downgrade)))
self.assertTrue(not missing_downgrade, helpful_msg)
self.assertFalse(missing_downgrade, helpful_msg)

2
nova/tests/test_service.py
View File

@ -103,7 +103,7 @@ class ServiceFlagsTestCase(test.TestCase):
app.stop()
ref = db.service_get(context.get_admin_context(), app.service_id)
db.service_destroy(context.get_admin_context(), app.service_id)
self.assertTrue(not ref['disabled'])
self.assertFalse(ref['disabled'])
def test_service_disabled_on_create_based_on_flag(self):
self.flags(enable_new_services=False)

2
nova/tests/virt/xenapi/test_xenapi.py
View File

@ -527,7 +527,7 @@ class XenAPIVMTestCase(stubs.XenAPITestBase):
for vdi_ref in xenapi_fake.get_all('VDI'):
vdi_rec = xenapi_fake.get_record('VDI', vdi_ref)
name_label = vdi_rec["name_label"]
self.assertTrue(not name_label.endswith('snapshot'))
self.assertFalse(name_label.endswith('snapshot'))
self.assertTrue(self.fake_upload_called)