From dd7015cd6fea8f647df0cdf9aeaa0b22cbc3eb23 Mon Sep 17 00:00:00 2001 From: ghanshyam Date: Fri, 10 Jun 2016 15:46:07 +0900 Subject: [PATCH] Remove unused _get_flags method from integrated_helpers _get_flags method was mainly used by sample tests to add extensions which are no more valid as sample tests are merged for extensions and running with all extensions enable. This patch removes this unused method. Partially implements blueprint api-sample-tests-with-all-extensions Change-Id: I92bb2f4fe7c61183f95883cc9f31860f66b9a0b5 --- nova/tests/functional/integrated_helpers.py | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/nova/tests/functional/integrated_helpers.py b/nova/tests/functional/integrated_helpers.py index 54a3aadb9750..b436c028c68a 100644 --- a/nova/tests/functional/integrated_helpers.py +++ b/nova/tests/functional/integrated_helpers.py @@ -66,8 +66,6 @@ class _IntegratedTestBase(test.TestCase): def setUp(self): super(_IntegratedTestBase, self).setUp() - f = self._get_flags() - self.flags(**f) self.flags(verbose=True) nova.tests.unit.image.fake.stub_out_image_service(self) @@ -103,14 +101,6 @@ class _IntegratedTestBase(test.TestCase): self.network = self.start_service('network') self.scheduler = self._setup_scheduler_service() - def _get_flags(self): - """Allow subclass to modify global config before we start services.""" - # NOTE(sdague): _get_flags is used by about 13 tests that - # subclass this mostly to modify the extensions list. We - # should instead make that declarative in the future, at which - # point we can get rid of this. - return {} - def get_unused_server_name(self): servers = self.api.get_servers() server_names = [server['name'] for server in servers]