openstack/nova
Code Issues Proposed changes

Merge "[Trivial]Remove unused helper should_switch_to_postcopy"

Browse Source
This commit is contained in:
Zuul
2019-09-23 19:31:42 +00:00
committed by Gerrit Code Review
parent 31e9914ce5 fa90a277b9
commit 6fe2373964
2 changed files with 0 additions and 53 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
nova/tests/unit/virt/libvirt/test_migration.py
View File

@@ -1054,26 +1054,6 @@ class MigrationMonitorTestCase(test.NoDBTestCase):
self.assertFalse(migration.should_trigger_timeout_action( self.assertFalse(migration.should_trigger_timeout_action(
self.instance, 4500, 9000, "running")) self.instance, 4500, 9000, "running"))
def test_live_migration_postcopy_switch(self):
# Migration progress is not fast enough
self.assertTrue(migration.should_switch_to_postcopy(
2, 100, 105, "running"))
def test_live_migration_postcopy_switch_already_switched(self):
# Migration already running in postcopy mode
self.assertFalse(migration.should_switch_to_postcopy(
2, 100, 105, "running (post-copy)"))
def test_live_migration_postcopy_switch_too_soon(self):
# First memory iteration not completed yet
self.assertFalse(migration.should_switch_to_postcopy(
1, 100, 105, "running"))
def test_live_migration_postcopy_switch_fast_progress(self):
# Migration progress is good
self.assertFalse(migration.should_switch_to_postcopy(
2, 100, 155, "running"))
@mock.patch.object(libvirt_guest.Guest, @mock.patch.object(libvirt_guest.Guest,
"migrate_configure_max_downtime") "migrate_configure_max_downtime")
def test_live_migration_update_downtime_no_steps(self, mock_dt): def test_live_migration_update_downtime_no_steps(self, mock_dt):

33
nova/virt/libvirt/migration.py
View File

@@ -452,39 +452,6 @@ def should_trigger_timeout_action(instance, elapsed, completion_timeout,
return False return False
def should_switch_to_postcopy(memory_iteration, current_data_remaining,
previous_data_remaining, migration_status):
"""Determine if the migration should be switched to postcopy mode
:param memory_iteration: Number of memory iterations during the migration
:param current_data_remaining: amount of memory to be transferred
:param previous_data_remaining: previous memory to be transferred
:param migration_status: current status of the migration
Check the progress after the first memory iteration to determine if the
migration should be switched to post-copy mode
Avoid post-copy switch if already running in post-copy mode
:returns: True if migration should be switched to postcopy mode,
False otherwise
"""
if (migration_status == 'running (post-copy)' or
previous_data_remaining <= 0):
return False
if memory_iteration > 1:
progress_percentage = round((previous_data_remaining -
current_data_remaining) *
100 / previous_data_remaining)
# If migration progress is less than 10% per iteration after the
# first memory page copying pass, the migration is switched to
# postcopy mode
if progress_percentage < 10:
return True
return False
def update_downtime(guest, instance, def update_downtime(guest, instance,
olddowntime, olddowntime,
downtime_steps, elapsed): downtime_steps, elapsed):