openstack/nova
Code Issues Proposed changes

Nix bug msg from ConfGroupForServiceTypeNotFound

Browse Source 
Per [1], since it should actually be impossible in the current and
projected usage of get_ksa_adapter, we remove "Please report this bug"
from the ConfGroupForServiceTypeNotFound exception, and the
corresponding docstring in get_ksa_adapter.

[1] https://review.openstack.org/#/c/488137/22/nova/exception.py@973

Change-Id: Ifedf336f95ab3546b79d38c0e7cd8be5157a8a33
This commit is contained in:
Eric Fried
2017-10-11 10:04:59 -05:00
parent c3ca8a6256
commit 7265d745bb
2 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
nova/exception.py
View File

@@ -970,7 +970,7 @@ class ServiceNotFound(NotFound):
class ConfGroupForServiceTypeNotFound(ServiceNotFound): class ConfGroupForServiceTypeNotFound(ServiceNotFound):
msg_fmt = _("No conf group name could be found for service type " msg_fmt = _("No conf group name could be found for service type "
"%(stype)s. Please report this bug.") "%(stype)s.")
class ServiceBinaryExists(NovaException): class ServiceBinaryExists(NovaException):

3
nova/utils.py
View File

@@ -1295,8 +1295,7 @@ def get_ksa_adapter(service_type, ksa_auth=None, ksa_session=None,
min_version. min_version.
:return: A keystoneauth1 Adapter object for the specified service_type. :return: A keystoneauth1 Adapter object for the specified service_type.
:raise: ConfGroupForServiceTypeNotFound If no conf group name could be :raise: ConfGroupForServiceTypeNotFound If no conf group name could be
found for the specified service_type. This should be considered a found for the specified service_type.
bug.
""" """
# Get the conf group corresponding to the service type. # Get the conf group corresponding to the service type.
confgrp = _SERVICE_TYPES.get_project_name(service_type) confgrp = _SERVICE_TYPES.get_project_name(service_type)