openstack/nova
Code Issues Proposed changes

Fix wait_for_deleted function in SmokeTests.

Browse Source 
Fixes the wait_for_not_running function in smoketests/base.py so
that it short circuits when an instance ID is deleted rather than
waits 60 seconds (the timeout). Previously this function had
two problems:

 1) It used Boto's instance.update() instead of instance.update(validate=True).
 Since update() returns returns quietly if no data about the instance was
 returned (aka the instance has been deleted) it effectively made this
 function almost always wait for the timeout (60 seconds). This makes the
 tests take about a minute longer than they need to unless #2 below
 occurs...

 2) It also introduced a race condition in that... if hit just right
 the instance.state would get set to 'terminated'. Which would cause
 the loop to short circuit. This might seem correct at first glance but
 in fact causes intermittent failures in some of the netadmin tests
 because security groups can't be deleted if a running (or exiting)
 instance is still assigned to them. In fact wait_for_not_running
 was added to guard against just this in the first place!

Also, renames the base.wait_for_not_running function to be
called wait_for_deleted (that is what we are really doing here)

Change-Id: I4486995a7d9028d876366e8d7a2c845520319b86
This commit is contained in:
Dan Prince 2012-11-21 10:46:46 -05:00
parent de0842209c
commit 731c6b1d5d
2 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
smoketests/base.py
View File

@ -72,11 +72,13 @@ class SmokeTestCase(unittest.TestCase):
else:
return False
def wait_for_not_running(self, instance, tries=60, wait=1):
"""Wait for instance to not be running"""
def wait_for_deleted(self, instance, tries=60, wait=1):
"""Wait for instance to be deleted"""
for x in xrange(tries):
instance.update()
if not instance.state.startswith('running'):
try:
#NOTE(dprince): raises exception when instance id disappears
instance.update(validate=True)
except ValueError:
return True
time.sleep(wait)
else:

2
smoketests/test_netadmin.py
View File

@ -196,7 +196,7 @@ class SecurityGroupTests(base.UserSmokeTestCase):
self.conn.disassociate_address(self.data['public_ip'])
self.conn.delete_key_pair(TEST_KEY)
self.conn.terminate_instances([self.data['instance'].id])
self.wait_for_not_running(self.data['instance'])
self.wait_for_deleted(self.data['instance'])
self.conn.delete_security_group(TEST_GROUP)
groups = self.conn.get_all_security_groups()
self.assertFalse(TEST_GROUP in [group.name for group in groups])