openstack/nova
Code Issues Proposed changes

Using assertIsNone() instead of assertEqual(None)

Browse Source 
Following OpenStack Style Guidelines[1]:
http://docs.openstack.org/developer/hacking/#unit-tests-and-assertraises
[H203] Unit test assertions tend to give better messages for more specific assertions.
As a result, assertIsNone(...) is preferred over assertEqual(None, ...) and assertIs(..,None)

Change-Id: I8881abed6e7962d1516323725e194937bce1346f
This commit is contained in:
Luong Anh Tuan 2016-08-29 12:40:07 +07:00
parent 25be3fa02c
commit 7a204383d5
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
nova/tests/unit/api/openstack/test_wsgi.py
View File

@ -159,7 +159,7 @@ class RequestTest(MicroversionedTest):
request = wsgi.Request.blank('/')
accepted = 'nb-no'
request.headers = {'Accept-Language': accepted}
self.assertIs(request.best_match_language(), None)
self.assertIsNone(request.best_match_language())
def test_no_lang_header(self):
self.stubs.Set(i18n, 'get_available_languages',
@ -168,7 +168,7 @@ class RequestTest(MicroversionedTest):
request = wsgi.Request.blank('/')
accepted = ''
request.headers = {'Accept-Language': accepted}
self.assertIs(request.best_match_language(), None)
self.assertIsNone(request.best_match_language())
def test_api_version_request_header_none(self):
request = wsgi.Request.blank('/')

2
nova/tests/unit/objects/test_floating_ip.py
View File

@ -233,7 +233,7 @@ class _TestFloatingIPObject(object):
ips = [objects.FloatingIPList.make_ip_info('1.1.1.1', 'pool', 'eth0'),
objects.FloatingIPList.make_ip_info('1.1.1.2', 'loop', 'eth1')]
result = objects.FloatingIPList.create(None, ips)
self.assertIs(result, None)
self.assertIsNone(result)
result = objects.FloatingIPList.create(None, ips, want_result=True)
self.assertEqual('1.1.1.1', str(result[0].address))
self.assertEqual('1.1.1.2', str(result[1].address))