openstack/nova
Code Issues Proposed changes

Switch libvirt event timeout message to warning

Browse Source 
At the moment, if libvirt times out in detaching a device, it
reports this as an ERROR even if the process will be retried
and eventually succeed.

We should just log a warning since there's nothing to do, and
if the process fails after all the retries, it will log an ERROR
anyways.

Closes-Bug: #1972023
Change-Id: Idda12db5758706a97b7841571b9ecd3dc6e6905e
This commit is contained in:
Mohammed Naser
2022-05-06 16:27:11 -04:00
parent b7e1d1219c
commit 7c87c2f5f7
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
nova/virt/libvirt/driver.py
View File

@@ -2567,7 +2567,7 @@ class LibvirtDriver(driver.ComputeDriver):
# ServerRescueNegativeTestJSON.test_rescued_vm_detach_volume
# Log a warning and let the upper layer detect that the device is
# still attached and retry
LOG.error(
LOG.warning(
'Waiting for libvirt event about the detach of '
'device %s with device alias %s from instance %s is timed '
'out.', device_name, dev.alias, instance_uuid)