pylint cleanup

Mostly remove unused imports

Change-Id: Icdb3ec77537b2568f4e85843bab89eb63cd17d8e

nova/api/openstack/compute/contrib/floating_ips.py

@@ -26,7 +26,6 @@ from nova import compute
 from nova import exception
 from nova import log as logging
 from nova import network
-from nova.rpc import common as rpc_common
 
 
 LOG = logging.getLogger(__name__)

nova/api/validator.py

@@ -21,8 +21,6 @@ import logging
 import re
 import socket
 
-from nova import exception
-
 LOG = logging.getLogger(__name__)
 
 

nova/cloudpipe/pipelib.py

@@ -24,7 +24,6 @@ an instance with it.
 
 import os
 import string
-import tempfile
 import zipfile
 
 # NOTE(vish): cloud is only for the _gen_key functionality

nova/consoleauth/manager.py

@@ -18,8 +18,6 @@
 
 """Auth Components for Consoles."""
 
-import os
-import sys
 import time
 
 from nova import flags

nova/db/sqlalchemy/migration.py

@@ -18,7 +18,6 @@
 
 import distutils.version as dist_version
 import os
-import sys
 
 from nova.db import migration
 from nova.db.sqlalchemy.session import get_engine

nova/network/ldapdns.py

@@ -13,9 +13,6 @@
 #    under the License.
 
 import ldap
-import os
-import shutil
-import tempfile
 import time
 
 from nova.auth import fakeldap

nova/rpc/impl_fake.py

@@ -19,10 +19,7 @@ queues.  Casts will block, but this is very useful for tests.
 
 import inspect
 import json
-import signal
-import sys
 import time
-import traceback
 
 import eventlet
 

nova/testing/runner.py

@@ -110,8 +110,6 @@ class _AnsiColorizer(object):
                     curses.setupterm()
                     return curses.tigetnum("colors") > 2
             except Exception:
-                raise
-                # guess false in case of error
                 return False
     supported = classmethod(supported)
 

nova/tests/test_auth.py

@@ -18,13 +18,11 @@
 
 import unittest
 
-from nova import crypto
 from nova import exception
 from nova import flags
 from nova import log as logging
 from nova import test
 from nova.auth import manager
-from nova.api.ec2 import cloud
 from nova.auth import fakeldap
 
 FLAGS = flags.FLAGS

nova/utils.py

@@ -337,7 +337,7 @@ def debug(arg):
 
 def generate_uid(topic, size=8):
     characters = '01234567890abcdefghijklmnopqrstuvwxyz'
-    choices = [random.choice(characters) for x in xrange(size)]
+    choices = [random.choice(characters) for _x in xrange(size)]
     return '%s-%s' % (topic, ''.join(choices))
 
 
@@ -1090,8 +1090,6 @@ def check_isinstance(obj, cls):
     if isinstance(obj, cls):
         return obj
     raise Exception(_('Expected object of type: %s') % (str(cls)))
-    # TODO(justinsb): Can we make this better??
-    return cls()  # Ugly PyLint hack
 
 
 def parse_server_string(server_str):