openstack/nova
Code Issues Proposed changes

libvirt: Add a debug log entry before / after invoking migrate()

Browse Source 
The guest.migrate() is running in an async background thread, so it is
useful to see exactly when it runs relative to other threads.  And the
existing message: "Starting monitoring of live migration" is a bad one
to rely on because there's no guarantee libvirt has been told to start
migration yet.

So add a debug log entry before and after issuing the guest.migrate()
call.

Change-Id: Ia7d5de5b0ee4f5d88b5101d2258336adf573a350
Suggested-by: Daniel Berrangé (discovered via debugging a Nova live
              migration bug)
Signed-off-by: Kashyap Chamarthy <kchamart@redhat.com>
This commit is contained in:
Kashyap Chamarthy
2018-04-20 17:09:33 +02:00
parent 6efbed5e70
commit 880f62885c
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
nova/virt/libvirt/driver.py
View File

@@ -7053,12 +7053,14 @@ class LibvirtDriver(driver.ComputeDriver):
if CONF.serial_console.enabled: if CONF.serial_console.enabled:
serial_ports = list(self._get_serial_ports_from_guest(guest)) serial_ports = list(self._get_serial_ports_from_guest(guest))
LOG.debug("About to invoke the migrate API", instance=instance)
guest.migrate(self._live_migration_uri(dest), guest.migrate(self._live_migration_uri(dest),
migrate_uri=migrate_uri, migrate_uri=migrate_uri,
flags=migration_flags, flags=migration_flags,
params=params, params=params,
domain_xml=new_xml_str, domain_xml=new_xml_str,
bandwidth=bandwidth) bandwidth=bandwidth)
LOG.debug("Migrate API has completed", instance=instance)
for hostname, port in serial_ports: for hostname, port in serial_ports:
serial_console.release_port(host=hostname, port=port) serial_console.release_port(host=hostname, port=port)