diff --git a/doc/v3/api_samples/os-agents/agent-post-resp.json b/doc/v3/api_samples/os-agents/agent-post-resp.json index 418d11f5042f..f6c760cc67e3 100644 --- a/doc/v3/api_samples/os-agents/agent-post-resp.json +++ b/doc/v3/api_samples/os-agents/agent-post-resp.json @@ -1,6 +1,6 @@ { "agent": { - "agent_id": "1", + "agent_id": 1, "architecture": "x86", "hypervisor": "hypervisor", "md5hash": "add6bb58e139be103324d04d82d8f545", diff --git a/doc/v3/api_samples/os-agents/agent-update-put-resp.json b/doc/v3/api_samples/os-agents/agent-update-put-resp.json index 6b67222c8c23..866994e4c94a 100644 --- a/doc/v3/api_samples/os-agents/agent-update-put-resp.json +++ b/doc/v3/api_samples/os-agents/agent-update-put-resp.json @@ -1,6 +1,6 @@ { "agent": { - "agent_id": "1", + "agent_id": 1, "md5hash": "add6bb58e139be103324d04d82d8f545", "url": "xxx://xxxx/xxx/xxx", "version": "7.0" diff --git a/doc/v3/api_samples/os-agents/agents-get-resp.json b/doc/v3/api_samples/os-agents/agents-get-resp.json index 36eac4ced7ba..73ba45c24034 100644 --- a/doc/v3/api_samples/os-agents/agents-get-resp.json +++ b/doc/v3/api_samples/os-agents/agents-get-resp.json @@ -1,7 +1,7 @@ { "agents": [ { - "agent_id": "1", + "agent_id": 1, "architecture": "x86", "hypervisor": "hypervisor", "md5hash": "add6bb58e139be103324d04d82d8f545", diff --git a/nova/api/openstack/compute/plugins/v3/agents.py b/nova/api/openstack/compute/plugins/v3/agents.py index 7aca52b9dbcf..31b8b591da2b 100644 --- a/nova/api/openstack/compute/plugins/v3/agents.py +++ b/nova/api/openstack/compute/plugins/v3/agents.py @@ -90,7 +90,7 @@ class AgentController(object): except exception.AgentBuildNotFound as ex: raise webob.exc.HTTPNotFound(explanation=ex.format_message()) - return {"agent": {'agent_id': id, 'version': version, + return {"agent": {'agent_id': int(id), 'version': version, 'url': url, 'md5hash': md5hash}} @extensions.expected_errors(404) diff --git a/nova/tests/integrated/v3/api_samples/os-agents/agent-post-resp.json.tpl b/nova/tests/integrated/v3/api_samples/os-agents/agent-post-resp.json.tpl index 418d11f5042f..f6c760cc67e3 100644 --- a/nova/tests/integrated/v3/api_samples/os-agents/agent-post-resp.json.tpl +++ b/nova/tests/integrated/v3/api_samples/os-agents/agent-post-resp.json.tpl @@ -1,6 +1,6 @@ { "agent": { - "agent_id": "1", + "agent_id": 1, "architecture": "x86", "hypervisor": "hypervisor", "md5hash": "add6bb58e139be103324d04d82d8f545", diff --git a/nova/tests/integrated/v3/api_samples/os-agents/agent-update-put-resp.json.tpl b/nova/tests/integrated/v3/api_samples/os-agents/agent-update-put-resp.json.tpl index 6b67222c8c23..866994e4c94a 100644 --- a/nova/tests/integrated/v3/api_samples/os-agents/agent-update-put-resp.json.tpl +++ b/nova/tests/integrated/v3/api_samples/os-agents/agent-update-put-resp.json.tpl @@ -1,6 +1,6 @@ { "agent": { - "agent_id": "1", + "agent_id": 1, "md5hash": "add6bb58e139be103324d04d82d8f545", "url": "xxx://xxxx/xxx/xxx", "version": "7.0" diff --git a/nova/tests/integrated/v3/api_samples/os-agents/agents-get-resp.json.tpl b/nova/tests/integrated/v3/api_samples/os-agents/agents-get-resp.json.tpl index 36eac4ced7ba..73ba45c24034 100644 --- a/nova/tests/integrated/v3/api_samples/os-agents/agents-get-resp.json.tpl +++ b/nova/tests/integrated/v3/api_samples/os-agents/agents-get-resp.json.tpl @@ -1,7 +1,7 @@ { "agents": [ { - "agent_id": "1", + "agent_id": 1, "architecture": "x86", "hypervisor": "hypervisor", "md5hash": "add6bb58e139be103324d04d82d8f545", diff --git a/nova/tests/integrated/v3/test_agents.py b/nova/tests/integrated/v3/test_agents.py index 0248e0743206..99a53bcf51b8 100644 --- a/nova/tests/integrated/v3/test_agents.py +++ b/nova/tests/integrated/v3/test_agents.py @@ -30,10 +30,10 @@ class AgentsJsonTest(api_sample_base.ApiSampleTestBaseV3): 'os': 'os', 'version': '8.0', 'md5hash': 'add6bb58e139be103324d04d82d8f545', - 'id': '1'}] + 'id': 1}] def fake_agent_build_create(context, values): - values['id'] = '1' + values['id'] = 1 agent_build_ref = models.AgentBuild() agent_build_ref.update(values) return agent_build_ref @@ -74,22 +74,12 @@ class AgentsJsonTest(api_sample_base.ApiSampleTestBaseV3): } response = self._do_post('os-agents', 'agent-post-req', project) - project['agent_id'] = 1 self._verify_response('agent-post-resp', project, response, 201) - return project def test_agent_list(self): # Return a list of all agent builds. response = self._do_get('os-agents') - project = {'url': 'xxxxxxxxxxxx', - 'hypervisor': 'hypervisor', - 'architecture': 'x86', - 'os': 'os', - 'version': '8.0', - 'md5hash': 'add6bb58e139be103324d04d82d8f545', - 'agent_id': 1 - } - self._verify_response('agents-get-resp', project, response, 200) + self._verify_response('agents-get-resp', {}, response, 200) def test_agent_update(self): # Update an existing agent build. @@ -99,7 +89,6 @@ class AgentsJsonTest(api_sample_base.ApiSampleTestBaseV3): 'md5hash': 'add6bb58e139be103324d04d82d8f545'} response = self._do_put('os-agents/%s' % agent_id, 'agent-update-put-req', subs) - subs['agent_id'] = 1 self._verify_response('agent-update-put-resp', subs, response, 200) def test_agent_delete(self):