openstack/nova
Code Issues Proposed changes

Add test coverage of existing server topology policies

Browse Source 
Current tests do not have good test coverage of existing policies.
Either tests for policies do not exist or if they exist then they
do not cover the actual negative and positive testing.

For Example, if any policy with default rule as admin only then
test should verify:
- policy check pass with context having admin or server owner
- policy check fail with context having non-admin and not server owner

As discussed in policy-defaults-refresh, to change the policies
with new default roles and scope_type, we need to have the enough
testing coverage of existing policy behavior.

When we will add the scope_type in policies or new default roles,
then these test coverage will be extended to adopt the new changes
and also make sure we do not break the existing behavior.

This commit covers the testing coverage of existing server topology
policies.

Partial implement blueprint policy-defaults-refresh

Change-Id: I32aa5f20ee63966f50cc01349e0219495eed947c
This commit is contained in:
Ghanshyam Mann 2020-04-04 23:27:43 -05:00
parent 88e399c98b
commit 8d2ad62dc1
2 changed files with 119 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
nova/tests/unit/api/openstack/compute/test_server_topology.py
View File

@ -11,7 +11,6 @@
# License for the specific language governing permissions and limitations
# under the License.
import fixtures
import mock
from oslo_utils.fixture import uuidsentinel as uuids
from webob import exc
@ -23,7 +22,6 @@ from nova import objects
from nova.objects import instance_numa as numa
from nova import test
from nova.tests.unit.api.openstack import fakes
from nova.tests.unit import fake_instance
class ServerTopologyTestV278(test.NoDBTestCase):
@ -100,28 +98,3 @@ class ServerTopologyTestV278(test.NoDBTestCase):
req,
self.uuid)
self.assertEqual(400, excep.code)
class ServerTopologyEnforcementV278(test.NoDBTestCase):
api_version = '2.78'
def setUp(self):
super(ServerTopologyEnforcementV278, self).setUp()
self.controller = server_topology.ServerTopologyController()
self.req = fakes.HTTPRequest.blank('', version=self.api_version)
context = self.req.environ['nova.context']
self.mock_get = self.useFixture(
fixtures.MockPatch('nova.api.openstack.common.get_instance')).mock
self.instance = fake_instance.fake_instance_obj(
context, id=1, project_id=context.project_id)
self.mock_get.return_value = self.instance
def test_get_topology_policy_failed(self):
rule_name = "compute:server:topology:index"
self.policy.set_rules({rule_name: "project:non_fake"})
exc = self.assertRaises(
exception.PolicyNotAuthorized,
self.controller.index, self.req, fakes.FAKE_UUID)
self.assertEqual(
"Policy doesn't allow %s to be performed." % rule_name,
exc.format_message())

119
nova/tests/unit/policies/test_server_topology.py Normal file
View File

@ -0,0 +1,119 @@
# Licensed under the Apache License, Version 2.0 (the "License"); you may
# not use this file except in compliance with the License. You may obtain
# a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.
import fixtures
from oslo_utils.fixture import uuidsentinel as uuids
from nova.api.openstack.compute import server_topology
from nova.compute import vm_states
from nova import objects
from nova.policies import server_topology as policies
from nova.tests.unit.api.openstack import fakes
from nova.tests.unit import fake_instance
from nova.tests.unit.policies import base
class ServerTopologyPolicyTest(base.BasePolicyTest):
"""Test Server Topology APIs policies with all possible context.
This class defines the set of context with different roles
which are allowed and not allowed to pass the policy checks.
With those set of context, it will call the API operation and
verify the expected behaviour.
"""
def setUp(self):
super(ServerTopologyPolicyTest, self).setUp()
self.controller = server_topology.ServerTopologyController()
self.req = fakes.HTTPRequest.blank('', version='2.78')
self.mock_get = self.useFixture(
fixtures.MockPatch('nova.api.openstack.common.get_instance')).mock
self.instance = fake_instance.fake_instance_obj(
self.project_member_context,
id=1, uuid=uuids.fake_id, project_id=self.project_id,
vm_state=vm_states.ACTIVE)
self.mock_get.return_value = self.instance
self.instance.numa_topology = objects.InstanceNUMATopology(
instance_uuid = self.instance.uuid,
cells=[objects.InstanceNUMACell(
node=0, memory=1024, pagesize=4, id=123,
cpu_topology=None,
cpu_pinning={},
cpuset=set([0, 1]))])
# Check that admin or and server owner is able to get
# the server topology.
self.admin_or_owner_authorized_contexts = [
self.legacy_admin_context, self.system_admin_context,
self.project_admin_context, self.project_member_context,
self.project_reader_context, self.project_foo_context]
# Check that non-admin/owner is not able to get
# the server topology.
self.admin_or_owner_unauthorized_contexts = [
self.system_member_context, self.system_reader_context,
self.system_foo_context, self.other_project_member_context,
self.other_project_reader_context,
]
# Check that admin is able to get the server topology
# host information.
self.admin_authorized_contexts = [
self.legacy_admin_context, self.system_admin_context,
self.project_admin_context]
# Check that non-admin is not able to get the server topology
# host information.
self.admin_unauthorized_contexts = [
self.system_member_context, self.system_reader_context,
self.system_foo_context, self.project_member_context,
self.other_project_member_context,
self.project_foo_context, self.project_reader_context,
self.other_project_reader_context,
]
def test_index_server_topology_policy(self):
rule_name = policies.BASE_POLICY_NAME % 'index'
self.common_policy_check(self.admin_or_owner_authorized_contexts,
self.admin_or_owner_unauthorized_contexts,
rule_name,
self.controller.index,
self.req, self.instance.uuid)
def test_index_host_server_topology_policy(self):
rule_name = policies.BASE_POLICY_NAME % 'host:index'
# 'index' policy is checked before 'host:index' so
# we have to allow it for everyone otherwise it will
# fail first for unauthorized contexts.
rule = policies.BASE_POLICY_NAME % 'index'
self.policy.set_rules({rule: "@"}, overwrite=False)
authorize_res, unauthorize_res = self.common_policy_check(
self.admin_authorized_contexts, self.admin_unauthorized_contexts,
rule_name, self.controller.index, self.req, self.instance.uuid,
fatal=False)
for resp in authorize_res:
self.assertEqual(123, resp['nodes'][0]['host_node'])
self.assertEqual({}, resp['nodes'][0]['cpu_pinning'])
for resp in unauthorize_res:
self.assertNotIn('host_node', resp['nodes'][0])
self.assertNotIn('cpu_pinning', resp['nodes'][0])
class ServerTopologyScopeTypePolicyTest(ServerTopologyPolicyTest):
"""Test Server Topology APIs policies with system scope enabled.
This class set the nova.conf [oslo_policy] enforce_scope to True
so that we can switch on the scope checking on oslo policy side.
It defines the set of context with scoped token
which are allowed and not allowed to pass the policy checks.
With those set of context, it will run the API operation and
verify the expected behaviour.
"""
def setUp(self):
super(ServerTopologyScopeTypePolicyTest, self).setUp()
self.flags(enforce_scope=True, group="oslo_policy")