Browse Source

Merge "Add regression tests for bug #1889108"

Zuul 1 week ago
committed by Gerrit Code Review
1 changed files with 103 additions and 0 deletions
  1. +103

+ 103
- 0
nova/tests/functional/regressions/ View File

@@ -0,0 +1,103 @@
# Licensed under the Apache License, Version 2.0 (the "License"); you may
# not use this file except in compliance with the License. You may obtain
# a copy of the License at
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.

import mock

from nova import test
from nova.tests import fixtures as nova_fixtures
from nova.tests.functional import integrated_helpers

class TestVolAttachmentsDuringPreLiveMigration(
"""Regression test for bug 1889108.

This regression test asserts that the original source volume attachments
are incorrectly removed during the rollback from pre_live_migration
failures on the destination.

# Default self.api to the self.admin_api as live migration is admin only
microversion = 'latest'

def setUp(self):
self.cinder = self.useFixture(nova_fixtures.CinderFixture(self))

def _setup_compute_service(self):

def test_vol_attachments_during_driver_pre_live_mig_failure(
self, mock_plm):
"""Assert that the src attachment is incorrectly removed

* Mock pre_live_migration to always fail within the virt driver
* Launch a boot from volume instance
* Assert that the volume is attached correctly to the instance.
* Live migrate the instance to another host invoking the mocked
* Assert that the instance is still on the source host
* Assert that both the original source host volume attachment and
new destination volume attachment have been removed
volume_id = nova_fixtures.CinderFixture.IMAGE_BACKED_VOL
server = self._build_server(
name='test_bfv_pre_live_migration_failure', image_uuid='',
server['block_device_mapping_v2'] = [{
'source_type': 'volume',
'destination_type': 'volume',
'boot_index': 0,
'uuid': volume_id
server = self.api.post_server({'server': server})
self._wait_for_state_change(server, 'ACTIVE')

# Fetch the source host for use later
server = self.api.get_server(server['id'])
src_host = server['OS-EXT-SRV-ATTR:host']

# Assert that the volume is connected to the instance
volume_id, self.cinder.volume_ids_for_instance(server['id']))

# Assert that we have an active attachment in the fixture
attachments = self.cinder.volume_to_attachment.get(volume_id)
self.assertEqual(1, len(attachments))

# Fetch the attachment_id for use later once we have migrated
src_attachment_id = list(attachments.keys())[0]

# Migrate the instance and wait until the migration errors out thanks
# to our mocked version of pre_live_migration raising
# test.TestingException
self._live_migrate(server, 'error')

# Assert that we called the fake pre_live_migration method

# Assert that the instance is listed on the source
server = self.api.get_server(server['id'])
self.assertEqual(src_host, server['OS-EXT-SRV-ATTR:host'])

# FIXME(lyarwood): Assert that both the src and dest attachments have
# been removed. Only the dest attachment should be removed during the
# rollback of a pre_live_migration failure.
attachments = self.cinder.volume_to_attachment.get(volume_id)
self.assertNotIn(src_attachment_id, attachments.keys())
self.assertEqual(0, len(attachments))