Merge "Check cherry-pick hashes in pep8 tox target" into stable/queens

tools/check-cherry-picks.sh

@@ -0,0 +1,42 @@
+#!/bin/sh
+#
+# A tool to check the cherry-pick hashes from the current git commit message
+# to verify that they're all on either master or stable/ branches
+#
+
+commit_hash=""
+
+# Check if the patch is a merge patch by counting the number of parents.
+# If the patch has 2 parents, then the 2nd parent is the patch we want
+# to validate.
+parent_number=$(git show --format='%P' --quiet | awk '{print NF}')
+if [ $parent_number -eq 2 ]; then
+    commit_hash=$(git show --format='%P' --quiet | awk '{print $NF}')
+fi
+
+hashes=$(git show --format='%b' --quiet $commit_hash | sed -nr 's/^.cherry picked from commit (.*).$/\1/p')
+checked=0
+branches+=""
+for hash in $hashes; do
+    branch=$(git branch -a --contains "$hash" 2>/dev/null| grep -oE '(master|stable/[a-z]+)')
+    if [ $? -ne 0 ]; then
+        echo "Cherry pick hash $hash not on any master or stable branches"
+        exit 1
+    fi
+    branches+=" $branch"
+    checked=$(($checked + 1))
+done
+
+if [ $checked -eq 0 ]; then
+    if ! grep -q '^defaultbranch=stable/' .gitreview; then
+        echo "Checked $checked cherry-pick hashes: OK"
+        exit 0
+    else
+        if ! git show --format='%B' --quiet | grep -qi 'stable.*only'; then
+            echo 'Stable branch requires either cherry-pick -x headers or [stable-only] tag!'
+            exit 1
+        fi
+    fi
+else
+    echo Checked $checked cherry-pick hashes on branches: $(echo $branches | tr ' ' '\n' | sort | uniq)
+fi

tox.ini

@@ -55,6 +55,7 @@ commands =
   bash -c "! find doc/ -type f -name *.json | xargs grep -U -n $'\r'"
   # Check that all included JSON files are valid JSON
   bash -c '! find doc/ -type f -name *.json | xargs -t -n1 python -m json.tool 2>&1 > /dev/null | grep -B1 -v ^python'
+  bash tools/check-cherry-picks.sh
 
 [testenv:fast8]
 # This is a subset of the full pep8 check which