From 992bdc36a9418ac52edd64b7366dc439082c67a6 Mon Sep 17 00:00:00 2001
From: jichenjc <jichenjc@cn.ibm.com>
Date: Mon, 21 Sep 2015 23:47:46 +0800
Subject: [PATCH] Add test cases for some classes in objects.fields

There is no unit test for some classes in objects.fields
This patch added unit tests for PciDeviceTypeField
ConfigDrivePolicy and CPUAllocationPolicy.

Related-Bug: 1489531

Change-Id: Ibaf3e8382a3f8bf812ef290850b3a4a7ce28a9ba
---
 nova/tests/unit/objects/test_fields.py | 52 ++++++++++++++++++++++++++
 1 file changed, 52 insertions(+)

diff --git a/nova/tests/unit/objects/test_fields.py b/nova/tests/unit/objects/test_fields.py
index 1f011fdeb484..dbeeac301e8c 100644
--- a/nova/tests/unit/objects/test_fields.py
+++ b/nova/tests/unit/objects/test_fields.py
@@ -308,6 +308,58 @@ class TestCPUFeaturePolicy(TestField):
         self.assertRaises(ValueError, self.field.stringify, 'disallow')
 
 
+class TestConfigDrivePolicy(TestField):
+    def setUp(self):
+        super(TestConfigDrivePolicy, self).setUp()
+        self.field = fields.ConfigDrivePolicyField()
+        self.coerce_good_values = [('optional', 'optional'),
+                                   ('mandatory', 'mandatory')]
+        self.coerce_bad_values = ['acme']
+        self.to_primitive_values = self.coerce_good_values[0:1]
+        self.from_primitive_values = self.coerce_good_values[0:1]
+
+    def test_stringify(self):
+        self.assertEqual("'optional'", self.field.stringify('optional'))
+
+    def test_stringify_invalid(self):
+        self.assertRaises(ValueError, self.field.stringify, 'acme')
+
+
+class TestCPUAllocationPolicy(TestField):
+    def setUp(self):
+        super(TestCPUAllocationPolicy, self).setUp()
+        self.field = fields.CPUAllocationPolicyField()
+        self.coerce_good_values = [('dedicated', 'dedicated'),
+                                   ('shared', 'shared')]
+        self.coerce_bad_values = ['acme']
+        self.to_primitive_values = self.coerce_good_values[0:1]
+        self.from_primitive_values = self.coerce_good_values[0:1]
+
+    def test_stringify(self):
+        self.assertEqual("'shared'", self.field.stringify('shared'))
+
+    def test_stringify_invalid(self):
+        self.assertRaises(ValueError, self.field.stringify, 'acme')
+
+
+class TestPciDeviceType(TestField):
+    def setUp(self):
+        super(TestPciDeviceType, self).setUp()
+        self.field = fields.PciDeviceTypeField()
+        self.coerce_good_values = [('type-PCI', 'type-PCI'),
+                                   ('type-PF', 'type-PF'),
+                                   ('type-VF', 'type-VF')]
+        self.coerce_bad_values = ['acme']
+        self.to_primitive_values = self.coerce_good_values[0:1]
+        self.from_primitive_values = self.coerce_good_values[0:1]
+
+    def test_stringify(self):
+        self.assertEqual("'type-VF'", self.field.stringify('type-VF'))
+
+    def test_stringify_invalid(self):
+        self.assertRaises(ValueError, self.field.stringify, 'acme')
+
+
 class TestDiskBus(TestField):
     def setUp(self):
         super(TestDiskBus, self).setUp()