openstack/nova
Code Issues Proposed changes

Return 400 when name is more than 200 characters

Browse Source 
APIs listed below are returning 500 error if you pass name more than
200 characters.
1. create resource_providers
2. update resource_providers

Added maxLength check in schema to ensure name should not be more than
200 characters.

Closes-Bug: #1642485
Change-Id: Ia22ae86702dabe18bc577b17164a81c363da6d41
This commit is contained in:
bhagyashris 2016-11-30 20:41:48 +05:30
parent 8f24088319
commit 9bbce28c56
2 changed files with 22 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
nova/api/openstack/placement/handlers/resource_provider.py
View File

@ -28,7 +28,8 @@ POST_RESOURCE_PROVIDER_SCHEMA = {
"type": "object", "type": "object",
"properties": { "properties": {
"name": { "name": {
"type": "string" "type": "string",
"maxLength": 200
}, },
"uuid": { "uuid": {
"type": "string", "type": "string",

20
nova/tests/functional/api/openstack/placement/gabbits/resource-provider.yaml
View File

@ -254,3 +254,23 @@ tests:
status: 400 status: 400
response_strings: response_strings:
- "Failed validating 'format'" - "Failed validating 'format'"
- name: try to create resource provider with name exceed max characters
POST: /resource_providers
request_headers:
content-type: application/json
data:
name: &name_exceeds_max_length_check This is a long text of 201 charactersssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssss
status: 400
response_strings:
- "Failed validating 'maxLength'"
- name: try to update resource provider with name exceed max characters
PUT: /resource_providers/$ENVIRON['RP_UUID']
request_headers:
content-type: application/json
data:
name: *name_exceeds_max_length_check
status: 400
response_strings:
- "Failed validating 'maxLength'"