openstack/nova
Code Issues Proposed changes

Merge "Add metadata functional negative tests"

Browse Source
This commit is contained in:
Jenkins 2016-12-21 06:13:27 +00:00 committed by Gerrit Code Review
commit a286c16ea0
2 changed files with 45 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
nova/tests/functional/api/client.py
View File

@ -364,6 +364,10 @@ class TestOpenStackClient(object):
return self.api_post('/servers/%s/metadata' % server_id, return self.api_post('/servers/%s/metadata' % server_id,
post_body).body['metadata'] post_body).body['metadata']
def delete_server_metadata(self, server_id, key):
return self.api_delete('/servers/%s/metadata/%s' %
(server_id, key))
def get_server_groups(self, all_projects=None): def get_server_groups(self, all_projects=None):
if all_projects: if all_projects:
return self.api_get( return self.api_get(

41
nova/tests/functional/test_servers.py
View File

@ -347,6 +347,47 @@ class ServersTest(ServersTestBase):
# Cleanup # Cleanup
self._delete_server(created_server_id) self._delete_server(created_server_id)
def test_server_metadata_actions_negative_invalid_state(self):
# Create server with metadata
server = self._build_minimal_create_server_request()
metadata = {'key_1': 'value_1'}
server['metadata'] = metadata
post = {'server': server}
created_server = self.api.post_server(post)
found_server = self._wait_for_state_change(created_server, 'BUILD')
self.assertEqual('ACTIVE', found_server['status'])
self.assertEqual(metadata, found_server.get('metadata'))
server_id = found_server['id']
# Change status from ACTIVE to SHELVED for negative test
self.flags(shelved_offload_time = -1)
self.api.post_server_action(server_id, {'shelve': {}})
found_server = self._wait_for_state_change(found_server, 'ACTIVE')
self.assertEqual('SHELVED', found_server['status'])
metadata = {'key_2': 'value_2'}
# Update Metadata item in SHELVED (not ACTIVE, etc.)
ex = self.assertRaises(client.OpenStackApiException,
self.api.post_server_metadata,
server_id, metadata)
self.assertEqual(409, ex.response.status_code)
self.assertEqual('SHELVED', found_server['status'])
# Delete Metadata item in SHELVED (not ACTIVE, etc.)
ex = self.assertRaises(client.OpenStackApiException,
self.api.delete_server_metadata,
server_id, 'key_1')
self.assertEqual(409, ex.response.status_code)
self.assertEqual('SHELVED', found_server['status'])
# Cleanup
self._delete_server(server_id)
def test_create_and_rebuild_server(self): def test_create_and_rebuild_server(self):
# Rebuild a server with metadata. # Rebuild a server with metadata.