openstack/nova
Code Issues Proposed changes

Trivial fix a missleading comment

Browse Source 
The comment for new volume detach workflow in rebuild instance
seems incorrect and missleading, the empty attachment is create
to prevent volume status turn to `available`, not `in-use`.

Change-Id: I13cc6a93a835b3b4766017a341f1e351758b9632
This commit is contained in:
Kevin_Zheng 2018-02-05 17:43:32 +08:00
parent 38eb95384f
commit a5294acee9
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
nova/compute/manager.py
View File

@ -3045,8 +3045,8 @@ class ComputeManager(manager.Manager):
# attach and detach the volumes through attachment level
# operations. In this scenario _detach_volume will delete
# the existing attachment which would make the volume
# status change to 'in-use' if we don't pre-create another
# empty attachment before deleting the old one.
# status change to 'available' if we don't pre-create
# another empty attachment before deleting the old one.
attachment_id = None
if bdm.attachment_id:
attachment_id = self.volume_api.attachment_create(