openstack/nova
Code Issues Proposed changes

Add timestamp to default log format, invert name and level for better readability, log version once at startup

Browse Source
This commit is contained in:
Thierry Carrez
2011-01-20 12:20:50 +01:00
parent 7d7fbf5dfd
commit a9c8ef0317
2 changed files with 8 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
nova/log.py
View File

@@ -40,15 +40,15 @@ from nova import version
FLAGS = flags.FLAGS
flags.DEFINE_string('logging_context_format_string',
'(%(name)s %(nova_version)s): %(levelname)s '
'%(asctime)s %(levelname)s %(name)s '
'[%(request_id)s %(user)s '
'%(project)s] %(message)s',
'format string to use for log messages')
'format string to use for log messages with context')
flags.DEFINE_string('logging_default_format_string',
'(%(name)s %(nova_version)s): %(levelname)s [N/A] '
'%(asctime)s %(levelname)s %(name)s [-] '
'%(message)s',
'format string to use for log messages')
'format string to use for log messages without context')
flags.DEFINE_string('logging_debug_format_suffix',
'from %(processName)s (pid=%(process)d) %(funcName)s'
@@ -56,7 +56,7 @@ flags.DEFINE_string('logging_debug_format_suffix',
'data to append to log format when level is DEBUG')
flags.DEFINE_string('logging_exception_prefix',
'(%(name)s): TRACE: ',
'%(asctime)s TRACE %(name)s: ',
'prefix each line of exception output with this format')
flags.DEFINE_list('default_log_levels',

4
nova/service.py
View File

@@ -38,6 +38,7 @@ from nova import log as logging
from nova import flags
from nova import rpc
from nova import utils
from nova import version
FLAGS = flags.FLAGS
@@ -156,7 +157,8 @@ class Service(object):
report_interval = FLAGS.report_interval
if not periodic_interval:
periodic_interval = FLAGS.periodic_interval
logging.audit(_("Starting %s node"), topic)
logging.audit(_("Starting %s node (version %s)"), topic,
version.version_string_with_vcs())
service_obj = cls(host, binary, topic, manager,
report_interval, periodic_interval)