openstack/nova
Code Issues Proposed changes

Move to hacking 0.10

Browse Source 
Release notes:
http://git.openstack.org/cgit/openstack-dev/hacking/tag/?id=0.10.0

* Remove references in tox.ini to removed rules
* Fix minor changes (H501)
* Clarify that H306 (imports in alphabetical order shouldn't be skipped)
* Ignore H238: check for old style class declarations
* Temporary skip W292, fix in next patch.

Change-Id: I6d990a564df6a312bd09b2a152315bbdba732082
This commit is contained in:
Joe Gordon 2015-01-07 12:09:54 -08:00
parent 5cde76ff0a
commit b39df562c7
2 changed files with 6 additions and 5 deletions

2
test-requirements.txt

@ -2,7 +2,7 @@
# of appearance. Changing the order has an impact on the overall integration # of appearance. Changing the order has an impact on the overall integration
# process, which may cause wedges in the gate later. # process, which may cause wedges in the gate later.
hacking>=0.9.2,<0.10 hacking>=0.10.0,<0.11
coverage>=3.6 coverage>=3.6
discover discover
feedparser feedparser

9
tox.ini

@ -62,14 +62,15 @@ commands = {posargs}
commands = python setup.py build_sphinx commands = python setup.py build_sphinx
[flake8] [flake8]
# H803 skipped on purpose per list discussion.
# E125 is deliberately excluded. See https://github.com/jcrocholl/pep8/issues/126 # E125 is deliberately excluded. See https://github.com/jcrocholl/pep8/issues/126
# The rest of the ignores are TODOs # The rest of the ignores are TODOs
# New from hacking 0.9: E129, E131, H407, H405, H904 # New from hacking 0.9: E129, E131, H407, H405
# E251 Skipped due to https://github.com/jcrocholl/pep8/issues/301 # E251 Skipped due to https://github.com/jcrocholl/pep8/issues/301
# H305,H306 Skipped due to inability to handle absolute_import # New from hacking 0.10: H238
# H306 was mistakenly ignored, TODO to re-add
# Temporarily skip W292 (new in hacking 0.10)
ignore = E121,E122,E123,E124,E125,E126,E127,E128,E129,E131,E251,H305,H306,H405,H803,H904 ignore = E121,E122,E123,E124,E125,E126,E127,E128,E129,E131,E251,H405,H238,H306,W292
exclude = .venv,.git,.tox,dist,doc,*openstack/common*,*lib/python*,*egg,build,tools/xenserver* exclude = .venv,.git,.tox,dist,doc,*openstack/common*,*lib/python*,*egg,build,tools/xenserver*
# To get a list of functions that are more complex than 25, set max-complexity # To get a list of functions that are more complex than 25, set max-complexity
# to 25 and run 'tox -epep8'. # to 25 and run 'tox -epep8'.