openstack/nova
Code Issues Proposed changes

Fix colorizier thowing exception when a test fails

Browse Source 
This failure in colorizier was hidding the actual error
in the tests. If we ran enough tests it also became difficult
to see which test had actually failed.

Fixes: bug 1183602

Change-Id: I806da8f13040b38258de7f3e0fa7b62700bdcead
This commit is contained in:
Michael Kerrin 2013-05-29 12:43:53 +00:00
parent db56c590e8
commit c182319039
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tools/colorizer.py
View File

@ -232,6 +232,8 @@ class NovaTestResult(testtools.TestResult):
self._addResult(test, 'OK', 'green', '.', True) self._addResult(test, 'OK', 'green', '.', True)
def addFailure(self, test, err): def addFailure(self, test, err):
if test.id() == 'process-returncode':
return
super(NovaTestResult, self).addFailure(test, err) super(NovaTestResult, self).addFailure(test, err)
self._addResult(test, 'FAIL', 'red', 'F', False) self._addResult(test, 'FAIL', 'red', 'F', False)