From 8223a84d047184e32391ef00ec6e568216c2e68c Mon Sep 17 00:00:00 2001 From: Balazs Gibizer Date: Thu, 3 Sep 2020 09:47:02 +0200 Subject: [PATCH] Remove no-op fake calls from network_info tests Stephen pointed out during the review of I4bdd25458998ca1a9fb411dfd015684a6d3fcfa3 that there are unnecessary calls in the network_info unit tests. So this patch now drop these. Change-Id: I5f9611e0d2eb212aaec299d27a4a29e6f7e3199c --- nova/tests/unit/network/test_network_info.py | 4 ---- 1 file changed, 4 deletions(-) diff --git a/nova/tests/unit/network/test_network_info.py b/nova/tests/unit/network/test_network_info.py index 07c4b562588f..1b90d1590739 100644 --- a/nova/tests/unit/network/test_network_info.py +++ b/nova/tests/unit/network/test_network_info.py @@ -28,7 +28,6 @@ from nova.virt import netutils class RouteTests(test.NoDBTestCase): def test_create_route_with_attrs(self): route = fake_network_cache_model.new_route() - fake_network_cache_model.new_ip(dict(address='192.168.1.1')) self.assertEqual('0.0.0.0/24', route['cidr']) self.assertEqual('192.168.1.1', route['gateway']['address']) self.assertEqual('eth0', route['interface']) @@ -332,8 +331,6 @@ class NetworkTests(test.NoDBTestCase): self.assertNotEqual(network1, network2) def test_hydrate(self): - fake_network_cache_model.new_subnet() - fake_network_cache_model.new_subnet(dict(cidr='255.255.255.255')) network = model.Network.hydrate(fake_network_cache_model.new_network()) self.assertEqual(1, network['id']) @@ -449,7 +446,6 @@ class VIFTests(test.NoDBTestCase): self.assertEqual(ip_dict, labeled_ips) def test_hydrate(self): - fake_network_cache_model.new_network() vif = model.VIF.hydrate(fake_network_cache_model.new_vif()) self.assertEqual(1, vif['id']) self.assertEqual('aa:aa:aa:aa:aa:aa', vif['address'])