openstack
/
nova
Code Issues Proposed changes

Merge "doc: require openstack client change for every new API microversion"

This commit is contained in:
Zuul 2021-01-20 17:04:42 +00:00 committed by Gerrit Code Review
parent d00af5dc17 65fb14c36e
commit cd794aa538
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
doc/source/contributor/code-review.rst
View File

@ -235,10 +235,12 @@ Microversion API
If a new microversion API is added, the following needs to happen: If a new microversion API is added, the following needs to happen:
* A new patch for the microversion API change in python-novaclient side * A new patch for the microversion API change in both python-novaclient
should be submitted before the microversion change in Nova is merged. and in python-openstackclient should be submitted before the microversion
See :python-novaclient-doc:`Adding support for a new microversion change in Nova is merged. See :python-novaclient-doc:`Adding support for a
<contributor/microversions>` in python-novaclient for more details. new microversion <contributor/microversions>` in python-novaclient for more
details. See also `Add support for 'server group create --rule' parameter`_
patch as example how to support a new microversion in the openstack client.
* If the microversion changes the response schema, a new schema and test for * If the microversion changes the response schema, a new schema and test for
the microversion must be added to Tempest. The microversion change in Nova the microversion must be added to Tempest. The microversion change in Nova
should not be merged until the Tempest test is submitted and at least should not be merged until the Tempest test is submitted and at least
@ -247,6 +249,8 @@ If a new microversion API is added, the following needs to happen:
should reference the Change-Id of the Tempest test for reviewers to identify should reference the Change-Id of the Tempest test for reviewers to identify
it. it.
.. _`Add support for 'server group create --rule' parameter`: https://review.opendev.org/#/c/761597
Notifications Notifications
============= =============