openstack/nova
Code Issues Proposed changes

Don't translate debug level logs in nova.virt

Browse Source 
Our translation policy
(https://wiki.openstack.org/wiki/LoggingStandards#Log_Translation) calls
for not translating debug level logs. This is to help prioritize log
translation. Furthermore translation has a performance overhead, even if
the log isn't used (since nova doesn't support lazy translation yet).

Change-Id: I524b48f530d8afd59a067074332e3964426e4d70
This commit is contained in:
Gary Kotton
2014-04-30 05:50:21 -07:00
parent 4d7a65d9f1
commit cfd0846498
61 changed files with 644 additions and 654 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
nova/virt/firewall.py
View File

@@ -183,9 +183,9 @@ class IptablesFirewallDriver(FirewallDriver):
self.network_infos[instance['id']] = network_info
ipv4_rules, ipv6_rules = self.instance_rules(instance, network_info)
self.add_filters_for_instance(instance, ipv4_rules, ipv6_rules)
LOG.debug(_('Filters added to instance'), instance=instance)
LOG.debug('Filters added to instance', instance=instance)
self.refresh_provider_fw_rules()
LOG.debug(_('Provider Firewall Rules refreshed'), instance=instance)
LOG.debug('Provider Firewall Rules refreshed', instance=instance)
# Ensure that DHCP request rule is updated if necessary
if (self.dhcp_create and not self.dhcp_created):
self.iptables.ipv4['filter'].add_rule(
@@ -367,7 +367,7 @@ class IptablesFirewallDriver(FirewallDriver):
rules = rules_cls.get_by_security_group(ctxt, security_group)
for rule in rules:
LOG.debug(_('Adding security group rule: %r'), rule,
LOG.debug('Adding security group rule: %r', rule,
instance=instance)
if not rule['cidr']:
@@ -498,7 +498,7 @@ class IptablesFirewallDriver(FirewallDriver):
ipv6_rules = []
rules = self._virtapi.provider_fw_rule_get_all(ctxt)
for rule in rules:
LOG.debug(_('Adding provider rule: %s'), rule['cidr'])
LOG.debug('Adding provider rule: %s', rule['cidr'])
version = netutils.get_ip_version(rule['cidr'])
if version == 4:
fw_rules = ipv4_rules