From cffbc2e431e90f7b6a67cf4a82349ee1d8de202a Mon Sep 17 00:00:00 2001
From: Eric Fried <openstack@fried.cc>
Date: Wed, 30 Oct 2019 16:18:31 -0500
Subject: [PATCH] Deprecate [glance]api_servers

When adding support for standard ksa config options in Queens [1], we
retained the [glance]api_servers option in case consumers wanted to
continue to rely on nova's rudimentary load balancing rather than
implementing something real. Continuing to support this option is
holding us back from the things that having a common standard across
services would facilitate, like using openstacksdk rather than clients.
So deprecate it.

[1] http://specs.openstack.org/openstack/nova-specs/specs/queens/implemented/use-ksa-adapter-for-endpoints.html

Change-Id: I8e3fbc6f8b052ead6e80d4243f76581960210277
---
 nova/conf/glance.py                                       | 8 ++++++++
 .../deprecate-glance-api_servers-d05695ea52b831e0.yaml    | 8 ++++++++
 2 files changed, 16 insertions(+)
 create mode 100644 releasenotes/notes/deprecate-glance-api_servers-d05695ea52b831e0.yaml

diff --git a/nova/conf/glance.py b/nova/conf/glance.py
index b96f437b0f36..18c50dd9f70f 100644
--- a/nova/conf/glance.py
+++ b/nova/conf/glance.py
@@ -29,6 +29,14 @@ glance_opts = [
     # NOTE(sdague/efried): there is intentionally no default here. This
     # requires configuration if ksa adapter config is not used.
     cfg.ListOpt('api_servers',
+        deprecated_for_removal=True,
+        deprecated_since='21.0.0',
+        deprecated_reason="""
+Support for image service configuration via standard keystoneauth1 Adapter
+options was added in the 17.0.0 Queens release. The api_servers option was
+retained temporarily to allow consumers time to cut over to a real load
+balancing solution.
+""",
         help="""
 List of glance api servers endpoints available to nova.
 
diff --git a/releasenotes/notes/deprecate-glance-api_servers-d05695ea52b831e0.yaml b/releasenotes/notes/deprecate-glance-api_servers-d05695ea52b831e0.yaml
new file mode 100644
index 000000000000..3b31ed6c4c7d
--- /dev/null
+++ b/releasenotes/notes/deprecate-glance-api_servers-d05695ea52b831e0.yaml
@@ -0,0 +1,8 @@
+---
+deprecations:
+  - |
+    The ``[glance]api_servers`` configuration option is deprecated and will be
+    removed in a future release. Deployments should use standard keystoneauth1
+    options to configure communication with a single image service endpoint.
+    Any load balancing or high availability requirements should be satisfied
+    outside of nova.