openstack
/
nova
Code Issues Proposed changes

Mock.side_effects does not exist, use Mock.side_effect instead 

Mock.side_effects property does not exist, we should use
Mock.side_effect instead in the test case.

Closes-Bug: #1626880
Change-Id: If64609b1bbe658b5523bf57abb62e9e9b2c44322
This commit is contained in:
Javeme 2016-09-23 15:26:10 +08:00
parent c40b5fbc1d
commit d1662d533f
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
nova/tests/unit/api/openstack/compute/test_flavors_extra_specs.py
View File

@ -244,7 +244,7 @@ class FlavorsExtraSpecsTestV21(test.TestCase):
@mock.patch('nova.objects.flavor._flavor_extra_specs_add')
def test_create_valid_specs_key(self, mock_flavor_extra_specs):
valid_keys = ("key1", "month.price", "I_am-a Key", "finance:g2")
mock_flavor_extra_specs.side_effects = return_create_flavor_extra_specs
mock_flavor_extra_specs.side_effect = return_create_flavor_extra_specs
for key in valid_keys:
body = {"extra_specs": {key: "value1"}}

2
nova/tests/unit/virt/xenapi/test_volumeops.py
View File

@ -540,7 +540,7 @@ class CleanupFromVDIsTestCase(VolumeOpsTestBase):
vdi_refs = ['vdi_ref1', 'vdi_ref2']
sr_refs = ['sr_ref1', 'sr_ref2']
find_sr_from_vdi.side_effect = sr_refs
purge_sr.side_effects = [test.TestingException, None]
purge_sr.side_effect = [test.TestingException, None]
self.ops.safe_cleanup_from_vdis(vdi_refs)
self._check_find_purge_calls(find_sr_from_vdi, purge_sr, vdi_refs,