openstack
/
nova
Code Issues Proposed changes

consoleauth: remove an instance of mutation while iterating 

Mutating a list while iterating over it is a big python no-no. Let's not
do it in consoleauth service anymore.

Change-Id: I50d201f3f39576d7a32b722ead0667fd9abaeb75
This commit is contained in:
Nikola Dipanov 2015-04-01 12:04:00 +01:00
parent 0012f8bde2
commit d2e7ec4b7d
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
nova/consoleauth/manager.py
View File

@ -84,12 +84,11 @@ class ConsoleAuthManager(manager.Manager):
LOG.warning(_LW("Token: %(token)s failed to save into memcached."),
{'token': token})
tokens = self._get_tokens_for_instance(instance_uuid)
# Remove the expired tokens from cache.
for tok in tokens:
token_str = self.mc.get(tok.encode('UTF-8'))
if not token_str:
tokens.remove(tok)
tokens = [tok for tok in tokens if self.mc.get(tok.encode('UTF-8'))]
tokens.append(token)
if not self.mc.set(instance_uuid.encode('UTF-8'),
jsonutils.dumps(tokens)):
LOG.warning(_LW("Instance: %(instance_uuid)s failed to save "