From d534b290a12235f4e6d9afcbfb9d3aba4486e6cc Mon Sep 17 00:00:00 2001 From: Joe Gordon Date: Tue, 28 May 2013 06:59:13 +0300 Subject: [PATCH] Fix and enable flake8 F823 F823 local variable 'blah' (defined in enclosing scope on line xx) referenced before assignment Change-Id: I721e1339ef023558032980bbf59e8dc44b391d52 --- nova/tests/test_instance_types.py | 4 ++-- tox.ini | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/nova/tests/test_instance_types.py b/nova/tests/test_instance_types.py index e20845f1d2c1..d8a915730bed 100644 --- a/nova/tests/test_instance_types.py +++ b/nova/tests/test_instance_types.py @@ -31,8 +31,8 @@ class InstanceTypeTestCase(test.TestCase): def _generate_name(self): """return a name not in the DB.""" nonexistent_flavor = str(int(time.time())) - flavors = flavors.get_all_types() - while nonexistent_flavor in flavors: + all_flavors = flavors.get_all_types() + while nonexistent_flavor in all_flavors: nonexistent_flavor += "z" else: return nonexistent_flavor diff --git a/tox.ini b/tox.ini index 218f52b75a15..44135b88a38c 100644 --- a/tox.ini +++ b/tox.ini @@ -40,7 +40,7 @@ commands = commands = {posargs} [flake8] -ignore = E12,E711,E712,H302,H303,H403,H404,F403,F811,F823,F841 +ignore = E12,E711,E712,H302,H303,H403,H404,F403,F811,F841 builtins = _ exclude = .venv,.git,.tox,dist,doc,*openstack/common*,*lib/python*,*egg,build,plugins,tools