openstack
/
nova
Code Issues Proposed changes

pci: Add logging for filtering 

This is possibly quite noisy, but it should give some kind of breadcrumb
to suggest why a host was rejected. It can be particularly beneficial
for devices with SR-IOV devices, which as noted on bug #1852727 are
filtered out by default.

Change-Id: I67455d4ecfafed96cb0f3f9fbe6f94808bd05909
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Related-Bug: #1852727
This commit is contained in:
Stephen Finucane 2020-11-26 17:43:04 +00:00
parent c2357ab9f3
commit d81ef45041
1 changed files with 35 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

37
nova/pci/stats.py
View File

@ -371,19 +371,52 @@ class PciDeviceStats(object):
# Firstly, let's exclude all devices that don't match our spec (e.g.
# they've got different PCI IDs or something)
before_count = sum([pool['count'] for pool in pools])
pools = cls._filter_pools_for_spec(pools, request)
after_count = sum([pool['count'] for pool in pools])
if after_count < before_count:
LOG.debug(
'Dropped %d devices due to mismatched PCI attribute(s)',
before_count - after_count
)
if after_count < request.count:
LOG.debug('Not enough PCI devices left to satify request')
return None
# Next, let's exclude all devices that aren't on the correct NUMA node
# *assuming* we have devices and care about that, as determined by
# policy
before_count = after_count
pools = cls._filter_pools_for_numa_cells(pools, request, numa_cells)
after_count = sum([pool['count'] for pool in pools])
if after_count < before_count:
LOG.debug(
'Dropped %d devices as they are on the wrong NUMA node(s)',
before_count - after_count
)
if after_count < request.count:
LOG.debug('Not enough PCI devices left to satify request')
return None
# Finally, if we're not requesting PFs then we should not use these.
# Exclude them.
before_count = after_count
pools = cls._filter_pools_for_unrequested_pfs(pools, request)
after_count = sum([pool['count'] for pool in pools])
# Do we still have enough devices left?
if sum([pool['count'] for pool in pools]) < request.count:
if after_count < before_count:
LOG.debug(
'Dropped %d devices as they are PFs which we have not '
'requested',
before_count - after_count
)
if after_count < request.count:
LOG.debug('Not enough PCI devices left to satify request')
return None
return pools