openstack/nova
Code Issues Proposed changes

Deprecate cinder.cross_az_attach option

Browse Source 
Introduced in 1504cbc5d4 in Grizzly, the
use cases around this option are unclear but there have been several
bugs related to it.

For example, 6060888b58 changed boot from
volume to pass the server instance availability zone to cinder when
creating the volume.  However, if that same AZ does not exist in Cinder,
the volume create request will fail - which is bug 1496235.

Cinder works around this with b85d2812a8256ff82934d150dbc4909e041d8b31
using a config option to allow falling back to a default Cinder AZ if
the one requested does not exist.  By default this fallback is disabled
though.

It also sounds like availability zones in Cinder were an artifact from
when Cinder was split out from the nova-volume service, but Cinder AZ
use cases are also unclear.  And it's also unclear what the relationship
is between AZs in Nova and Cinder.

So given the problems here and the lack of a clear use case to justify
having this configuration option in tree, along with it's added
complexity, deprecate the option for removal.

Related-Bug: #1496235
Related-Bug: #1380780
Related-Bug: #1489575
Related-Bug: #1497253

Change-Id: I52cd3d8867d3b35f5caba377302bfc52c112f1d6
This commit is contained in:
Matt Riedemann 2015-09-23 13:21:06 -07:00
parent 6d7369465f
commit d8d2f02f30
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
nova/volume/cinder.py
View File

@ -52,8 +52,11 @@ cinder_opts = [
help='Number of cinderclient retries on failed http calls'),
cfg.BoolOpt('cross_az_attach',
default=True,
help='Allow attach between instance and volume in different '
'availability zones.'),
deprecated_for_removal=True,
help='DEPRECATED: Allow attach between instance and volume '
'in different availability zones. This option is '
'deprecated in the 13.0.0 release and will be removed '
'in the 14.0.0 release.'),
]
CONF = cfg.CONF