openstack/nova
Code Issues Proposed changes

Remove unused _get_flags method from integrated_helpers

Browse Source 
_get_flags method was mainly used by sample tests to add
extensions which are no more valid as sample tests are merged
for extensions and running with all extensions enable.

This patch removes this unused method.

Partially implements blueprint api-sample-tests-with-all-extensions

Change-Id: I92bb2f4fe7c61183f95883cc9f31860f66b9a0b5
This commit is contained in:
ghanshyam 2016-06-10 15:46:07 +09:00
parent f44d1aff9d
commit dd7015cd6f
1 changed files with 0 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
nova/tests/functional/integrated_helpers.py
View File

@ -66,8 +66,6 @@ class _IntegratedTestBase(test.TestCase):
def setUp(self): def setUp(self):
super(_IntegratedTestBase, self).setUp() super(_IntegratedTestBase, self).setUp()
f = self._get_flags()
self.flags(**f)
self.flags(verbose=True) self.flags(verbose=True)
nova.tests.unit.image.fake.stub_out_image_service(self) nova.tests.unit.image.fake.stub_out_image_service(self)
@ -103,14 +101,6 @@ class _IntegratedTestBase(test.TestCase):
self.network = self.start_service('network') self.network = self.start_service('network')
self.scheduler = self._setup_scheduler_service() self.scheduler = self._setup_scheduler_service()
def _get_flags(self):
"""Allow subclass to modify global config before we start services."""
# NOTE(sdague): _get_flags is used by about 13 tests that
# subclass this mostly to modify the extensions list. We
# should instead make that declarative in the future, at which
# point we can get rid of this.
return {}
def get_unused_server_name(self): def get_unused_server_name(self):
servers = self.api.get_servers() servers = self.api.get_servers()
server_names = [server['name'] for server in servers] server_names = [server['name'] for server in servers]