openstack/nova
Code Issues Proposed changes

Bug #912858: test_authors_up_to_date does not deal with capitalized names properly

Browse Source 
ensure we are not fooled by capitalized names, by turning emails and names into lower cases before the matching.

Change-Id: Idbb8535174c0f1451ad6fd0628f35508f0f1e466
This commit is contained in:
Armando Migliaccio 2012-01-06 17:49:57 +00:00
parent 613d1dbc87
commit de4fb9302a
2 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
nova/tests/test_misc.py
View File

@ -47,7 +47,8 @@ class ProjectTestCase(test.TestCase):
missing = set() missing = set()
contributors = set() contributors = set()
mailmap = parse_mailmap(os.path.join(topdir, '.mailmap')) mailmap = parse_mailmap(os.path.join(topdir, '.mailmap'))
authors_file = open(os.path.join(topdir, 'Authors'), 'r').read() authors_file = open(os.path.join(topdir,
'Authors'), 'r').read().lower()
if os.path.exists(os.path.join(topdir, '.git')): if os.path.exists(os.path.join(topdir, '.git')):
for email in commands.getoutput('git log --format=%ae').split(): for email in commands.getoutput('git log --format=%ae').split():
@ -55,7 +56,7 @@ class ProjectTestCase(test.TestCase):
continue continue
if "jenkins" in email and "openstack.org" in email: if "jenkins" in email and "openstack.org" in email:
continue continue
email = '<' + email + '>' email = '<' + email.lower() + '>'
contributors.add(str_dict_replace(email, mailmap)) contributors.add(str_dict_replace(email, mailmap))
else: else:
return return

2
nova/utils.py
View File

@ -544,7 +544,7 @@ def parse_mailmap(mailmap='.mailmap'):
l = l.strip() l = l.strip()
if not l.startswith('#') and ' ' in l: if not l.startswith('#') and ' ' in l:
canonical_email, alias = l.split(' ') canonical_email, alias = l.split(' ')
mapping[alias] = canonical_email mapping[alias.lower()] = canonical_email.lower()
return mapping return mapping