openstack
/
nova
Code Issues Proposed changes

Merge "Add missing descriptions in HACKING.rst"

This commit is contained in:
Zuul 2022-09-06 18:25:09 +00:00 committed by Gerrit Code Review
parent b542b53585 a85d052a22
commit df366cab7c
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
HACKING.rst
View File

@ -71,6 +71,11 @@ Nova Specific Commandments
- [N367] Disallow aliasing the mock.Mock and similar classes in tests.
- [N368] Reject if the mock.Mock class is used as a replacement value instead of and
instance of a mock.Mock during patching in tests.
- [N369] oslo_concurrency.lockutils.ReaderWriterLock() or
fasteners.ReaderWriterLock() does not function correctly
with eventlet patched code. Use nova.utils.ReaderWriterLock() instead.
- [N370] Don't use or import six
- [N371] You must explicitly import python's mock: ``from unittest import mock``
Creating Unit Tests
-------------------