openstack/nova
Code Issues Proposed changes

Fixes bug 888649

Browse Source 
Change exception.VolumeIsBusy to derive from NovaException instead of
Error, so that an 'unexpected keyword' exception is not thrown when
the exception is raised with keyword parameters.

Add unit test to confirm that the 'unexpected keyword' exception is not
thrown when the exception is raised by nova.volume.driver.VolumeDriver

Responded to reviewer observations, fix pep8 errors in tset_volume.py,
added email address to Authors file.

Change-Id: I15464cb0cf72a2c71f430e4c8c5c2b27cd4e2ef9
This commit is contained in:
Ollie Leahy
2011-11-24 15:56:08 +00:00
parent 43bb342296
commit e0ef89f091
3 changed files with 30 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
nova/exception.py
View File

@@ -396,7 +396,7 @@ class SnapshotNotFound(NotFound):
message = _("Snapshot %(snapshot_id)s could not be found.")
class VolumeIsBusy(Error):
class VolumeIsBusy(NovaException):
message = _("deleting volume %(volume_name)s that has snapshot")