openstack/nova
Code Issues Proposed changes

validates device parameter for attach-volume

Browse Source
This commit is contained in:
Jesse Andrews 2010-10-25 21:44:02 +00:00 committed by Tarmac
commit ebffd9cb35
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
nova/api/ec2/cloud.py
View File

@ -25,6 +25,7 @@ datastore.
import base64 import base64
import datetime import datetime
import logging import logging
import re
import os import os
import time import time
@ -519,6 +520,9 @@ class CloudController(object):
def attach_volume(self, context, volume_id, instance_id, device, **kwargs): def attach_volume(self, context, volume_id, instance_id, device, **kwargs):
volume_ref = db.volume_get_by_ec2_id(context, volume_id) volume_ref = db.volume_get_by_ec2_id(context, volume_id)
if not re.match("^/dev/[a-z]d[a-z]+$", device):
raise exception.ApiError("Invalid device specified: %s. "
"Example device: /dev/vdb" % device)
# TODO(vish): abstract status checking? # TODO(vish): abstract status checking?
if volume_ref['status'] != "available": if volume_ref['status'] != "available":
raise exception.ApiError("Volume status must be available") raise exception.ApiError("Volume status must be available")