openstack
/
nova
Code Issues Proposed changes

Merge "Remove unecessary `get_boolean` function"

This commit is contained in:
Jenkins 2013-10-03 07:08:01 +00:00 committed by Gerrit Code Review
parent 26f6b9d6d5 c79afcbbf8
commit ecc5fb78ab
2 changed files with 2 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
nova/utils.py
View File

@ -49,7 +49,6 @@ from nova.openstack.common import lockutils
from nova.openstack.common import log as logging
from nova.openstack.common import processutils
from nova.openstack.common.rpc import common as rpc_common
from nova.openstack.common import strutils
from nova.openstack.common import timeutils
notify_decorator = 'nova.notifications.notify_decorator'
@ -1267,10 +1266,3 @@ def get_image_from_system_metadata(system_meta):
image_meta['properties'] = properties
return image_meta
def get_boolean(value):
if isinstance(value, bool):
return value
else:
return strutils.bool_from_string(value)

3
nova/virt/vmwareapi/vmops.py
View File

@ -41,6 +41,7 @@ from nova import exception
from nova.openstack.common import excutils
from nova.openstack.common.gettextutils import _
from nova.openstack.common import log as logging
from nova.openstack.common import strutils
from nova import utils
from nova.virt import configdrive
from nova.virt import driver
@ -643,7 +644,7 @@ class VMwareVMOps(object):
# this will never be not-set by this point.
value = global_linked_clone
return utils.get_boolean(value)
return strutils.bool_from_string(value)
def get_copy_virtual_disk_spec(self, client_factory, adapter_type,
disk_type):