From ef7e2a198885d35ec2b6bfa58022964a0c5d19ad Mon Sep 17 00:00:00 2001 From: melanie witt Date: Tue, 3 Apr 2018 23:12:52 +0000 Subject: [PATCH] Default to py3 for the pep8 tox env because it's stricter We recently fixed a couple of pep8 failures under py3 [0] which got through because we're not gating pep8 on py3. This changes the python version for the pep8 tox env to python3 because the py3 checks are stricter. This updates the fast8 tox env as well. [0] https://review.openstack.org/#/c/557633 Change-Id: I540377606a8224ba569b8c145773e7d057575bd8 --- tox.ini | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tox.ini b/tox.ini index 7e88d1a833f3..34e6a896eead 100644 --- a/tox.ini +++ b/tox.ini @@ -45,6 +45,8 @@ commands = env TEST_OSPROFILER=1 stestr run --combine --no-discover 'nova.tests.unit.test_profiler' [testenv:pep8] +# Let's gate pep8 under py3 by default because the py3 checks are stricter. +basepython = python3 deps = {[testenv]deps} commands = bash tools/flake8wrap.sh {posargs} @@ -54,6 +56,8 @@ commands = bash -c '! find doc/ -type f -name *.json | xargs -t -n1 python -m json.tool 2>&1 > /dev/null | grep -B1 -v ^python' [testenv:fast8] +# Let's run fast8 under py3 by default because the py3 checks are stricter. +basepython = python3 # This is a subset of the full pep8 check which # only runs flake8 on the changes made since # HEAD-1. For a full flake8 run including checking