openstack/nova
Code Issues Proposed changes

Workaround reno reverts by accepting warnings

Browse Source 
b2acc9fa86 on stable/liberty introduced a
sphinx warning which was not treated as an error in stable/liberty nova
releasenotes tox runs so it slipped in, but it is treated as an error
in master branch nova releasenotes tox runs, and since reno scans the
branches, master is broken because of the error in stable/liberty.

Plus, reno scans the git history, so right now it's not obvious how to
travel back in time and fix the stable/liberty change.

This change reduces the level of control we have by not treating reno warnings
as errors. This is not fun but it's the only way we can still land
release notes until an appropriate fix is merged (in reno or nova).

Again, this is a temporary patch and we consider reverting it once bug 1534613
is fixed.

Change-Id: Iedb69c66632383e056840e3294a90cda651a8778
Related-Bug: #1534613
This commit is contained in:
Sylvain Bauza 2016-01-15 16:16:52 +01:00 committed by Matt Riedemann
parent b558d616c3
commit ef8335185a
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
tox.ini
View File

@ -138,7 +138,8 @@ commands = {[testenv:docs]commands}
commands = bandit -c bandit.yaml -r nova -n 5 -ll
[testenv:releasenotes]
commands = sphinx-build -a -E -W -d releasenotes/build/doctrees -b html releasenotes/source releasenotes/build/html
# FIXME(sbauza): warnings are temporarily treated as okay because of bug 1534613
commands = sphinx-build -a -E -d releasenotes/build/doctrees -b html releasenotes/source releasenotes/build/html
[flake8]
# E125 is deliberately excluded. See https://github.com/jcrocholl/pep8/issues/126