openstack
/
nova
Code Issues Proposed changes

Merge "pci: Validate behavior of empty devname"

This commit is contained in:
Jenkins 2017-09-21 13:57:54 +00:00 committed by Gerrit Code Review
parent 0f80a052dc faf25e71b7
commit f930d3008d
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
nova/tests/unit/pci/test_devspec.py
View File

@ -412,6 +412,13 @@ class PciDevSpecTestCase(test.NoDBTestCase):
self.assertRaises(exception.PciDeviceInvalidDeviceName,
devspec.PciDeviceSpec, pci_info)
def test_blank_devname(self):
pci_info = {"devname": "", "physical_network": "hr_net"}
pci = devspec.PciDeviceSpec(pci_info)
for field in ['domain', 'bus', 'slot', 'func']:
self.assertEqual('*', getattr(
pci.address.pci_address_spec, field))
@mock.patch('nova.pci.utils.get_function_by_ifname',
return_value = ("0000:0a:00.0", True))
def test_by_name(self, mock_get_function_by_ifname):