libvirt: fix alternative_device_name for detaching interfaces
There are two changes here: 1. Get the actual vif device name for logging, e.g. tap3e81295f-c1 2. Log that in detach_device_with_retry so we're not logging an LibvirtConfigGuestInterface object. Change-Id: I7588c17a9936eb765269c662cad4cbedc5f58fbf Related-Bug: #1696125
This commit is contained in:
parent
7681d3dcc0
commit
fabfb347f5
|
@ -1467,7 +1467,7 @@ class LibvirtDriver(driver.ComputeDriver):
|
||||||
# timeout.
|
# timeout.
|
||||||
wait_for_detach = guest.detach_device_with_retry(
|
wait_for_detach = guest.detach_device_with_retry(
|
||||||
guest.get_interface_by_cfg, cfg, live=live,
|
guest.get_interface_by_cfg, cfg, live=live,
|
||||||
alternative_device_name=vif.get('address'))
|
alternative_device_name=self.vif_driver.get_vif_devname(vif))
|
||||||
wait_for_detach()
|
wait_for_detach()
|
||||||
except exception.DeviceNotFound:
|
except exception.DeviceNotFound:
|
||||||
# The interface is gone so just log it as a warning.
|
# The interface is gone so just log it as a warning.
|
||||||
|
|
|
@ -429,9 +429,11 @@ class Guest(object):
|
||||||
|
|
||||||
persistent = self.has_persistent_configuration()
|
persistent = self.has_persistent_configuration()
|
||||||
|
|
||||||
LOG.debug('Attempting initial detach for device %s', device)
|
LOG.debug('Attempting initial detach for device %s',
|
||||||
|
alternative_device_name)
|
||||||
_try_detach_device(conf, persistent, live)
|
_try_detach_device(conf, persistent, live)
|
||||||
LOG.debug('Start retrying detach until device %s is gone.', device)
|
LOG.debug('Start retrying detach until device %s is gone.',
|
||||||
|
alternative_device_name)
|
||||||
|
|
||||||
@loopingcall.RetryDecorator(max_retry_count=max_retry_count,
|
@loopingcall.RetryDecorator(max_retry_count=max_retry_count,
|
||||||
inc_sleep_time=inc_sleep_time,
|
inc_sleep_time=inc_sleep_time,
|
||||||
|
|
Loading…
Reference in New Issue