openstack/nova
Code Issues Proposed changes

tests: Pass parameters to sqlalchemy.text() as bindparams

Browse Source 
This appears to be the new way to do things.

Change-Id: Ieec4d62b3ef7614fdd2ebf57aa5bc1763bdf7b5a
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
This commit is contained in:
Stephen Finucane 2023-04-17 16:48:11 +01:00
parent b2520d6728
commit fd742c176b
1 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
nova/tests/unit/test_fixtures.py
View File

@ -180,9 +180,7 @@ class TestDatabaseFixture(testtools.TestCase):
conn.execute(
sa.text(
"INSERT INTO cell_mappings (uuid, name) VALUES (:uuid, :name)"
),
uuid=uuid,
name='fake-cell',
).bindparams(uuid=uuid, name='fake-cell'),
)
result = conn.execute(sa.text("SELECT * FROM cell_mappings"))
rows = result.fetchall()
@ -226,9 +224,7 @@ class TestDatabaseFixture(testtools.TestCase):
conn.execute(
sa.text(
"INSERT INTO cell_mappings (uuid, name) VALUES (:uuid, :name)"
),
uuid=uuid,
name='fake-cell',
).bindparams(uuid=uuid, name='fake-cell'),
)
result = conn.execute(sa.text("SELECT * FROM cell_mappings"))
rows = result.fetchall()