11 Commits

Author SHA1 Message Date
Jenkins
7f910cddc3 Merge "Cleanup tools/hacking using flake8" 2012-05-31 01:50:46 +00:00
Matt Joyce
d5cc5fd2f0 Grammar fixes.
Change-Id: Iff3f5765193e0bc98dfc377ee5a9b6f47ae11859
2012-05-29 13:01:57 -07:00
Joe Gordon
6e480708ee Cleanup tools/hacking using flake8
Change-Id: Ia151f265bf62e6704de6cc2f2c01963be9e2dd69
2012-05-24 12:03:37 -07:00
Brian Waldon
317378f742 Update pep8 dependency to v1.1
The latest release of pep8 adds stricter rules for extraneous
whitespace within lines. This patch also addresses these new
violations acoss the codebase.

Change-Id: Ib7e50281870473df1704ed50868c5c2e26bdb02e
2012-05-24 06:59:05 -07:00
Joe Gordon
82e1019edb Number of missing imports should always be shown
In tools/hacking.py

Change-Id: I1219dcc140594be97fc680981a122157fed2e279
2012-04-24 13:00:13 -07:00
Joe Gordon
7ee0d7848d Improved tools/hacking.py
* cleaner output
* fix bug 980009
* Fix N201
* N306: alphabetical order imports
* N401: docstring start
* N402: one line docstring start
* N403: multi line docstring end
* Until fixed, N40* will be disabled by default

Change-Id: I9addafdaa7a1f8fb950e14a5409f661dec6c7b87
2012-04-24 09:29:43 -07:00
Yuriy Taraday
4fe6f839bd Improved localization testing.
Moved localization tests to tools/hacking.py.

Change-Id: I903b90dfb09a46a72b1c64c30301f90661999f5b
2012-04-10 22:01:55 +04:00
Yuriy Taraday
f7a6c58d92 HACKING fixes, sqlalchemy fix.
Add exceptions to hacking.py make sqlalchemy stuff legal and prevent
clutter.

Change-Id: I44b100b4c0c4dfcec81beea7aba2d8598d5a08d0
2012-04-09 18:00:40 +04:00
Yuriy Taraday
01a938f7fe HACKING fixes, all but sqlalchemy.
Looks like this fixes all HACKING problems that were around.
Thanks to Dina Belova and Alexander Kovalev for this work.

Change-Id: I8157f0d4890184c1216aab63ef7180ee8b7a184d
2012-03-07 12:51:39 +04:00
Joe Gordon
e8bc00eff2 Add assertRaises check to tools/hacking.py as N202
Change-Id: I25113bcc73ff642cae146f0558f319684b4568d0
2012-03-05 14:09:57 -08:00
Joe Gordon
9a08e00548 Add HACKING compliance testing to run_test.sh
Tests so far:
N101 TODO format
N201 Except format
N301 One import per line
N302 import only modules
N303 Invalid Import
N304 Relative Import

Change-Id: I33c021b842e7199b1f5f1f699ea17f7fa5f8ca49
2012-01-24 10:54:17 -08:00