openstack/nova - nova - OpenDev: Free Software Needs Free Tools

Author	SHA1	Message	Date
Matt Riedemann	14a3b1318c	Skip test_parallel_evacuate_with_server_group until fixed This test has a high failure rate so let's skip it until the bug is fixed: http://status.openstack.org/elastic-recheck/#1763181 Change-Id: Idcd2e7118c8d985d6d2cc4b12c08388406229bbf Related-Bug: #1763181	4 years ago
Matthew Booth	c333e7e12e	Raise error on timeout in wait_for_versioned_notifications fake_notifier.wait_for_versioned_notifications previously returned None if it timed out. This is counter-intuitive, and several callers were failing to check its return. Every one of these represents a race as it means we can continue past a barrier without its condition having been met. This change makes it default to safe by raising an exception if it times out. Note that it's possible this may subsequently result in new non-deterministic errors in functional. I would consider this a feature, as these were previously hidden. They should be addressed individually. This change highlights several deterministically incorrect uses of wait_for_versioned_notifications which were previously always silently timing out. These are all fixed. We also increase the default timeout from 1 to 10 seconds as we seem to hit the 1 second timeout in practise, e.g.: http://logs.openstack.org/46/578846/14/check/nova-tox-functional/8a444c1/job-output.txt.gz Change-Id: I017d1a31139c9300642dd706eadc265f7c954ca8	4 years ago
Takashi NATSUME	5133a543b9	Remove unused LOG variables TrivialFix Change-Id: I84f80aa75fb455039e5b56ae4d49a5f77db9097a	4 years ago
Balazs Gibizer	edeeaf9102	Add late server group policy check to rebuild The affinity and anti-affinity server group policy is enforced by the scheduler but two parallel scheduling could cause that such policy is violated. During instance boot a late policy check was performed in the compute manager to prevent this. This check was missing in case of rebuild. Therefore two parallel evacuate command could cause that the server group policy is violated. This patch introduces the late policy check to rebuild to prevent such situation. When the violation is detected during boot a re-scheduling happens. However the rebuild action does not have the re-scheduling implementation so in this case the rebuild will fail and the evacuation needs to be retried by the user. Still this is better than allowing a parallel evacuation to break the server group affinity policy. To make the late policy check possible in the compute/manager the rebuild_instance compute RPC call was extended with a request_spec parameter. Co-Authored-By: Richard Zsarnoczai <richard.zsarnoczai@ericsson.com> Change-Id: I752617066bb2167b49239ab9d17b0c89754a3e12 Closes-Bug: #1735407	4 years ago
Balazs Gibizer	33d87707d8	Add regression test for bug 1735407 Parallel evacuation can violate server group policy. This patch adds functional test to recreate the bug. The _wait_for_migration_status helper needed to be moved upper in the test calls hierarchy so it can be reused for this test too. Change-Id: I5bc50f9c0913a5b02c42f4ab201e9bf097395b54 Related-Bug: #1735407	4 years ago