This makes hacking.py complain if someone adds something like:
from nova import db
into any of the files in nova/virt/* (aside from the fake.py file).
It also removes the rest of the dangling db imports that are no
longer needed.
Yay!
Change-Id: Iba3d53b87e65e33a55f8e5033b5d1d33b28d12f7
Prefixing the commit message's first line with the driver makes it
easier for reviewers, at a glance, to find reviews that relate to their
area of expertise as well as improving the overall readability of the
git history.
Change-Id: I376d2cdb5dc344717fb7749a80e33ee88603e68c
The HACKING file contains a short example of an effective
commit message. For reasons for space, it cannot describe
the rationale behind this example. It also does not have
space to describe how to split up a patch into a series
of commits. Add a link from the HACKING file to the wiki
http://wiki.openstack.org/GitCommitMessages
where further information can be found
Change-Id: I34d44485486b623b11743106f09d5ef631d35888
* cleaner output
* fix bug 980009
* Fix N201
* N306: alphabetical order imports
* N401: docstring start
* N402: one line docstring start
* N403: multi line docstring end
* Until fixed, N40* will be disabled by default
Change-Id: I9addafdaa7a1f8fb950e14a5409f661dec6c7b87
Just putting this out there... I'm pretty sure that
import nova.flags
comes after
from nova.endpoint import cloud
Unless I'm totally misunderstanding how this is supposed to work,
which is likely.
Change-Id: I51096ab25dbca42d73a593872b83b25f2c451210
unittest will keep each test case around after completion pinning any
objects references by attributes on the test case. This can bloat
the memory used during a full test suite run to the point where
the test suite will require much more memory than running all of
the services does. On systems witout lots of memory, test suite
failures will occur as test cases cannot fork to execute programs.
Clearing out __dict__ of any attributes that don't start with a _
(since some are needed by unittest itself) reduces memory
significantly. This does require the super class tearDown to be
called last in some cases however.
Change-Id: I0e660b6c2a77c5613c5a523ba0a64c3d7f6dd128
Expecting that Exception is raised can end up passing an a test when an
unexpected error occurs. For instance, errors in the unit test itself
can be masked:
https://review.openstack.org/4848https://review.openstack.org/4873https://review.openstack.org/4874
Change a variety of unit tests to expect a more specific exception so
we don't run into false positive tests in the future.
Change-Id: Ibc0c63b1f6b5574a3ce93d9f02c9d1ff5ac4a8b0
Use openstack-common's update.py script to pull in some recent changes:
* Add the Mapping interface to cfg.ConfigOpts
* Add support to cfg for disabling interspersed args
Make use of both of these in nova/flags.py.
Add some dire warnings to HACKING about directly modifying the copy of
openstack-common code. I'm confident they won't be ignored :-)
Change-Id: I7ef75d18922c0bbb8844453b48cad0418034bc11
Removes the requirement for a trailing blank line in multiline
docstrings, just before the closing '"""'. This blank line is not
needed anymore, as the editors it was recommended for no longer
have the problem that this blank line was working around.
Change-Id: I4e532231f1d99e9f5048cbfcc791a4328fb1e8f5
This commit begins to implement blueprint consolidate-testing-infrastructure by
adding a 'testing' subpackage and moving some modules into it.
Change-Id: I04bf860bc386bd2016e7dbc5a6f6ef7379a855bb