As discussed in the Liberty Design Summit "Moving apps to Python 3"
cross-project workshop, the way forward in the near future is to
switch to the pure-python PyMySQL library as a default.
https://etherpad.openstack.org/p/liberty-cross-project-python3
Change-Id: I590c26523f4dc8d14c45e61bb89555486629b64d
The diagrams were hard to read and update. Replaced them with
simplified diagrams and tables. I used the content as is. I looks
inconsistent to me, but should now be easier to change.
Partially implements: blueprint devref-refresh-liberty
Change-Id: I707e1a6ab69ef44448b66e8be007307b5d73eb06
This change adds a basic bandit config for Nova. It can be invoked
by running the tox environment for bandit;
tox -e bandit
This is intended as a starting point for using bandit with Nova
and it should be revisited to improve the testing as more is learned
about the specific needs of the Nova code base.
Tox is configured to only show results for high and medium severity
results.
https://wiki.openstack.org/wiki/Security/Projects/Bandit
Change-Id: I3026b81317f0a6322acfc94784899a7453af586f
Lots of details on the global requirements patch that
this Depends-On.
Essentially, nova tests are broken with the oslo.vmware
release and we need to block this version.
Partial-Bug: #1459021
Depends-On: Icf1ce8dbb4b2c0b6b627d5d8be0b85a42e99c784
Change-Id: I4b9a471c9783dff769cbdec2e534bb0157f141f6
we should just use what oslo.vmware requires. Transitive
dependency should be enough for Nova.
Remove a few imports in a test case to pass the nova
policy of "if any explicit import then need an entry
in requirements".
Also remove tests relating to suds as oslo.vmware uses
suds and any of these tests should be there instead.
Co-Authored-By: Victor Stinner <vstinner@redhat.com>
Change-Id: I28f29d3e5745c21b99dc0cf9eb0cfe4f95dffd17
Commit cb3fdc56b5 moved the
oslo.vmware package. This does the same with the suds package.
The suds package is only imported in the vmwareapi virt driver
code (and tests) so it's purely optional if you're using the vmware
driver or not, so move it to test-requirements.txt.
Change-Id: I2d2b832c163bb6707ef20aa908e8df48118aaeb8
The oslo_vmware package is only imported in the vmwareapi virt driver
code (and tests) so it's purely optional if you're using the vmware
driver or not, so move it to test-requirements.txt.
Change-Id: I1fc07badfe3652681872c6e4d78c347158f21a5f
Adds a barbican keymgr wrapper to the key manager interface in
nova. This allows barbican to be configured as the key manager
for encryption keys in nova. The wrapper translates calls from
the existing key manager interface to python-barbicanclient.
Change-Id: I110c7ceada48de28cee1169b643b12407f21b36c
Implements: blueprint encryption-with-barbican
DocImpact
Commit 4b9bec3a1c removed the mocking of
nova.virt.libvirt.host.Host.get_connection to use fakelibvirt instead,
but if you don't have libvirt-python in your venv the tests fail, so
fakelibvirt in it's current form wasn't actually working for all tests.
This change updates the uri_whitelist in the init method of the
fakelibvirt Connection class to add some other URIs found in other parts
of the libvirt code (the LibvirtDriver.uri static method).
Removes the unnecessary 'xen:///system' whitelisted URI.
Since libvirt-python is no longer needed to run the libvirt driver
unit tests, it's removed from test-requirements.txt.
Closes-Bug: #1414708
Change-Id: Id7aefe9bf21dc3d0e2db42e668faf28e926aea43
This patch cleans up the requirement list to remove old modules that are
not used anymore directly by Nova.
Change-Id: Ifb0548aff985669ea0c4df470b8881edc3f2c26c
Release notes:
http://git.openstack.org/cgit/openstack-dev/hacking/tag/?id=0.10.0
* Remove references in tox.ini to removed rules
* Fix minor changes (H501)
* Clarify that H306 (imports in alphabetical order shouldn't be skipped)
* Ignore H238: check for old style class declarations
* Temporary skip W292, fix in next patch.
Change-Id: I6d990a564df6a312bd09b2a152315bbdba732082
The pylint tests have been broken for several months and
the Jenkins job has also been disabled. There has been
no sign of attempts to address this, so just delete what
remains of the pylint support so developers don't mistakenly
think it is supposed to work with patches they are submitting.
Change-Id: Ifacc99e45acb0e9a72be6c31113e0cf073354f02
This commit removes the local copy of subunit-trace in nova and uses
the packaged version of the utility in tempest-lib.
Change-Id: I1ed2fea9ff3d8194628b722684492f8ba7a3cabb
The fixtures in nova/openstack/common will be removed as
they have been removed from oslo-incubator. We should use
the fixtures from oslotest.
Note that oslotest uses mox3 instead of mox and some of the
tests were failing as a result which have been fixed in this
review. Only the failing tests have been fixed, so you will
see some tests use a mix of mock and mox3 as a result.
Based on feedback from Nova core, all existing references
to 'import mox' have been switched over to mox3 as well.
Change-Id: Ifa9dbb6f9bb1a358d815ae80cf928b65d5dcf5bd
Use the common session loading parameters and the session object for
talking to cinder.
There are some related changes in this patch.
Firstly auth_token middleware now provides an authentication plugin that
can be used along with the session object to make requests under the
user's authentication. This will largely replace the information
required on the context object.
This authentication plugin is not serializable though and so it cannot
be transferred over RPC so we introduce a simple authentication plugin
that reconstructs the required information from the context.
When talking to cinder we now create a global session object (think of
this like keeping open a connection pool object) and use the
authentication plugin to send requests to cinder.
I also condense the cinder tests as they are largely copied and pasted
between v1 and v2 and this solves fixing them in two places.
DocImpact: Renames cinder's timeout, insecure and CA certificates
parameters to the parameters used by the common session object. Adds
options for using client certificates with connection.
Change-Id: I7afe604503b8597c16be61d2a66a10b94269a219
Import the Ironic virt driver and supporting files (client lib wrapper
and state mapping), as well as relevant unit tests, as of commit
da967d77894be6f23d81fb5cc948f9d13898ba84
This is the dicing up of review/103167 into smaller chunks
ready for review.
Change-Id: If1f51c97212f687dd0d4d4044e9dbf7a90335e75
Co-authored-by: Adam Gandelman <adamg@ubuntu.com>
Co-authored-by: Andrey Kurilin <akurilin@mirantis.com>
Co-authored-by: ChangBo Guo(gcb) <eric.guo@easystack.cn>
Co-authored-by: Chris Behrens <cbehrens@codestud.com>
Co-authored-by: Chris Krelle <nobodycam@gmail.com>
Co-authored-by: David Shrewsbury <shrewsbury.dave@gmail.com>
Co-authored-by: Devananda van der Veen <devananda.vdv@gmail.com>
Co-authored-by: Dmitry Tantsur <dtantsur@redhat.com>
Co-authored-by: Jim Rollenhagen <jim@jimrollenhagen.com>
Co-authored-by: Lucas Alvares Gomes <lucasagomes@gmail.com>
Co-authored-by: Matthew Gilliard <matthew.gilliard@hp.com>
Co-authored-by: Mikhail Durnosvistov <mdurnosvistov@mirantis.com>
Co-authored-by: Pablo Fernando Cargnelutti <pablo.fernando.cargnelutti@intel.com>
Co-authored-by: Robert Collins <rbtcollins@hp.com>
Co-authored-by: ryo.kurahashi <kurahashi-rxa@necst.nec.co.jp>
OpenStack Proposal Bot