1826 lines
85 KiB
Python
1826 lines
85 KiB
Python
# Copyright 2014 IBM Corp.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
import os
|
|
|
|
import ddt
|
|
from eventlet import timeout as etimeout
|
|
import mock
|
|
from os_win import constants as os_win_const
|
|
from os_win import exceptions as os_win_exc
|
|
from oslo_concurrency import processutils
|
|
from oslo_config import cfg
|
|
from oslo_utils import fileutils
|
|
from oslo_utils import units
|
|
|
|
from nova.compute import vm_states
|
|
from nova import exception
|
|
from nova import objects
|
|
from nova.objects import fields
|
|
from nova.objects import flavor as flavor_obj
|
|
from nova.tests.unit import fake_instance
|
|
from nova.tests.unit.objects import test_flavor
|
|
from nova.tests.unit.objects import test_virtual_interface
|
|
from nova.tests.unit.virt.hyperv import test_base
|
|
from nova.virt import hardware
|
|
from nova.virt.hyperv import constants
|
|
from nova.virt.hyperv import vmops
|
|
from nova.virt.hyperv import volumeops
|
|
|
|
CONF = cfg.CONF
|
|
|
|
|
|
@ddt.ddt
|
|
class VMOpsTestCase(test_base.HyperVBaseTestCase):
|
|
"""Unit tests for the Hyper-V VMOps class."""
|
|
|
|
_FAKE_TIMEOUT = 2
|
|
FAKE_SIZE = 10
|
|
FAKE_DIR = 'fake_dir'
|
|
FAKE_ROOT_PATH = 'C:\\path\\to\\fake.%s'
|
|
FAKE_CONFIG_DRIVE_ISO = 'configdrive.iso'
|
|
FAKE_CONFIG_DRIVE_VHD = 'configdrive.vhd'
|
|
FAKE_UUID = '4f54fb69-d3a2-45b7-bb9b-b6e6b3d893b3'
|
|
FAKE_LOG = 'fake_log'
|
|
|
|
_WIN_VERSION_6_3 = '6.3.0'
|
|
_WIN_VERSION_10 = '10.0'
|
|
|
|
ISO9660 = 'iso9660'
|
|
_FAKE_CONFIGDRIVE_PATH = 'C:/fake_instance_dir/configdrive.vhd'
|
|
|
|
def setUp(self):
|
|
super(VMOpsTestCase, self).setUp()
|
|
self.context = 'fake-context'
|
|
|
|
self._vmops = vmops.VMOps(virtapi=mock.MagicMock())
|
|
self._vmops._vmutils = mock.MagicMock()
|
|
self._vmops._metricsutils = mock.MagicMock()
|
|
self._vmops._vhdutils = mock.MagicMock()
|
|
self._vmops._pathutils = mock.MagicMock()
|
|
self._vmops._hostutils = mock.MagicMock()
|
|
self._vmops._serial_console_ops = mock.MagicMock()
|
|
self._vmops._block_dev_man = mock.MagicMock()
|
|
self._vmops._vif_driver = mock.MagicMock()
|
|
|
|
def test_list_instances(self):
|
|
mock_instance = mock.MagicMock()
|
|
self._vmops._vmutils.list_instances.return_value = [mock_instance]
|
|
response = self._vmops.list_instances()
|
|
self._vmops._vmutils.list_instances.assert_called_once_with()
|
|
self.assertEqual(response, [mock_instance])
|
|
|
|
def test_estimate_instance_overhead(self):
|
|
instance_info = {'memory_mb': 512}
|
|
overhead = self._vmops.estimate_instance_overhead(instance_info)
|
|
self.assertEqual(0, overhead['memory_mb'])
|
|
self.assertEqual(1, overhead['disk_gb'])
|
|
|
|
instance_info = {'memory_mb': 500}
|
|
overhead = self._vmops.estimate_instance_overhead(instance_info)
|
|
self.assertEqual(0, overhead['disk_gb'])
|
|
|
|
def _test_get_info(self, vm_exists):
|
|
mock_instance = fake_instance.fake_instance_obj(self.context)
|
|
mock_info = mock.MagicMock(spec_set=dict)
|
|
fake_info = {'EnabledState': 2,
|
|
'MemoryUsage': mock.sentinel.FAKE_MEM_KB,
|
|
'NumberOfProcessors': mock.sentinel.FAKE_NUM_CPU,
|
|
'UpTime': mock.sentinel.FAKE_CPU_NS}
|
|
|
|
def getitem(key):
|
|
return fake_info[key]
|
|
mock_info.__getitem__.side_effect = getitem
|
|
|
|
expected = hardware.InstanceInfo(state=constants.HYPERV_POWER_STATE[2])
|
|
|
|
self._vmops._vmutils.vm_exists.return_value = vm_exists
|
|
self._vmops._vmutils.get_vm_summary_info.return_value = mock_info
|
|
|
|
if not vm_exists:
|
|
self.assertRaises(exception.InstanceNotFound,
|
|
self._vmops.get_info, mock_instance)
|
|
else:
|
|
response = self._vmops.get_info(mock_instance)
|
|
self._vmops._vmutils.vm_exists.assert_called_once_with(
|
|
mock_instance.name)
|
|
self._vmops._vmutils.get_vm_summary_info.assert_called_once_with(
|
|
mock_instance.name)
|
|
self.assertEqual(response, expected)
|
|
|
|
def test_get_info(self):
|
|
self._test_get_info(vm_exists=True)
|
|
|
|
def test_get_info_exception(self):
|
|
self._test_get_info(vm_exists=False)
|
|
|
|
@mock.patch.object(vmops.VMOps, 'check_vm_image_type')
|
|
@mock.patch.object(vmops.VMOps, '_create_root_vhd')
|
|
def test_create_root_device_type_disk(self, mock_create_root_device,
|
|
mock_check_vm_image_type):
|
|
mock_instance = fake_instance.fake_instance_obj(self.context)
|
|
mock_root_disk_info = {'type': constants.DISK}
|
|
|
|
self._vmops._create_root_device(self.context, mock_instance,
|
|
mock_root_disk_info,
|
|
mock.sentinel.VM_GEN_1)
|
|
|
|
mock_create_root_device.assert_called_once_with(
|
|
self.context, mock_instance)
|
|
mock_check_vm_image_type.assert_called_once_with(
|
|
mock_instance.uuid, mock.sentinel.VM_GEN_1,
|
|
mock_create_root_device.return_value)
|
|
|
|
def _prepare_create_root_device_mocks(self, use_cow_images, vhd_format,
|
|
vhd_size):
|
|
mock_instance = fake_instance.fake_instance_obj(self.context)
|
|
mock_instance.flavor.root_gb = self.FAKE_SIZE
|
|
self.flags(use_cow_images=use_cow_images)
|
|
self._vmops._vhdutils.get_vhd_info.return_value = {'VirtualSize':
|
|
vhd_size * units.Gi}
|
|
self._vmops._vhdutils.get_vhd_format.return_value = vhd_format
|
|
root_vhd_internal_size = mock_instance.flavor.root_gb * units.Gi
|
|
get_size = self._vmops._vhdutils.get_internal_vhd_size_by_file_size
|
|
get_size.return_value = root_vhd_internal_size
|
|
self._vmops._pathutils.exists.return_value = True
|
|
|
|
return mock_instance
|
|
|
|
@mock.patch('nova.virt.hyperv.imagecache.ImageCache.get_cached_image')
|
|
def _test_create_root_vhd_exception(self, mock_get_cached_image,
|
|
vhd_format):
|
|
mock_instance = self._prepare_create_root_device_mocks(
|
|
use_cow_images=False, vhd_format=vhd_format,
|
|
vhd_size=(self.FAKE_SIZE + 1))
|
|
fake_vhd_path = self.FAKE_ROOT_PATH % vhd_format
|
|
mock_get_cached_image.return_value = fake_vhd_path
|
|
fake_root_path = self._vmops._pathutils.get_root_vhd_path.return_value
|
|
|
|
self.assertRaises(exception.FlavorDiskSmallerThanImage,
|
|
self._vmops._create_root_vhd, self.context,
|
|
mock_instance)
|
|
|
|
self.assertFalse(self._vmops._vhdutils.resize_vhd.called)
|
|
self._vmops._pathutils.exists.assert_called_once_with(
|
|
fake_root_path)
|
|
self._vmops._pathutils.remove.assert_called_once_with(
|
|
fake_root_path)
|
|
|
|
@mock.patch('nova.virt.hyperv.imagecache.ImageCache.get_cached_image')
|
|
def _test_create_root_vhd_qcow(self, mock_get_cached_image, vhd_format):
|
|
mock_instance = self._prepare_create_root_device_mocks(
|
|
use_cow_images=True, vhd_format=vhd_format,
|
|
vhd_size=(self.FAKE_SIZE - 1))
|
|
fake_vhd_path = self.FAKE_ROOT_PATH % vhd_format
|
|
mock_get_cached_image.return_value = fake_vhd_path
|
|
|
|
fake_root_path = self._vmops._pathutils.get_root_vhd_path.return_value
|
|
root_vhd_internal_size = mock_instance.flavor.root_gb * units.Gi
|
|
get_size = self._vmops._vhdutils.get_internal_vhd_size_by_file_size
|
|
|
|
response = self._vmops._create_root_vhd(context=self.context,
|
|
instance=mock_instance)
|
|
|
|
self.assertEqual(fake_root_path, response)
|
|
self._vmops._pathutils.get_root_vhd_path.assert_called_with(
|
|
mock_instance.name, vhd_format, False)
|
|
differencing_vhd = self._vmops._vhdutils.create_differencing_vhd
|
|
differencing_vhd.assert_called_with(fake_root_path, fake_vhd_path)
|
|
self._vmops._vhdutils.get_vhd_info.assert_called_once_with(
|
|
fake_vhd_path)
|
|
|
|
if vhd_format is constants.DISK_FORMAT_VHD:
|
|
self.assertFalse(get_size.called)
|
|
self.assertFalse(self._vmops._vhdutils.resize_vhd.called)
|
|
else:
|
|
get_size.assert_called_once_with(fake_vhd_path,
|
|
root_vhd_internal_size)
|
|
self._vmops._vhdutils.resize_vhd.assert_called_once_with(
|
|
fake_root_path, root_vhd_internal_size, is_file_max_size=False)
|
|
|
|
@mock.patch('nova.virt.hyperv.imagecache.ImageCache.get_cached_image')
|
|
def _test_create_root_vhd(self, mock_get_cached_image, vhd_format,
|
|
is_rescue_vhd=False):
|
|
mock_instance = self._prepare_create_root_device_mocks(
|
|
use_cow_images=False, vhd_format=vhd_format,
|
|
vhd_size=(self.FAKE_SIZE - 1))
|
|
fake_vhd_path = self.FAKE_ROOT_PATH % vhd_format
|
|
mock_get_cached_image.return_value = fake_vhd_path
|
|
rescue_image_id = (
|
|
mock.sentinel.rescue_image_id if is_rescue_vhd else None)
|
|
|
|
fake_root_path = self._vmops._pathutils.get_root_vhd_path.return_value
|
|
root_vhd_internal_size = mock_instance.flavor.root_gb * units.Gi
|
|
get_size = self._vmops._vhdutils.get_internal_vhd_size_by_file_size
|
|
|
|
response = self._vmops._create_root_vhd(
|
|
context=self.context,
|
|
instance=mock_instance,
|
|
rescue_image_id=rescue_image_id)
|
|
|
|
self.assertEqual(fake_root_path, response)
|
|
mock_get_cached_image.assert_called_once_with(self.context,
|
|
mock_instance,
|
|
rescue_image_id)
|
|
self._vmops._pathutils.get_root_vhd_path.assert_called_with(
|
|
mock_instance.name, vhd_format, is_rescue_vhd)
|
|
|
|
self._vmops._pathutils.copyfile.assert_called_once_with(
|
|
fake_vhd_path, fake_root_path)
|
|
get_size.assert_called_once_with(fake_vhd_path, root_vhd_internal_size)
|
|
if is_rescue_vhd:
|
|
self.assertFalse(self._vmops._vhdutils.resize_vhd.called)
|
|
else:
|
|
self._vmops._vhdutils.resize_vhd.assert_called_once_with(
|
|
fake_root_path, root_vhd_internal_size,
|
|
is_file_max_size=False)
|
|
|
|
def test_create_root_vhd(self):
|
|
self._test_create_root_vhd(vhd_format=constants.DISK_FORMAT_VHD)
|
|
|
|
def test_create_root_vhdx(self):
|
|
self._test_create_root_vhd(vhd_format=constants.DISK_FORMAT_VHDX)
|
|
|
|
def test_create_root_vhd_use_cow_images_true(self):
|
|
self._test_create_root_vhd_qcow(vhd_format=constants.DISK_FORMAT_VHD)
|
|
|
|
def test_create_root_vhdx_use_cow_images_true(self):
|
|
self._test_create_root_vhd_qcow(vhd_format=constants.DISK_FORMAT_VHDX)
|
|
|
|
def test_create_rescue_vhd(self):
|
|
self._test_create_root_vhd(vhd_format=constants.DISK_FORMAT_VHD,
|
|
is_rescue_vhd=True)
|
|
|
|
def test_create_root_vhdx_size_less_than_internal(self):
|
|
self._test_create_root_vhd_exception(
|
|
vhd_format=constants.DISK_FORMAT_VHD)
|
|
|
|
def test_is_resize_needed_exception(self):
|
|
inst = mock.MagicMock()
|
|
self.assertRaises(
|
|
exception.FlavorDiskSmallerThanImage,
|
|
self._vmops._is_resize_needed,
|
|
mock.sentinel.FAKE_PATH, self.FAKE_SIZE, self.FAKE_SIZE - 1, inst)
|
|
|
|
def test_is_resize_needed_true(self):
|
|
inst = mock.MagicMock()
|
|
self.assertTrue(self._vmops._is_resize_needed(
|
|
mock.sentinel.FAKE_PATH, self.FAKE_SIZE, self.FAKE_SIZE + 1, inst))
|
|
|
|
def test_is_resize_needed_false(self):
|
|
inst = mock.MagicMock()
|
|
self.assertFalse(self._vmops._is_resize_needed(
|
|
mock.sentinel.FAKE_PATH, self.FAKE_SIZE, self.FAKE_SIZE, inst))
|
|
|
|
@mock.patch.object(vmops.VMOps, 'create_ephemeral_disk')
|
|
def test_create_ephemerals(self, mock_create_ephemeral_disk):
|
|
mock_instance = fake_instance.fake_instance_obj(self.context)
|
|
|
|
fake_ephemerals = [dict(), dict()]
|
|
self._vmops._vhdutils.get_best_supported_vhd_format.return_value = (
|
|
mock.sentinel.format)
|
|
self._vmops._pathutils.get_ephemeral_vhd_path.side_effect = [
|
|
mock.sentinel.FAKE_PATH0, mock.sentinel.FAKE_PATH1]
|
|
|
|
self._vmops._create_ephemerals(mock_instance, fake_ephemerals)
|
|
|
|
self._vmops._pathutils.get_ephemeral_vhd_path.assert_has_calls(
|
|
[mock.call(mock_instance.name, mock.sentinel.format, 'eph0'),
|
|
mock.call(mock_instance.name, mock.sentinel.format, 'eph1')])
|
|
mock_create_ephemeral_disk.assert_has_calls(
|
|
[mock.call(mock_instance.name, fake_ephemerals[0]),
|
|
mock.call(mock_instance.name, fake_ephemerals[1])])
|
|
|
|
def test_create_ephemeral_disk(self):
|
|
mock_instance = fake_instance.fake_instance_obj(self.context)
|
|
mock_ephemeral_info = {'path': 'fake_eph_path',
|
|
'size': 10}
|
|
|
|
self._vmops.create_ephemeral_disk(mock_instance.name,
|
|
mock_ephemeral_info)
|
|
|
|
mock_create_dynamic_vhd = self._vmops._vhdutils.create_dynamic_vhd
|
|
mock_create_dynamic_vhd.assert_called_once_with('fake_eph_path',
|
|
10 * units.Gi)
|
|
|
|
@mock.patch.object(vmops.objects, 'PCIDeviceBus')
|
|
@mock.patch.object(vmops.objects, 'NetworkInterfaceMetadata')
|
|
@mock.patch.object(vmops.objects.VirtualInterfaceList,
|
|
'get_by_instance_uuid')
|
|
def test_get_vif_metadata(self, mock_get_by_inst_uuid,
|
|
mock_NetworkInterfaceMetadata, mock_PCIDevBus):
|
|
mock_vif = mock.MagicMock(tag='taggy')
|
|
mock_vif.__contains__.side_effect = (
|
|
lambda attr: getattr(mock_vif, attr, None) is not None)
|
|
mock_get_by_inst_uuid.return_value = [mock_vif,
|
|
mock.MagicMock(tag=None)]
|
|
|
|
vif_metadata = self._vmops._get_vif_metadata(self.context,
|
|
mock.sentinel.instance_id)
|
|
|
|
mock_get_by_inst_uuid.assert_called_once_with(
|
|
self.context, mock.sentinel.instance_id)
|
|
mock_NetworkInterfaceMetadata.assert_called_once_with(
|
|
mac=mock_vif.address,
|
|
bus=mock_PCIDevBus.return_value,
|
|
tags=[mock_vif.tag])
|
|
self.assertEqual([mock_NetworkInterfaceMetadata.return_value],
|
|
vif_metadata)
|
|
|
|
@mock.patch.object(vmops.objects, 'InstanceDeviceMetadata')
|
|
@mock.patch.object(vmops.VMOps, '_get_vif_metadata')
|
|
def test_save_device_metadata(self, mock_get_vif_metadata,
|
|
mock_InstanceDeviceMetadata):
|
|
mock_instance = mock.MagicMock()
|
|
mock_get_vif_metadata.return_value = [mock.sentinel.vif_metadata]
|
|
self._vmops._block_dev_man.get_bdm_metadata.return_value = [
|
|
mock.sentinel.bdm_metadata]
|
|
|
|
self._vmops._save_device_metadata(self.context, mock_instance,
|
|
mock.sentinel.block_device_info)
|
|
|
|
mock_get_vif_metadata.assert_called_once_with(self.context,
|
|
mock_instance.uuid)
|
|
self._vmops._block_dev_man.get_bdm_metadata.assert_called_once_with(
|
|
self.context, mock_instance, mock.sentinel.block_device_info)
|
|
|
|
expected_metadata = [mock.sentinel.vif_metadata,
|
|
mock.sentinel.bdm_metadata]
|
|
mock_InstanceDeviceMetadata.assert_called_once_with(
|
|
devices=expected_metadata)
|
|
self.assertEqual(mock_InstanceDeviceMetadata.return_value,
|
|
mock_instance.device_metadata)
|
|
|
|
def test_set_boot_order(self):
|
|
self._vmops.set_boot_order(mock.sentinel.instance_name,
|
|
mock.sentinel.vm_gen,
|
|
mock.sentinel.bdi)
|
|
|
|
mock_get_boot_order = self._vmops._block_dev_man.get_boot_order
|
|
mock_get_boot_order.assert_called_once_with(
|
|
mock.sentinel.vm_gen, mock.sentinel.bdi)
|
|
self._vmops._vmutils.set_boot_order.assert_called_once_with(
|
|
mock.sentinel.instance_name, mock_get_boot_order.return_value)
|
|
|
|
@mock.patch('nova.virt.hyperv.vmops.VMOps.destroy')
|
|
@mock.patch('nova.virt.hyperv.vmops.VMOps.power_on')
|
|
@mock.patch('nova.virt.hyperv.vmops.VMOps.set_boot_order')
|
|
@mock.patch('nova.virt.hyperv.vmops.VMOps.attach_config_drive')
|
|
@mock.patch('nova.virt.hyperv.vmops.VMOps._create_config_drive')
|
|
@mock.patch('nova.virt.configdrive.required_by')
|
|
@mock.patch('nova.virt.hyperv.vmops.VMOps._save_device_metadata')
|
|
@mock.patch('nova.virt.hyperv.vmops.VMOps.create_instance')
|
|
@mock.patch('nova.virt.hyperv.vmops.VMOps.get_image_vm_generation')
|
|
@mock.patch('nova.virt.hyperv.vmops.VMOps._create_ephemerals')
|
|
@mock.patch('nova.virt.hyperv.vmops.VMOps._create_root_device')
|
|
@mock.patch('nova.virt.hyperv.vmops.VMOps._delete_disk_files')
|
|
@mock.patch('nova.virt.hyperv.vmops.VMOps._get_neutron_events',
|
|
return_value=[])
|
|
def _test_spawn(self, mock_get_neutron_events,
|
|
mock_delete_disk_files, mock_create_root_device,
|
|
mock_create_ephemerals, mock_get_image_vm_gen,
|
|
mock_create_instance, mock_save_device_metadata,
|
|
mock_configdrive_required,
|
|
mock_create_config_drive, mock_attach_config_drive,
|
|
mock_set_boot_order,
|
|
mock_power_on, mock_destroy, exists,
|
|
configdrive_required, fail,
|
|
fake_vm_gen=constants.VM_GEN_2):
|
|
mock_instance = fake_instance.fake_instance_obj(self.context)
|
|
mock_image_meta = mock.MagicMock()
|
|
root_device_info = mock.sentinel.ROOT_DEV_INFO
|
|
mock_get_image_vm_gen.return_value = fake_vm_gen
|
|
fake_config_drive_path = mock_create_config_drive.return_value
|
|
block_device_info = {'ephemerals': [], 'root_disk': root_device_info}
|
|
|
|
self._vmops._vmutils.vm_exists.return_value = exists
|
|
mock_configdrive_required.return_value = configdrive_required
|
|
mock_create_instance.side_effect = fail
|
|
if exists:
|
|
self.assertRaises(exception.InstanceExists, self._vmops.spawn,
|
|
self.context, mock_instance, mock_image_meta,
|
|
[mock.sentinel.FILE], mock.sentinel.PASSWORD,
|
|
mock.sentinel.network_info, block_device_info)
|
|
elif fail is os_win_exc.HyperVException:
|
|
self.assertRaises(os_win_exc.HyperVException, self._vmops.spawn,
|
|
self.context, mock_instance, mock_image_meta,
|
|
[mock.sentinel.FILE], mock.sentinel.PASSWORD,
|
|
mock.sentinel.network_info, block_device_info)
|
|
mock_destroy.assert_called_once_with(mock_instance,
|
|
mock.sentinel.network_info,
|
|
block_device_info)
|
|
else:
|
|
self._vmops.spawn(self.context, mock_instance, mock_image_meta,
|
|
[mock.sentinel.FILE], mock.sentinel.PASSWORD,
|
|
mock.sentinel.network_info, block_device_info)
|
|
self._vmops._vmutils.vm_exists.assert_called_once_with(
|
|
mock_instance.name)
|
|
mock_delete_disk_files.assert_called_once_with(
|
|
mock_instance.name)
|
|
mock_validate_and_update_bdi = (
|
|
self._vmops._block_dev_man.validate_and_update_bdi)
|
|
mock_validate_and_update_bdi.assert_called_once_with(
|
|
mock_instance, mock_image_meta, fake_vm_gen, block_device_info)
|
|
mock_create_root_device.assert_called_once_with(self.context,
|
|
mock_instance,
|
|
root_device_info,
|
|
fake_vm_gen)
|
|
mock_create_ephemerals.assert_called_once_with(
|
|
mock_instance, block_device_info['ephemerals'])
|
|
mock_get_neutron_events.assert_called_once_with(
|
|
mock.sentinel.network_info)
|
|
mock_get_image_vm_gen.assert_called_once_with(mock_instance.uuid,
|
|
mock_image_meta)
|
|
mock_create_instance.assert_called_once_with(
|
|
mock_instance, mock.sentinel.network_info, root_device_info,
|
|
block_device_info, fake_vm_gen, mock_image_meta)
|
|
mock_save_device_metadata.assert_called_once_with(
|
|
self.context, mock_instance, block_device_info)
|
|
mock_configdrive_required.assert_called_once_with(mock_instance)
|
|
if configdrive_required:
|
|
mock_create_config_drive.assert_called_once_with(
|
|
self.context, mock_instance, [mock.sentinel.FILE],
|
|
mock.sentinel.PASSWORD,
|
|
mock.sentinel.network_info)
|
|
mock_attach_config_drive.assert_called_once_with(
|
|
mock_instance, fake_config_drive_path, fake_vm_gen)
|
|
mock_set_boot_order.assert_called_once_with(
|
|
mock_instance.name, fake_vm_gen, block_device_info)
|
|
mock_power_on.assert_called_once_with(
|
|
mock_instance, network_info=mock.sentinel.network_info)
|
|
|
|
def test_spawn(self):
|
|
self._test_spawn(exists=False, configdrive_required=True, fail=None)
|
|
|
|
def test_spawn_instance_exists(self):
|
|
self._test_spawn(exists=True, configdrive_required=True, fail=None)
|
|
|
|
def test_spawn_create_instance_exception(self):
|
|
self._test_spawn(exists=False, configdrive_required=True,
|
|
fail=os_win_exc.HyperVException)
|
|
|
|
def test_spawn_not_required(self):
|
|
self._test_spawn(exists=False, configdrive_required=False, fail=None)
|
|
|
|
def test_spawn_no_admin_permissions(self):
|
|
self._vmops._vmutils.check_admin_permissions.side_effect = (
|
|
os_win_exc.HyperVException)
|
|
self.assertRaises(os_win_exc.HyperVException,
|
|
self._vmops.spawn,
|
|
self.context, mock.DEFAULT, mock.DEFAULT,
|
|
[mock.sentinel.FILE], mock.sentinel.PASSWORD,
|
|
mock.sentinel.INFO, mock.sentinel.DEV_INFO)
|
|
|
|
@mock.patch.object(vmops.VMOps, '_get_neutron_events')
|
|
def test_wait_vif_plug_events(self, mock_get_events):
|
|
self._vmops._virtapi.wait_for_instance_event.side_effect = (
|
|
etimeout.Timeout)
|
|
self.flags(vif_plugging_timeout=1)
|
|
self.flags(vif_plugging_is_fatal=True)
|
|
|
|
def _context_user():
|
|
with self._vmops.wait_vif_plug_events(mock.sentinel.instance,
|
|
mock.sentinel.network_info):
|
|
pass
|
|
|
|
self.assertRaises(exception.VirtualInterfaceCreateException,
|
|
_context_user)
|
|
|
|
mock_get_events.assert_called_once_with(mock.sentinel.network_info)
|
|
self._vmops._virtapi.wait_for_instance_event.assert_called_once_with(
|
|
mock.sentinel.instance, mock_get_events.return_value,
|
|
deadline=CONF.vif_plugging_timeout,
|
|
error_callback=self._vmops._neutron_failed_callback)
|
|
|
|
@mock.patch.object(vmops.VMOps, '_get_neutron_events')
|
|
def test_wait_vif_plug_events_port_binding_failed(self, mock_get_events):
|
|
mock_get_events.side_effect = exception.PortBindingFailed(
|
|
port_id='fake_id')
|
|
|
|
def _context_user():
|
|
with self._vmops.wait_vif_plug_events(mock.sentinel.instance,
|
|
mock.sentinel.network_info):
|
|
pass
|
|
|
|
self.assertRaises(exception.PortBindingFailed, _context_user)
|
|
|
|
def test_neutron_failed_callback(self):
|
|
self.flags(vif_plugging_is_fatal=True)
|
|
self.assertRaises(exception.VirtualInterfaceCreateException,
|
|
self._vmops._neutron_failed_callback,
|
|
mock.sentinel.event_name, mock.sentinel.instance)
|
|
|
|
@mock.patch.object(vmops.utils, 'is_neutron')
|
|
def test_get_neutron_events(self, mock_is_neutron):
|
|
network_info = [{'id': mock.sentinel.vif_id1, 'active': True},
|
|
{'id': mock.sentinel.vif_id2, 'active': False},
|
|
{'id': mock.sentinel.vif_id3}]
|
|
|
|
events = self._vmops._get_neutron_events(network_info)
|
|
self.assertEqual([('network-vif-plugged', mock.sentinel.vif_id2)],
|
|
events)
|
|
mock_is_neutron.assert_called_once_with()
|
|
|
|
@mock.patch.object(vmops.utils, 'is_neutron')
|
|
def test_get_neutron_events_no_timeout(self, mock_is_neutron):
|
|
self.flags(vif_plugging_timeout=0)
|
|
network_info = [{'id': mock.sentinel.vif_id1, 'active': True}]
|
|
|
|
events = self._vmops._get_neutron_events(network_info)
|
|
self.assertEqual([], events)
|
|
mock_is_neutron.assert_called_once_with()
|
|
|
|
@mock.patch.object(vmops.VMOps, '_attach_pci_devices')
|
|
@mock.patch.object(vmops.VMOps, '_requires_secure_boot')
|
|
@mock.patch.object(vmops.VMOps, '_requires_certificate')
|
|
@mock.patch.object(vmops.VMOps, '_get_instance_vnuma_config')
|
|
@mock.patch('nova.virt.hyperv.volumeops.VolumeOps'
|
|
'.attach_volumes')
|
|
@mock.patch.object(vmops.VMOps, '_set_instance_disk_qos_specs')
|
|
@mock.patch.object(vmops.VMOps, '_create_vm_com_port_pipes')
|
|
@mock.patch.object(vmops.VMOps, '_attach_ephemerals')
|
|
@mock.patch.object(vmops.VMOps, '_attach_root_device')
|
|
@mock.patch.object(vmops.VMOps, '_configure_remotefx')
|
|
def _test_create_instance(self, mock_configure_remotefx,
|
|
mock_attach_root_device,
|
|
mock_attach_ephemerals,
|
|
mock_create_pipes,
|
|
mock_set_qos_specs,
|
|
mock_attach_volumes,
|
|
mock_get_vnuma_config,
|
|
mock_requires_certificate,
|
|
mock_requires_secure_boot,
|
|
mock_attach_pci_devices,
|
|
enable_instance_metrics,
|
|
vm_gen=constants.VM_GEN_1,
|
|
vnuma_enabled=False,
|
|
pci_requests=None):
|
|
self.flags(dynamic_memory_ratio=2.0, group='hyperv')
|
|
self.flags(enable_instance_metrics_collection=enable_instance_metrics,
|
|
group='hyperv')
|
|
root_device_info = mock.sentinel.ROOT_DEV_INFO
|
|
block_device_info = {'ephemerals': [], 'block_device_mapping': []}
|
|
fake_network_info = {'id': mock.sentinel.ID,
|
|
'address': mock.sentinel.ADDRESS}
|
|
mock_instance = fake_instance.fake_instance_obj(self.context)
|
|
instance_path = os.path.join(CONF.instances_path, mock_instance.name)
|
|
mock_requires_secure_boot.return_value = True
|
|
|
|
flavor = flavor_obj.Flavor(**test_flavor.fake_flavor)
|
|
mock_instance.flavor = flavor
|
|
instance_pci_requests = objects.InstancePCIRequests(
|
|
requests=pci_requests or [], instance_uuid=mock_instance.uuid)
|
|
mock_instance.pci_requests = instance_pci_requests
|
|
host_shutdown_action = (os_win_const.HOST_SHUTDOWN_ACTION_SHUTDOWN
|
|
if pci_requests else None)
|
|
|
|
if vnuma_enabled:
|
|
mock_get_vnuma_config.return_value = (
|
|
mock.sentinel.mem_per_numa, mock.sentinel.cpus_per_numa)
|
|
cpus_per_numa = mock.sentinel.cpus_per_numa
|
|
mem_per_numa = mock.sentinel.mem_per_numa
|
|
dynamic_memory_ratio = 1.0
|
|
else:
|
|
mock_get_vnuma_config.return_value = (None, None)
|
|
mem_per_numa, cpus_per_numa = (None, None)
|
|
dynamic_memory_ratio = CONF.hyperv.dynamic_memory_ratio
|
|
|
|
self._vmops.create_instance(instance=mock_instance,
|
|
network_info=[fake_network_info],
|
|
root_device=root_device_info,
|
|
block_device_info=block_device_info,
|
|
vm_gen=vm_gen,
|
|
image_meta=mock.sentinel.image_meta)
|
|
|
|
mock_get_vnuma_config.assert_called_once_with(mock_instance,
|
|
mock.sentinel.image_meta)
|
|
self._vmops._vmutils.create_vm.assert_called_once_with(
|
|
mock_instance.name, vnuma_enabled, vm_gen,
|
|
instance_path, [mock_instance.uuid])
|
|
self._vmops._vmutils.update_vm.assert_called_once_with(
|
|
mock_instance.name, mock_instance.flavor.memory_mb, mem_per_numa,
|
|
mock_instance.flavor.vcpus, cpus_per_numa,
|
|
CONF.hyperv.limit_cpu_features, dynamic_memory_ratio,
|
|
host_shutdown_action=host_shutdown_action)
|
|
|
|
mock_configure_remotefx.assert_called_once_with(mock_instance, vm_gen)
|
|
mock_create_scsi_ctrl = self._vmops._vmutils.create_scsi_controller
|
|
mock_create_scsi_ctrl.assert_called_once_with(mock_instance.name)
|
|
|
|
mock_attach_root_device.assert_called_once_with(mock_instance.name,
|
|
root_device_info)
|
|
mock_attach_ephemerals.assert_called_once_with(mock_instance.name,
|
|
block_device_info['ephemerals'])
|
|
mock_attach_volumes.assert_called_once_with(
|
|
block_device_info['block_device_mapping'], mock_instance.name)
|
|
|
|
self._vmops._vmutils.create_nic.assert_called_once_with(
|
|
mock_instance.name, mock.sentinel.ID, mock.sentinel.ADDRESS)
|
|
mock_enable = self._vmops._metricsutils.enable_vm_metrics_collection
|
|
if enable_instance_metrics:
|
|
mock_enable.assert_called_once_with(mock_instance.name)
|
|
mock_set_qos_specs.assert_called_once_with(mock_instance)
|
|
mock_requires_secure_boot.assert_called_once_with(
|
|
mock_instance, mock.sentinel.image_meta, vm_gen)
|
|
mock_requires_certificate.assert_called_once_with(
|
|
mock.sentinel.image_meta)
|
|
enable_secure_boot = self._vmops._vmutils.enable_secure_boot
|
|
enable_secure_boot.assert_called_once_with(
|
|
mock_instance.name,
|
|
msft_ca_required=mock_requires_certificate.return_value)
|
|
mock_attach_pci_devices.assert_called_once_with(mock_instance)
|
|
|
|
def test_create_instance(self):
|
|
self._test_create_instance(enable_instance_metrics=True)
|
|
|
|
def test_create_instance_enable_instance_metrics_false(self):
|
|
self._test_create_instance(enable_instance_metrics=False)
|
|
|
|
def test_create_instance_gen2(self):
|
|
self._test_create_instance(enable_instance_metrics=False,
|
|
vm_gen=constants.VM_GEN_2)
|
|
|
|
def test_create_instance_vnuma_enabled(self):
|
|
self._test_create_instance(enable_instance_metrics=False,
|
|
vnuma_enabled=True)
|
|
|
|
def test_create_instance_pci_requested(self):
|
|
vendor_id = 'fake_vendor_id'
|
|
product_id = 'fake_product_id'
|
|
spec = {'vendor_id': vendor_id, 'product_id': product_id}
|
|
request = objects.InstancePCIRequest(count=1, spec=[spec])
|
|
self._test_create_instance(enable_instance_metrics=False,
|
|
pci_requests=[request])
|
|
|
|
def test_attach_pci_devices(self):
|
|
mock_instance = fake_instance.fake_instance_obj(self.context)
|
|
vendor_id = 'fake_vendor_id'
|
|
product_id = 'fake_product_id'
|
|
spec = {'vendor_id': vendor_id, 'product_id': product_id}
|
|
request = objects.InstancePCIRequest(count=2, spec=[spec])
|
|
instance_pci_requests = objects.InstancePCIRequests(
|
|
requests=[request], instance_uuid=mock_instance.uuid)
|
|
mock_instance.pci_requests = instance_pci_requests
|
|
|
|
self._vmops._attach_pci_devices(mock_instance)
|
|
|
|
self._vmops._vmutils.add_pci_device.assert_has_calls(
|
|
[mock.call(mock_instance.name, vendor_id, product_id)] * 2)
|
|
|
|
@mock.patch.object(vmops.hardware, 'numa_get_constraints')
|
|
def _check_get_instance_vnuma_config_exception(self, mock_get_numa,
|
|
numa_cells):
|
|
flavor = {'extra_specs': {}}
|
|
mock_instance = mock.MagicMock(flavor=flavor)
|
|
image_meta = mock.MagicMock(properties={})
|
|
numa_topology = objects.InstanceNUMATopology(cells=numa_cells)
|
|
mock_get_numa.return_value = numa_topology
|
|
|
|
self.assertRaises(exception.InstanceUnacceptable,
|
|
self._vmops._get_instance_vnuma_config,
|
|
mock_instance, image_meta)
|
|
|
|
def test_get_instance_vnuma_config_bad_cpuset(self):
|
|
cell1 = objects.InstanceNUMACell(cpuset=set([0]), memory=1024)
|
|
cell2 = objects.InstanceNUMACell(cpuset=set([1, 2]), memory=1024)
|
|
self._check_get_instance_vnuma_config_exception(
|
|
numa_cells=[cell1, cell2])
|
|
|
|
def test_get_instance_vnuma_config_bad_memory(self):
|
|
cell1 = objects.InstanceNUMACell(cpuset=set([0]), memory=1024)
|
|
cell2 = objects.InstanceNUMACell(cpuset=set([1]), memory=2048)
|
|
self._check_get_instance_vnuma_config_exception(
|
|
numa_cells=[cell1, cell2])
|
|
|
|
def test_get_instance_vnuma_config_cpu_pinning(self):
|
|
cell1 = objects.InstanceNUMACell(
|
|
cpuset=set([0]), memory=1024,
|
|
cpu_policy=fields.CPUAllocationPolicy.DEDICATED)
|
|
cell2 = objects.InstanceNUMACell(
|
|
cpuset=set([1]), memory=1024,
|
|
cpu_policy=fields.CPUAllocationPolicy.DEDICATED)
|
|
self._check_get_instance_vnuma_config_exception(
|
|
numa_cells=[cell1, cell2])
|
|
|
|
@mock.patch.object(vmops.hardware, 'numa_get_constraints')
|
|
def _check_get_instance_vnuma_config(
|
|
self, mock_get_numa, numa_topology=None,
|
|
expected_mem_per_numa=None, expected_cpus_per_numa=None):
|
|
mock_instance = mock.MagicMock()
|
|
image_meta = mock.MagicMock()
|
|
mock_get_numa.return_value = numa_topology
|
|
|
|
result_memory_per_numa, result_cpus_per_numa = (
|
|
self._vmops._get_instance_vnuma_config(mock_instance, image_meta))
|
|
|
|
self.assertEqual(expected_cpus_per_numa, result_cpus_per_numa)
|
|
self.assertEqual(expected_mem_per_numa, result_memory_per_numa)
|
|
|
|
def test_get_instance_vnuma_config(self):
|
|
cell1 = objects.InstanceNUMACell(cpuset=set([0]), memory=2048)
|
|
cell2 = objects.InstanceNUMACell(cpuset=set([1]), memory=2048)
|
|
numa_topology = objects.InstanceNUMATopology(cells=[cell1, cell2])
|
|
self._check_get_instance_vnuma_config(numa_topology=numa_topology,
|
|
expected_cpus_per_numa=1,
|
|
expected_mem_per_numa=2048)
|
|
|
|
def test_get_instance_vnuma_config_no_topology(self):
|
|
self._check_get_instance_vnuma_config()
|
|
|
|
@mock.patch.object(vmops.volumeops.VolumeOps, 'attach_volume')
|
|
def test_attach_root_device_volume(self, mock_attach_volume):
|
|
mock_instance = fake_instance.fake_instance_obj(self.context)
|
|
root_device_info = {'type': constants.VOLUME,
|
|
'connection_info': mock.sentinel.CONN_INFO,
|
|
'disk_bus': constants.CTRL_TYPE_IDE}
|
|
|
|
self._vmops._attach_root_device(mock_instance.name, root_device_info)
|
|
|
|
mock_attach_volume.assert_called_once_with(
|
|
root_device_info['connection_info'], mock_instance.name,
|
|
disk_bus=root_device_info['disk_bus'])
|
|
|
|
@mock.patch.object(vmops.VMOps, '_attach_drive')
|
|
def test_attach_root_device_disk(self, mock_attach_drive):
|
|
mock_instance = fake_instance.fake_instance_obj(self.context)
|
|
root_device_info = {'type': constants.DISK,
|
|
'boot_index': 0,
|
|
'disk_bus': constants.CTRL_TYPE_IDE,
|
|
'path': 'fake_path',
|
|
'drive_addr': 0,
|
|
'ctrl_disk_addr': 1}
|
|
|
|
self._vmops._attach_root_device(mock_instance.name, root_device_info)
|
|
|
|
mock_attach_drive.assert_called_once_with(
|
|
mock_instance.name, root_device_info['path'],
|
|
root_device_info['drive_addr'], root_device_info['ctrl_disk_addr'],
|
|
root_device_info['disk_bus'], root_device_info['type'])
|
|
|
|
@mock.patch.object(vmops.VMOps, '_attach_drive')
|
|
def test_attach_ephemerals(self, mock_attach_drive):
|
|
mock_instance = fake_instance.fake_instance_obj(self.context)
|
|
|
|
ephemerals = [{'path': mock.sentinel.PATH1,
|
|
'boot_index': 1,
|
|
'disk_bus': constants.CTRL_TYPE_IDE,
|
|
'device_type': 'disk',
|
|
'drive_addr': 0,
|
|
'ctrl_disk_addr': 1},
|
|
{'path': mock.sentinel.PATH2,
|
|
'boot_index': 2,
|
|
'disk_bus': constants.CTRL_TYPE_SCSI,
|
|
'device_type': 'disk',
|
|
'drive_addr': 0,
|
|
'ctrl_disk_addr': 0},
|
|
{'path': None}]
|
|
|
|
self._vmops._attach_ephemerals(mock_instance.name, ephemerals)
|
|
|
|
mock_attach_drive.assert_has_calls(
|
|
[mock.call(mock_instance.name, mock.sentinel.PATH1, 0,
|
|
1, constants.CTRL_TYPE_IDE, constants.DISK),
|
|
mock.call(mock_instance.name, mock.sentinel.PATH2, 0,
|
|
0, constants.CTRL_TYPE_SCSI, constants.DISK)
|
|
])
|
|
|
|
def test_attach_drive_vm_to_scsi(self):
|
|
self._vmops._attach_drive(
|
|
mock.sentinel.FAKE_VM_NAME, mock.sentinel.FAKE_PATH,
|
|
mock.sentinel.FAKE_DRIVE_ADDR, mock.sentinel.FAKE_CTRL_DISK_ADDR,
|
|
constants.CTRL_TYPE_SCSI)
|
|
|
|
self._vmops._vmutils.attach_scsi_drive.assert_called_once_with(
|
|
mock.sentinel.FAKE_VM_NAME, mock.sentinel.FAKE_PATH,
|
|
constants.DISK)
|
|
|
|
def test_attach_drive_vm_to_ide(self):
|
|
self._vmops._attach_drive(
|
|
mock.sentinel.FAKE_VM_NAME, mock.sentinel.FAKE_PATH,
|
|
mock.sentinel.FAKE_DRIVE_ADDR, mock.sentinel.FAKE_CTRL_DISK_ADDR,
|
|
constants.CTRL_TYPE_IDE)
|
|
|
|
self._vmops._vmutils.attach_ide_drive.assert_called_once_with(
|
|
mock.sentinel.FAKE_VM_NAME, mock.sentinel.FAKE_PATH,
|
|
mock.sentinel.FAKE_DRIVE_ADDR, mock.sentinel.FAKE_CTRL_DISK_ADDR,
|
|
constants.DISK)
|
|
|
|
def test_get_image_vm_generation_default(self):
|
|
image_meta = objects.ImageMeta.from_dict({"properties": {}})
|
|
self._vmops._hostutils.get_default_vm_generation.return_value = (
|
|
constants.IMAGE_PROP_VM_GEN_1)
|
|
self._vmops._hostutils.get_supported_vm_types.return_value = [
|
|
constants.IMAGE_PROP_VM_GEN_1, constants.IMAGE_PROP_VM_GEN_2]
|
|
|
|
response = self._vmops.get_image_vm_generation(
|
|
mock.sentinel.instance_id, image_meta)
|
|
|
|
self.assertEqual(constants.VM_GEN_1, response)
|
|
|
|
def test_get_image_vm_generation_gen2(self):
|
|
image_meta = objects.ImageMeta.from_dict(
|
|
{"properties":
|
|
{"hw_machine_type": constants.IMAGE_PROP_VM_GEN_2}})
|
|
self._vmops._hostutils.get_supported_vm_types.return_value = [
|
|
constants.IMAGE_PROP_VM_GEN_1, constants.IMAGE_PROP_VM_GEN_2]
|
|
|
|
response = self._vmops.get_image_vm_generation(
|
|
mock.sentinel.instance_id, image_meta)
|
|
|
|
self.assertEqual(constants.VM_GEN_2, response)
|
|
|
|
def test_check_vm_image_type_exception(self):
|
|
self._vmops._vhdutils.get_vhd_format.return_value = (
|
|
constants.DISK_FORMAT_VHD)
|
|
|
|
self.assertRaises(exception.InstanceUnacceptable,
|
|
self._vmops.check_vm_image_type,
|
|
mock.sentinel.instance_id, constants.VM_GEN_2,
|
|
mock.sentinel.FAKE_PATH)
|
|
|
|
def _check_requires_certificate(self, os_type):
|
|
mock_image_meta = mock.MagicMock()
|
|
mock_image_meta.properties = {'os_type': os_type}
|
|
|
|
expected_result = os_type == fields.OSType.LINUX
|
|
result = self._vmops._requires_certificate(mock_image_meta)
|
|
self.assertEqual(expected_result, result)
|
|
|
|
def test_requires_certificate_windows(self):
|
|
self._check_requires_certificate(os_type=fields.OSType.WINDOWS)
|
|
|
|
def test_requires_certificate_linux(self):
|
|
self._check_requires_certificate(os_type=fields.OSType.LINUX)
|
|
|
|
def _check_requires_secure_boot(
|
|
self, image_prop_os_type=fields.OSType.LINUX,
|
|
image_prop_secure_boot=fields.SecureBoot.REQUIRED,
|
|
flavor_secure_boot=fields.SecureBoot.REQUIRED,
|
|
vm_gen=constants.VM_GEN_2, expected_exception=True):
|
|
mock_instance = fake_instance.fake_instance_obj(self.context)
|
|
if flavor_secure_boot:
|
|
mock_instance.flavor.extra_specs = {
|
|
constants.FLAVOR_SPEC_SECURE_BOOT: flavor_secure_boot}
|
|
mock_image_meta = mock.MagicMock()
|
|
mock_image_meta.properties = {'os_type': image_prop_os_type}
|
|
if image_prop_secure_boot:
|
|
mock_image_meta.properties['os_secure_boot'] = (
|
|
image_prop_secure_boot)
|
|
|
|
if expected_exception:
|
|
self.assertRaises(exception.InstanceUnacceptable,
|
|
self._vmops._requires_secure_boot,
|
|
mock_instance, mock_image_meta, vm_gen)
|
|
else:
|
|
result = self._vmops._requires_secure_boot(mock_instance,
|
|
mock_image_meta,
|
|
vm_gen)
|
|
|
|
requires_sb = fields.SecureBoot.REQUIRED in [
|
|
flavor_secure_boot, image_prop_secure_boot]
|
|
self.assertEqual(requires_sb, result)
|
|
|
|
def test_requires_secure_boot_ok(self):
|
|
self._check_requires_secure_boot(
|
|
expected_exception=False)
|
|
|
|
def test_requires_secure_boot_image_img_prop_none(self):
|
|
self._check_requires_secure_boot(
|
|
image_prop_secure_boot=None,
|
|
expected_exception=False)
|
|
|
|
def test_requires_secure_boot_image_extra_spec_none(self):
|
|
self._check_requires_secure_boot(
|
|
flavor_secure_boot=None,
|
|
expected_exception=False)
|
|
|
|
def test_requires_secure_boot_flavor_no_os_type(self):
|
|
self._check_requires_secure_boot(
|
|
image_prop_os_type=None)
|
|
|
|
def test_requires_secure_boot_flavor_no_os_type_no_exc(self):
|
|
self._check_requires_secure_boot(
|
|
image_prop_os_type=None,
|
|
image_prop_secure_boot=fields.SecureBoot.DISABLED,
|
|
flavor_secure_boot=fields.SecureBoot.DISABLED,
|
|
expected_exception=False)
|
|
|
|
def test_requires_secure_boot_flavor_disabled(self):
|
|
self._check_requires_secure_boot(
|
|
flavor_secure_boot=fields.SecureBoot.DISABLED)
|
|
|
|
def test_requires_secure_boot_image_disabled(self):
|
|
self._check_requires_secure_boot(
|
|
image_prop_secure_boot=fields.SecureBoot.DISABLED)
|
|
|
|
def test_requires_secure_boot_generation_1(self):
|
|
self._check_requires_secure_boot(vm_gen=constants.VM_GEN_1)
|
|
|
|
@mock.patch('nova.api.metadata.base.InstanceMetadata')
|
|
@mock.patch('nova.virt.configdrive.ConfigDriveBuilder')
|
|
@mock.patch('nova.utils.execute')
|
|
def _test_create_config_drive(self, mock_execute, mock_ConfigDriveBuilder,
|
|
mock_InstanceMetadata, config_drive_format,
|
|
config_drive_cdrom, side_effect,
|
|
rescue=False):
|
|
mock_instance = fake_instance.fake_instance_obj(self.context)
|
|
self.flags(config_drive_format=config_drive_format)
|
|
self.flags(config_drive_cdrom=config_drive_cdrom, group='hyperv')
|
|
self.flags(config_drive_inject_password=True, group='hyperv')
|
|
mock_ConfigDriveBuilder().__enter__().make_drive.side_effect = [
|
|
side_effect]
|
|
|
|
path_iso = os.path.join(self.FAKE_DIR, self.FAKE_CONFIG_DRIVE_ISO)
|
|
path_vhd = os.path.join(self.FAKE_DIR, self.FAKE_CONFIG_DRIVE_VHD)
|
|
|
|
def fake_get_configdrive_path(instance_name, disk_format,
|
|
rescue=False):
|
|
return (path_iso
|
|
if disk_format == constants.DVD_FORMAT else path_vhd)
|
|
|
|
mock_get_configdrive_path = self._vmops._pathutils.get_configdrive_path
|
|
mock_get_configdrive_path.side_effect = fake_get_configdrive_path
|
|
expected_get_configdrive_path_calls = [mock.call(mock_instance.name,
|
|
constants.DVD_FORMAT,
|
|
rescue=rescue)]
|
|
if not config_drive_cdrom:
|
|
expected_call = mock.call(mock_instance.name,
|
|
constants.DISK_FORMAT_VHD,
|
|
rescue=rescue)
|
|
expected_get_configdrive_path_calls.append(expected_call)
|
|
|
|
if config_drive_format != self.ISO9660:
|
|
self.assertRaises(exception.ConfigDriveUnsupportedFormat,
|
|
self._vmops._create_config_drive,
|
|
self.context,
|
|
mock_instance,
|
|
[mock.sentinel.FILE],
|
|
mock.sentinel.PASSWORD,
|
|
mock.sentinel.NET_INFO,
|
|
rescue)
|
|
elif side_effect is processutils.ProcessExecutionError:
|
|
self.assertRaises(processutils.ProcessExecutionError,
|
|
self._vmops._create_config_drive,
|
|
self.context,
|
|
mock_instance,
|
|
[mock.sentinel.FILE],
|
|
mock.sentinel.PASSWORD,
|
|
mock.sentinel.NET_INFO,
|
|
rescue)
|
|
else:
|
|
path = self._vmops._create_config_drive(self.context,
|
|
mock_instance,
|
|
[mock.sentinel.FILE],
|
|
mock.sentinel.PASSWORD,
|
|
mock.sentinel.NET_INFO,
|
|
rescue)
|
|
mock_InstanceMetadata.assert_called_once_with(
|
|
mock_instance, content=[mock.sentinel.FILE],
|
|
extra_md={'admin_pass': mock.sentinel.PASSWORD},
|
|
network_info=mock.sentinel.NET_INFO,
|
|
request_context=self.context)
|
|
mock_get_configdrive_path.assert_has_calls(
|
|
expected_get_configdrive_path_calls)
|
|
mock_ConfigDriveBuilder.assert_called_with(
|
|
instance_md=mock_InstanceMetadata())
|
|
mock_make_drive = mock_ConfigDriveBuilder().__enter__().make_drive
|
|
mock_make_drive.assert_called_once_with(path_iso)
|
|
if not CONF.hyperv.config_drive_cdrom:
|
|
expected = path_vhd
|
|
mock_execute.assert_called_once_with(
|
|
CONF.hyperv.qemu_img_cmd,
|
|
'convert', '-f', 'raw', '-O', 'vpc',
|
|
path_iso, path_vhd, attempts=1)
|
|
self._vmops._pathutils.remove.assert_called_once_with(
|
|
os.path.join(self.FAKE_DIR, self.FAKE_CONFIG_DRIVE_ISO))
|
|
else:
|
|
expected = path_iso
|
|
|
|
self.assertEqual(expected, path)
|
|
|
|
def test_create_config_drive_cdrom(self):
|
|
self._test_create_config_drive(config_drive_format=self.ISO9660,
|
|
config_drive_cdrom=True,
|
|
side_effect=None)
|
|
|
|
def test_create_config_drive_vhd(self):
|
|
self._test_create_config_drive(config_drive_format=self.ISO9660,
|
|
config_drive_cdrom=False,
|
|
side_effect=None)
|
|
|
|
def test_create_rescue_config_drive_vhd(self):
|
|
self._test_create_config_drive(config_drive_format=self.ISO9660,
|
|
config_drive_cdrom=False,
|
|
side_effect=None,
|
|
rescue=True)
|
|
|
|
def test_create_config_drive_execution_error(self):
|
|
self._test_create_config_drive(
|
|
config_drive_format=self.ISO9660,
|
|
config_drive_cdrom=False,
|
|
side_effect=processutils.ProcessExecutionError)
|
|
|
|
def test_attach_config_drive_exception(self):
|
|
instance = fake_instance.fake_instance_obj(self.context)
|
|
self.assertRaises(exception.InvalidDiskFormat,
|
|
self._vmops.attach_config_drive,
|
|
instance, 'C:/fake_instance_dir/configdrive.xxx',
|
|
constants.VM_GEN_1)
|
|
|
|
@mock.patch.object(vmops.VMOps, '_attach_drive')
|
|
def test_attach_config_drive(self, mock_attach_drive):
|
|
instance = fake_instance.fake_instance_obj(self.context)
|
|
self._vmops.attach_config_drive(instance,
|
|
self._FAKE_CONFIGDRIVE_PATH,
|
|
constants.VM_GEN_1)
|
|
mock_attach_drive.assert_called_once_with(
|
|
instance.name, self._FAKE_CONFIGDRIVE_PATH,
|
|
1, 0, constants.CTRL_TYPE_IDE, constants.DISK)
|
|
|
|
@mock.patch.object(vmops.VMOps, '_attach_drive')
|
|
def test_attach_config_drive_gen2(self, mock_attach_drive):
|
|
instance = fake_instance.fake_instance_obj(self.context)
|
|
self._vmops.attach_config_drive(instance,
|
|
self._FAKE_CONFIGDRIVE_PATH,
|
|
constants.VM_GEN_2)
|
|
mock_attach_drive.assert_called_once_with(
|
|
instance.name, self._FAKE_CONFIGDRIVE_PATH,
|
|
1, 0, constants.CTRL_TYPE_SCSI, constants.DISK)
|
|
|
|
def test_detach_config_drive(self):
|
|
is_rescue_configdrive = True
|
|
mock_lookup_configdrive = (
|
|
self._vmops._pathutils.lookup_configdrive_path)
|
|
mock_lookup_configdrive.return_value = mock.sentinel.configdrive_path
|
|
|
|
self._vmops._detach_config_drive(mock.sentinel.instance_name,
|
|
rescue=is_rescue_configdrive,
|
|
delete=True)
|
|
|
|
mock_lookup_configdrive.assert_called_once_with(
|
|
mock.sentinel.instance_name,
|
|
rescue=is_rescue_configdrive)
|
|
self._vmops._vmutils.detach_vm_disk.assert_called_once_with(
|
|
mock.sentinel.instance_name, mock.sentinel.configdrive_path,
|
|
is_physical=False)
|
|
self._vmops._pathutils.remove.assert_called_once_with(
|
|
mock.sentinel.configdrive_path)
|
|
|
|
def test_delete_disk_files(self):
|
|
mock_instance = fake_instance.fake_instance_obj(self.context)
|
|
self._vmops._delete_disk_files(mock_instance.name)
|
|
|
|
stop_console_handler = (
|
|
self._vmops._serial_console_ops.stop_console_handler_unsync)
|
|
stop_console_handler.assert_called_once_with(mock_instance.name)
|
|
self._vmops._pathutils.get_instance_dir.assert_called_once_with(
|
|
mock_instance.name, create_dir=False, remove_dir=True)
|
|
|
|
@ddt.data(True, False)
|
|
@mock.patch('nova.virt.hyperv.volumeops.VolumeOps.disconnect_volumes')
|
|
@mock.patch('nova.virt.hyperv.vmops.VMOps._delete_disk_files')
|
|
@mock.patch('nova.virt.hyperv.vmops.VMOps.power_off')
|
|
@mock.patch('nova.virt.hyperv.vmops.VMOps.unplug_vifs')
|
|
def test_destroy(self, vm_exists, mock_unplug_vifs, mock_power_off,
|
|
mock_delete_disk_files, mock_disconnect_volumes):
|
|
mock_instance = fake_instance.fake_instance_obj(self.context)
|
|
self._vmops._vmutils.vm_exists.return_value = vm_exists
|
|
|
|
self._vmops.destroy(instance=mock_instance,
|
|
block_device_info=mock.sentinel.FAKE_BD_INFO,
|
|
network_info=mock.sentinel.fake_network_info)
|
|
|
|
if vm_exists:
|
|
self._vmops._vmutils.stop_vm_jobs.assert_called_once_with(
|
|
mock_instance.name)
|
|
mock_power_off.assert_called_once_with(mock_instance)
|
|
self._vmops._vmutils.destroy_vm.assert_called_once_with(
|
|
mock_instance.name)
|
|
else:
|
|
self.assertFalse(mock_power_off.called)
|
|
self.assertFalse(self._vmops._vmutils.destroy_vm.called)
|
|
|
|
self._vmops._vmutils.vm_exists.assert_called_with(
|
|
mock_instance.name)
|
|
mock_unplug_vifs.assert_called_once_with(
|
|
mock_instance, mock.sentinel.fake_network_info)
|
|
mock_disconnect_volumes.assert_called_once_with(
|
|
mock.sentinel.FAKE_BD_INFO)
|
|
mock_delete_disk_files.assert_called_once_with(
|
|
mock_instance.name)
|
|
|
|
@mock.patch('nova.virt.hyperv.vmops.VMOps.power_off')
|
|
def test_destroy_exception(self, mock_power_off):
|
|
mock_instance = fake_instance.fake_instance_obj(self.context)
|
|
self._vmops._vmutils.destroy_vm.side_effect = (
|
|
os_win_exc.HyperVException)
|
|
self._vmops._vmutils.vm_exists.return_value = True
|
|
|
|
self.assertRaises(os_win_exc.HyperVException,
|
|
self._vmops.destroy, mock_instance,
|
|
mock.sentinel.network_info,
|
|
mock.sentinel.block_device_info)
|
|
|
|
def test_reboot_hard(self):
|
|
self._test_reboot(vmops.REBOOT_TYPE_HARD,
|
|
os_win_const.HYPERV_VM_STATE_REBOOT)
|
|
|
|
@mock.patch("nova.virt.hyperv.vmops.VMOps._soft_shutdown")
|
|
def test_reboot_soft(self, mock_soft_shutdown):
|
|
mock_soft_shutdown.return_value = True
|
|
self._test_reboot(vmops.REBOOT_TYPE_SOFT,
|
|
os_win_const.HYPERV_VM_STATE_ENABLED)
|
|
|
|
@mock.patch("nova.virt.hyperv.vmops.VMOps._soft_shutdown")
|
|
def test_reboot_soft_failed(self, mock_soft_shutdown):
|
|
mock_soft_shutdown.return_value = False
|
|
self._test_reboot(vmops.REBOOT_TYPE_SOFT,
|
|
os_win_const.HYPERV_VM_STATE_REBOOT)
|
|
|
|
@mock.patch("nova.virt.hyperv.vmops.VMOps.power_on")
|
|
@mock.patch("nova.virt.hyperv.vmops.VMOps._soft_shutdown")
|
|
def test_reboot_soft_exception(self, mock_soft_shutdown, mock_power_on):
|
|
mock_soft_shutdown.return_value = True
|
|
mock_power_on.side_effect = os_win_exc.HyperVException(
|
|
"Expected failure")
|
|
instance = fake_instance.fake_instance_obj(self.context)
|
|
|
|
self.assertRaises(os_win_exc.HyperVException, self._vmops.reboot,
|
|
instance, {}, vmops.REBOOT_TYPE_SOFT)
|
|
|
|
mock_soft_shutdown.assert_called_once_with(instance)
|
|
mock_power_on.assert_called_once_with(instance, network_info={})
|
|
|
|
def _test_reboot(self, reboot_type, vm_state):
|
|
instance = fake_instance.fake_instance_obj(self.context)
|
|
with mock.patch.object(self._vmops, '_set_vm_state') as mock_set_state:
|
|
self._vmops.reboot(instance, {}, reboot_type)
|
|
mock_set_state.assert_called_once_with(instance, vm_state)
|
|
|
|
@mock.patch("nova.virt.hyperv.vmops.VMOps._wait_for_power_off")
|
|
def test_soft_shutdown(self, mock_wait_for_power_off):
|
|
instance = fake_instance.fake_instance_obj(self.context)
|
|
mock_wait_for_power_off.return_value = True
|
|
|
|
result = self._vmops._soft_shutdown(instance, self._FAKE_TIMEOUT)
|
|
|
|
mock_shutdown_vm = self._vmops._vmutils.soft_shutdown_vm
|
|
mock_shutdown_vm.assert_called_once_with(instance.name)
|
|
mock_wait_for_power_off.assert_called_once_with(
|
|
instance.name, self._FAKE_TIMEOUT)
|
|
|
|
self.assertTrue(result)
|
|
|
|
@mock.patch("time.sleep")
|
|
def test_soft_shutdown_failed(self, mock_sleep):
|
|
instance = fake_instance.fake_instance_obj(self.context)
|
|
|
|
mock_shutdown_vm = self._vmops._vmutils.soft_shutdown_vm
|
|
mock_shutdown_vm.side_effect = os_win_exc.HyperVException(
|
|
"Expected failure.")
|
|
|
|
result = self._vmops._soft_shutdown(instance, self._FAKE_TIMEOUT)
|
|
|
|
mock_shutdown_vm.assert_called_once_with(instance.name)
|
|
self.assertFalse(result)
|
|
|
|
@mock.patch("nova.virt.hyperv.vmops.VMOps._wait_for_power_off")
|
|
def test_soft_shutdown_wait(self, mock_wait_for_power_off):
|
|
instance = fake_instance.fake_instance_obj(self.context)
|
|
mock_wait_for_power_off.side_effect = [False, True]
|
|
|
|
result = self._vmops._soft_shutdown(instance, self._FAKE_TIMEOUT, 1)
|
|
|
|
calls = [mock.call(instance.name, 1),
|
|
mock.call(instance.name, self._FAKE_TIMEOUT - 1)]
|
|
mock_shutdown_vm = self._vmops._vmutils.soft_shutdown_vm
|
|
mock_shutdown_vm.assert_called_with(instance.name)
|
|
mock_wait_for_power_off.assert_has_calls(calls)
|
|
|
|
self.assertTrue(result)
|
|
|
|
@mock.patch("nova.virt.hyperv.vmops.VMOps._wait_for_power_off")
|
|
def test_soft_shutdown_wait_timeout(self, mock_wait_for_power_off):
|
|
instance = fake_instance.fake_instance_obj(self.context)
|
|
mock_wait_for_power_off.return_value = False
|
|
|
|
result = self._vmops._soft_shutdown(instance, self._FAKE_TIMEOUT, 1.5)
|
|
|
|
calls = [mock.call(instance.name, 1.5),
|
|
mock.call(instance.name, self._FAKE_TIMEOUT - 1.5)]
|
|
mock_shutdown_vm = self._vmops._vmutils.soft_shutdown_vm
|
|
mock_shutdown_vm.assert_called_with(instance.name)
|
|
mock_wait_for_power_off.assert_has_calls(calls)
|
|
|
|
self.assertFalse(result)
|
|
|
|
@mock.patch('nova.virt.hyperv.vmops.VMOps._set_vm_state')
|
|
def test_pause(self, mock_set_vm_state):
|
|
mock_instance = fake_instance.fake_instance_obj(self.context)
|
|
self._vmops.pause(instance=mock_instance)
|
|
mock_set_vm_state.assert_called_once_with(
|
|
mock_instance, os_win_const.HYPERV_VM_STATE_PAUSED)
|
|
|
|
@mock.patch('nova.virt.hyperv.vmops.VMOps._set_vm_state')
|
|
def test_unpause(self, mock_set_vm_state):
|
|
mock_instance = fake_instance.fake_instance_obj(self.context)
|
|
self._vmops.unpause(instance=mock_instance)
|
|
mock_set_vm_state.assert_called_once_with(
|
|
mock_instance, os_win_const.HYPERV_VM_STATE_ENABLED)
|
|
|
|
@mock.patch('nova.virt.hyperv.vmops.VMOps._set_vm_state')
|
|
def test_suspend(self, mock_set_vm_state):
|
|
mock_instance = fake_instance.fake_instance_obj(self.context)
|
|
self._vmops.suspend(instance=mock_instance)
|
|
mock_set_vm_state.assert_called_once_with(
|
|
mock_instance, os_win_const.HYPERV_VM_STATE_SUSPENDED)
|
|
|
|
@mock.patch('nova.virt.hyperv.vmops.VMOps._set_vm_state')
|
|
def test_resume(self, mock_set_vm_state):
|
|
mock_instance = fake_instance.fake_instance_obj(self.context)
|
|
self._vmops.resume(instance=mock_instance)
|
|
mock_set_vm_state.assert_called_once_with(
|
|
mock_instance, os_win_const.HYPERV_VM_STATE_ENABLED)
|
|
|
|
def _test_power_off(self, timeout, set_state_expected=True):
|
|
instance = fake_instance.fake_instance_obj(self.context)
|
|
with mock.patch.object(self._vmops, '_set_vm_state') as mock_set_state:
|
|
self._vmops.power_off(instance, timeout)
|
|
|
|
serialops = self._vmops._serial_console_ops
|
|
serialops.stop_console_handler.assert_called_once_with(
|
|
instance.name)
|
|
if set_state_expected:
|
|
mock_set_state.assert_called_once_with(
|
|
instance, os_win_const.HYPERV_VM_STATE_DISABLED)
|
|
|
|
def test_power_off_hard(self):
|
|
self._test_power_off(timeout=0)
|
|
|
|
@mock.patch("nova.virt.hyperv.vmops.VMOps._soft_shutdown")
|
|
def test_power_off_exception(self, mock_soft_shutdown):
|
|
mock_soft_shutdown.return_value = False
|
|
self._test_power_off(timeout=1)
|
|
|
|
@mock.patch("nova.virt.hyperv.vmops.VMOps._set_vm_state")
|
|
@mock.patch("nova.virt.hyperv.vmops.VMOps._soft_shutdown")
|
|
def test_power_off_soft(self, mock_soft_shutdown, mock_set_state):
|
|
instance = fake_instance.fake_instance_obj(self.context)
|
|
mock_soft_shutdown.return_value = True
|
|
|
|
self._vmops.power_off(instance, 1, 0)
|
|
|
|
serialops = self._vmops._serial_console_ops
|
|
serialops.stop_console_handler.assert_called_once_with(
|
|
instance.name)
|
|
mock_soft_shutdown.assert_called_once_with(
|
|
instance, 1, vmops.SHUTDOWN_TIME_INCREMENT)
|
|
self.assertFalse(mock_set_state.called)
|
|
|
|
@mock.patch("nova.virt.hyperv.vmops.VMOps._soft_shutdown")
|
|
def test_power_off_unexisting_instance(self, mock_soft_shutdown):
|
|
mock_soft_shutdown.side_effect = os_win_exc.HyperVVMNotFoundException(
|
|
vm_name=mock.sentinel.vm_name)
|
|
self._test_power_off(timeout=1, set_state_expected=False)
|
|
|
|
@mock.patch('nova.virt.hyperv.vmops.VMOps._set_vm_state')
|
|
def test_power_on(self, mock_set_vm_state):
|
|
mock_instance = fake_instance.fake_instance_obj(self.context)
|
|
|
|
self._vmops.power_on(mock_instance)
|
|
|
|
mock_set_vm_state.assert_called_once_with(
|
|
mock_instance, os_win_const.HYPERV_VM_STATE_ENABLED)
|
|
|
|
@mock.patch('nova.virt.hyperv.volumeops.VolumeOps'
|
|
'.fix_instance_volume_disk_paths')
|
|
@mock.patch('nova.virt.hyperv.vmops.VMOps._set_vm_state')
|
|
def test_power_on_having_block_devices(self, mock_set_vm_state,
|
|
mock_fix_instance_vol_paths):
|
|
mock_instance = fake_instance.fake_instance_obj(self.context)
|
|
|
|
self._vmops.power_on(mock_instance, mock.sentinel.block_device_info)
|
|
|
|
mock_fix_instance_vol_paths.assert_called_once_with(
|
|
mock_instance.name, mock.sentinel.block_device_info)
|
|
mock_set_vm_state.assert_called_once_with(
|
|
mock_instance, os_win_const.HYPERV_VM_STATE_ENABLED)
|
|
|
|
@mock.patch.object(vmops.VMOps, 'plug_vifs')
|
|
def test_power_on_with_network_info(self, mock_plug_vifs):
|
|
mock_instance = fake_instance.fake_instance_obj(self.context)
|
|
|
|
self._vmops.power_on(mock_instance,
|
|
network_info=mock.sentinel.fake_network_info)
|
|
mock_plug_vifs.assert_called_once_with(
|
|
mock_instance, mock.sentinel.fake_network_info)
|
|
|
|
def _test_set_vm_state(self, state):
|
|
mock_instance = fake_instance.fake_instance_obj(self.context)
|
|
|
|
self._vmops._set_vm_state(mock_instance, state)
|
|
self._vmops._vmutils.set_vm_state.assert_called_once_with(
|
|
mock_instance.name, state)
|
|
|
|
def test_set_vm_state_disabled(self):
|
|
self._test_set_vm_state(state=os_win_const.HYPERV_VM_STATE_DISABLED)
|
|
|
|
def test_set_vm_state_enabled(self):
|
|
self._test_set_vm_state(state=os_win_const.HYPERV_VM_STATE_ENABLED)
|
|
|
|
def test_set_vm_state_reboot(self):
|
|
self._test_set_vm_state(state=os_win_const.HYPERV_VM_STATE_REBOOT)
|
|
|
|
def test_set_vm_state_exception(self):
|
|
mock_instance = fake_instance.fake_instance_obj(self.context)
|
|
self._vmops._vmutils.set_vm_state.side_effect = (
|
|
os_win_exc.HyperVException)
|
|
self.assertRaises(os_win_exc.HyperVException,
|
|
self._vmops._set_vm_state,
|
|
mock_instance, mock.sentinel.STATE)
|
|
|
|
def test_get_vm_state(self):
|
|
summary_info = {'EnabledState': os_win_const.HYPERV_VM_STATE_DISABLED}
|
|
|
|
with mock.patch.object(self._vmops._vmutils,
|
|
'get_vm_summary_info') as mock_get_summary_info:
|
|
mock_get_summary_info.return_value = summary_info
|
|
|
|
response = self._vmops._get_vm_state(mock.sentinel.FAKE_VM_NAME)
|
|
self.assertEqual(response, os_win_const.HYPERV_VM_STATE_DISABLED)
|
|
|
|
@mock.patch.object(vmops.VMOps, '_get_vm_state')
|
|
def test_wait_for_power_off_true(self, mock_get_state):
|
|
mock_get_state.return_value = os_win_const.HYPERV_VM_STATE_DISABLED
|
|
result = self._vmops._wait_for_power_off(
|
|
mock.sentinel.FAKE_VM_NAME, vmops.SHUTDOWN_TIME_INCREMENT)
|
|
mock_get_state.assert_called_with(mock.sentinel.FAKE_VM_NAME)
|
|
self.assertTrue(result)
|
|
|
|
@mock.patch.object(vmops.etimeout, "with_timeout")
|
|
def test_wait_for_power_off_false(self, mock_with_timeout):
|
|
mock_with_timeout.side_effect = etimeout.Timeout()
|
|
result = self._vmops._wait_for_power_off(
|
|
mock.sentinel.FAKE_VM_NAME, vmops.SHUTDOWN_TIME_INCREMENT)
|
|
self.assertFalse(result)
|
|
|
|
def test_create_vm_com_port_pipes(self):
|
|
mock_instance = fake_instance.fake_instance_obj(self.context)
|
|
mock_serial_ports = {
|
|
1: constants.SERIAL_PORT_TYPE_RO,
|
|
2: constants.SERIAL_PORT_TYPE_RW
|
|
}
|
|
|
|
self._vmops._create_vm_com_port_pipes(mock_instance,
|
|
mock_serial_ports)
|
|
expected_calls = []
|
|
for port_number, port_type in mock_serial_ports.items():
|
|
expected_pipe = r'\\.\pipe\%s_%s' % (mock_instance.uuid,
|
|
port_type)
|
|
expected_calls.append(mock.call(mock_instance.name,
|
|
port_number,
|
|
expected_pipe))
|
|
|
|
mock_set_conn = self._vmops._vmutils.set_vm_serial_port_connection
|
|
mock_set_conn.assert_has_calls(expected_calls)
|
|
|
|
def test_list_instance_uuids(self):
|
|
fake_uuid = '4f54fb69-d3a2-45b7-bb9b-b6e6b3d893b3'
|
|
with mock.patch.object(self._vmops._vmutils,
|
|
'list_instance_notes') as mock_list_notes:
|
|
mock_list_notes.return_value = [('fake_name', [fake_uuid])]
|
|
|
|
response = self._vmops.list_instance_uuids()
|
|
mock_list_notes.assert_called_once_with()
|
|
|
|
self.assertEqual(response, [fake_uuid])
|
|
|
|
def test_copy_vm_dvd_disks(self):
|
|
fake_paths = [mock.sentinel.FAKE_DVD_PATH1,
|
|
mock.sentinel.FAKE_DVD_PATH2]
|
|
mock_copy = self._vmops._pathutils.copyfile
|
|
mock_get_dvd_disk_paths = self._vmops._vmutils.get_vm_dvd_disk_paths
|
|
mock_get_dvd_disk_paths.return_value = fake_paths
|
|
self._vmops._pathutils.get_instance_dir.return_value = (
|
|
mock.sentinel.FAKE_DEST_PATH)
|
|
|
|
self._vmops.copy_vm_dvd_disks(mock.sentinel.FAKE_VM_NAME,
|
|
mock.sentinel.FAKE_DEST_HOST)
|
|
|
|
mock_get_dvd_disk_paths.assert_called_with(mock.sentinel.FAKE_VM_NAME)
|
|
self._vmops._pathutils.get_instance_dir.assert_called_once_with(
|
|
mock.sentinel.FAKE_VM_NAME,
|
|
remote_server=mock.sentinel.FAKE_DEST_HOST)
|
|
mock_copy.has_calls(mock.call(mock.sentinel.FAKE_DVD_PATH1,
|
|
mock.sentinel.FAKE_DEST_PATH),
|
|
mock.call(mock.sentinel.FAKE_DVD_PATH2,
|
|
mock.sentinel.FAKE_DEST_PATH))
|
|
|
|
def test_plug_vifs(self):
|
|
mock_instance = fake_instance.fake_instance_obj(self.context)
|
|
fake_vif1 = {'id': mock.sentinel.ID1,
|
|
'type': mock.sentinel.vif_type1}
|
|
fake_vif2 = {'id': mock.sentinel.ID2,
|
|
'type': mock.sentinel.vif_type2}
|
|
mock_network_info = [fake_vif1, fake_vif2]
|
|
calls = [mock.call(mock_instance, fake_vif1),
|
|
mock.call(mock_instance, fake_vif2)]
|
|
|
|
self._vmops.plug_vifs(mock_instance,
|
|
network_info=mock_network_info)
|
|
self._vmops._vif_driver.plug.assert_has_calls(calls)
|
|
|
|
def test_unplug_vifs(self):
|
|
mock_instance = fake_instance.fake_instance_obj(self.context)
|
|
fake_vif1 = {'id': mock.sentinel.ID1,
|
|
'type': mock.sentinel.vif_type1}
|
|
fake_vif2 = {'id': mock.sentinel.ID2,
|
|
'type': mock.sentinel.vif_type2}
|
|
mock_network_info = [fake_vif1, fake_vif2]
|
|
calls = [mock.call(mock_instance, fake_vif1),
|
|
mock.call(mock_instance, fake_vif2)]
|
|
|
|
self._vmops.unplug_vifs(mock_instance,
|
|
network_info=mock_network_info)
|
|
self._vmops._vif_driver.unplug.assert_has_calls(calls)
|
|
|
|
def _setup_remotefx_mocks(self):
|
|
mock_instance = fake_instance.fake_instance_obj(self.context)
|
|
mock_instance.flavor.extra_specs = {
|
|
'os:resolution': os_win_const.REMOTEFX_MAX_RES_1920x1200,
|
|
'os:monitors': '2',
|
|
'os:vram': '256'}
|
|
|
|
return mock_instance
|
|
|
|
def test_configure_remotefx_not_required(self):
|
|
self.flags(enable_remotefx=False, group='hyperv')
|
|
mock_instance = fake_instance.fake_instance_obj(self.context)
|
|
|
|
self._vmops._configure_remotefx(mock_instance, mock.sentinel.VM_GEN)
|
|
|
|
def test_configure_remotefx_exception_enable_config(self):
|
|
self.flags(enable_remotefx=False, group='hyperv')
|
|
mock_instance = self._setup_remotefx_mocks()
|
|
|
|
self.assertRaises(exception.InstanceUnacceptable,
|
|
self._vmops._configure_remotefx,
|
|
mock_instance, mock.sentinel.VM_GEN)
|
|
|
|
def test_configure_remotefx_exception_server_feature(self):
|
|
self.flags(enable_remotefx=True, group='hyperv')
|
|
mock_instance = self._setup_remotefx_mocks()
|
|
self._vmops._hostutils.check_server_feature.return_value = False
|
|
|
|
self.assertRaises(exception.InstanceUnacceptable,
|
|
self._vmops._configure_remotefx,
|
|
mock_instance, mock.sentinel.VM_GEN)
|
|
|
|
def test_configure_remotefx_exception_vm_gen(self):
|
|
self.flags(enable_remotefx=True, group='hyperv')
|
|
mock_instance = self._setup_remotefx_mocks()
|
|
self._vmops._hostutils.check_server_feature.return_value = True
|
|
self._vmops._vmutils.vm_gen_supports_remotefx.return_value = False
|
|
|
|
self.assertRaises(exception.InstanceUnacceptable,
|
|
self._vmops._configure_remotefx,
|
|
mock_instance, mock.sentinel.VM_GEN)
|
|
|
|
def test_configure_remotefx(self):
|
|
self.flags(enable_remotefx=True, group='hyperv')
|
|
mock_instance = self._setup_remotefx_mocks()
|
|
self._vmops._hostutils.check_server_feature.return_value = True
|
|
self._vmops._vmutils.vm_gen_supports_remotefx.return_value = True
|
|
extra_specs = mock_instance.flavor.extra_specs
|
|
|
|
self._vmops._configure_remotefx(mock_instance,
|
|
constants.VM_GEN_1)
|
|
mock_enable_remotefx = (
|
|
self._vmops._vmutils.enable_remotefx_video_adapter)
|
|
mock_enable_remotefx.assert_called_once_with(
|
|
mock_instance.name, int(extra_specs['os:monitors']),
|
|
extra_specs['os:resolution'],
|
|
int(extra_specs['os:vram']) * units.Mi)
|
|
|
|
@mock.patch.object(vmops.VMOps, '_get_vm_state')
|
|
def test_check_hotplug_available_vm_disabled(self, mock_get_vm_state):
|
|
fake_vm = fake_instance.fake_instance_obj(self.context)
|
|
mock_get_vm_state.return_value = os_win_const.HYPERV_VM_STATE_DISABLED
|
|
|
|
result = self._vmops._check_hotplug_available(fake_vm)
|
|
|
|
self.assertTrue(result)
|
|
mock_get_vm_state.assert_called_once_with(fake_vm.name)
|
|
self.assertFalse(
|
|
self._vmops._hostutils.check_min_windows_version.called)
|
|
self.assertFalse(self._vmops._vmutils.get_vm_generation.called)
|
|
|
|
@mock.patch.object(vmops.VMOps, '_get_vm_state')
|
|
def _test_check_hotplug_available(
|
|
self, mock_get_vm_state, expected_result=False,
|
|
vm_gen=constants.VM_GEN_2, windows_version=_WIN_VERSION_10):
|
|
|
|
fake_vm = fake_instance.fake_instance_obj(self.context)
|
|
mock_get_vm_state.return_value = os_win_const.HYPERV_VM_STATE_ENABLED
|
|
self._vmops._vmutils.get_vm_generation.return_value = vm_gen
|
|
fake_check_win_vers = self._vmops._hostutils.check_min_windows_version
|
|
fake_check_win_vers.return_value = (
|
|
windows_version == self._WIN_VERSION_10)
|
|
|
|
result = self._vmops._check_hotplug_available(fake_vm)
|
|
|
|
self.assertEqual(expected_result, result)
|
|
mock_get_vm_state.assert_called_once_with(fake_vm.name)
|
|
fake_check_win_vers.assert_called_once_with(10, 0)
|
|
|
|
def test_check_if_hotplug_available(self):
|
|
self._test_check_hotplug_available(expected_result=True)
|
|
|
|
def test_check_if_hotplug_available_gen1(self):
|
|
self._test_check_hotplug_available(
|
|
expected_result=False, vm_gen=constants.VM_GEN_1)
|
|
|
|
def test_check_if_hotplug_available_win_6_3(self):
|
|
self._test_check_hotplug_available(
|
|
expected_result=False, windows_version=self._WIN_VERSION_6_3)
|
|
|
|
@mock.patch.object(vmops.VMOps, '_check_hotplug_available')
|
|
def test_attach_interface(self, mock_check_hotplug_available):
|
|
mock_check_hotplug_available.return_value = True
|
|
fake_vm = fake_instance.fake_instance_obj(self.context)
|
|
fake_vif = test_virtual_interface.fake_vif
|
|
|
|
self._vmops.attach_interface(fake_vm, fake_vif)
|
|
|
|
mock_check_hotplug_available.assert_called_once_with(fake_vm)
|
|
self._vmops._vif_driver.plug.assert_called_once_with(
|
|
fake_vm, fake_vif)
|
|
self._vmops._vmutils.create_nic.assert_called_once_with(
|
|
fake_vm.name, fake_vif['id'], fake_vif['address'])
|
|
|
|
@mock.patch.object(vmops.VMOps, '_check_hotplug_available')
|
|
def test_attach_interface_failed(self, mock_check_hotplug_available):
|
|
mock_check_hotplug_available.return_value = False
|
|
self.assertRaises(exception.InterfaceAttachFailed,
|
|
self._vmops.attach_interface,
|
|
mock.MagicMock(), mock.sentinel.fake_vif)
|
|
|
|
@mock.patch.object(vmops.VMOps, '_check_hotplug_available')
|
|
def test_detach_interface(self, mock_check_hotplug_available):
|
|
mock_check_hotplug_available.return_value = True
|
|
fake_vm = fake_instance.fake_instance_obj(self.context)
|
|
fake_vif = test_virtual_interface.fake_vif
|
|
|
|
self._vmops.detach_interface(fake_vm, fake_vif)
|
|
|
|
mock_check_hotplug_available.assert_called_once_with(fake_vm)
|
|
self._vmops._vif_driver.unplug.assert_called_once_with(
|
|
fake_vm, fake_vif)
|
|
self._vmops._vmutils.destroy_nic.assert_called_once_with(
|
|
fake_vm.name, fake_vif['id'])
|
|
|
|
@mock.patch.object(vmops.VMOps, '_check_hotplug_available')
|
|
def test_detach_interface_failed(self, mock_check_hotplug_available):
|
|
mock_check_hotplug_available.return_value = False
|
|
self.assertRaises(exception.InterfaceDetachFailed,
|
|
self._vmops.detach_interface,
|
|
mock.MagicMock(), mock.sentinel.fake_vif)
|
|
|
|
@mock.patch.object(vmops.VMOps, '_check_hotplug_available')
|
|
def test_detach_interface_missing_instance(self, mock_check_hotplug):
|
|
mock_check_hotplug.side_effect = os_win_exc.HyperVVMNotFoundException(
|
|
vm_name='fake_vm')
|
|
self.assertRaises(exception.InterfaceDetachFailed,
|
|
self._vmops.detach_interface,
|
|
mock.MagicMock(), mock.sentinel.fake_vif)
|
|
|
|
@mock.patch('nova.virt.configdrive.required_by')
|
|
@mock.patch.object(vmops.VMOps, '_create_root_vhd')
|
|
@mock.patch.object(vmops.VMOps, 'get_image_vm_generation')
|
|
@mock.patch.object(vmops.VMOps, '_attach_drive')
|
|
@mock.patch.object(vmops.VMOps, '_create_config_drive')
|
|
@mock.patch.object(vmops.VMOps, 'attach_config_drive')
|
|
@mock.patch.object(vmops.VMOps, '_detach_config_drive')
|
|
@mock.patch.object(vmops.VMOps, 'power_on')
|
|
def test_rescue_instance(self, mock_power_on,
|
|
mock_detach_config_drive,
|
|
mock_attach_config_drive,
|
|
mock_create_config_drive,
|
|
mock_attach_drive,
|
|
mock_get_image_vm_gen,
|
|
mock_create_root_vhd,
|
|
mock_configdrive_required):
|
|
mock_image_meta = mock.MagicMock()
|
|
mock_vm_gen = constants.VM_GEN_2
|
|
mock_instance = fake_instance.fake_instance_obj(self.context)
|
|
|
|
mock_configdrive_required.return_value = True
|
|
mock_create_root_vhd.return_value = mock.sentinel.rescue_vhd_path
|
|
mock_get_image_vm_gen.return_value = mock_vm_gen
|
|
self._vmops._vmutils.get_vm_generation.return_value = mock_vm_gen
|
|
self._vmops._pathutils.lookup_root_vhd_path.return_value = (
|
|
mock.sentinel.root_vhd_path)
|
|
mock_create_config_drive.return_value = (
|
|
mock.sentinel.rescue_configdrive_path)
|
|
|
|
self._vmops.rescue_instance(self.context,
|
|
mock_instance,
|
|
mock.sentinel.network_info,
|
|
mock_image_meta,
|
|
mock.sentinel.rescue_password)
|
|
|
|
mock_get_image_vm_gen.assert_called_once_with(
|
|
mock_instance.uuid, mock_image_meta)
|
|
self._vmops._vmutils.detach_vm_disk.assert_called_once_with(
|
|
mock_instance.name, mock.sentinel.root_vhd_path,
|
|
is_physical=False)
|
|
mock_attach_drive.assert_called_once_with(
|
|
mock_instance.name, mock.sentinel.rescue_vhd_path, 0,
|
|
self._vmops._ROOT_DISK_CTRL_ADDR,
|
|
vmops.VM_GENERATIONS_CONTROLLER_TYPES[mock_vm_gen])
|
|
self._vmops._vmutils.attach_scsi_drive.assert_called_once_with(
|
|
mock_instance.name, mock.sentinel.root_vhd_path,
|
|
drive_type=constants.DISK)
|
|
mock_detach_config_drive.assert_called_once_with(mock_instance.name)
|
|
mock_create_config_drive.assert_called_once_with(
|
|
self.context, mock_instance,
|
|
injected_files=None,
|
|
admin_password=mock.sentinel.rescue_password,
|
|
network_info=mock.sentinel.network_info,
|
|
rescue=True)
|
|
mock_attach_config_drive.assert_called_once_with(
|
|
mock_instance, mock.sentinel.rescue_configdrive_path,
|
|
mock_vm_gen)
|
|
|
|
@mock.patch.object(vmops.VMOps, '_create_root_vhd')
|
|
@mock.patch.object(vmops.VMOps, 'get_image_vm_generation')
|
|
@mock.patch.object(vmops.VMOps, 'unrescue_instance')
|
|
def _test_rescue_instance_exception(self, mock_unrescue,
|
|
mock_get_image_vm_gen,
|
|
mock_create_root_vhd,
|
|
wrong_vm_gen=False,
|
|
boot_from_volume=False,
|
|
expected_exc=None):
|
|
mock_vm_gen = constants.VM_GEN_1
|
|
image_vm_gen = (mock_vm_gen
|
|
if not wrong_vm_gen else constants.VM_GEN_2)
|
|
mock_image_meta = mock.MagicMock()
|
|
|
|
mock_instance = fake_instance.fake_instance_obj(self.context)
|
|
mock_get_image_vm_gen.return_value = image_vm_gen
|
|
self._vmops._vmutils.get_vm_generation.return_value = mock_vm_gen
|
|
self._vmops._pathutils.lookup_root_vhd_path.return_value = (
|
|
mock.sentinel.root_vhd_path if not boot_from_volume else None)
|
|
|
|
self.assertRaises(expected_exc,
|
|
self._vmops.rescue_instance,
|
|
self.context, mock_instance,
|
|
mock.sentinel.network_info,
|
|
mock_image_meta,
|
|
mock.sentinel.rescue_password)
|
|
mock_unrescue.assert_called_once_with(mock_instance)
|
|
|
|
def test_rescue_instance_wrong_vm_gen(self):
|
|
# Test the case when the rescue image requires a different
|
|
# vm generation than the actual rescued instance.
|
|
self._test_rescue_instance_exception(
|
|
wrong_vm_gen=True,
|
|
expected_exc=exception.ImageUnacceptable)
|
|
|
|
def test_rescue_instance_boot_from_volume(self):
|
|
# Rescuing instances booted from volume is not supported.
|
|
self._test_rescue_instance_exception(
|
|
boot_from_volume=True,
|
|
expected_exc=exception.InstanceNotRescuable)
|
|
|
|
@mock.patch.object(fileutils, 'delete_if_exists')
|
|
@mock.patch.object(vmops.VMOps, '_attach_drive')
|
|
@mock.patch.object(vmops.VMOps, 'attach_config_drive')
|
|
@mock.patch.object(vmops.VMOps, '_detach_config_drive')
|
|
@mock.patch.object(vmops.VMOps, 'power_on')
|
|
@mock.patch.object(vmops.VMOps, 'power_off')
|
|
def test_unrescue_instance(self, mock_power_on, mock_power_off,
|
|
mock_detach_config_drive,
|
|
mock_attach_configdrive,
|
|
mock_attach_drive,
|
|
mock_delete_if_exists):
|
|
mock_instance = fake_instance.fake_instance_obj(self.context)
|
|
mock_vm_gen = constants.VM_GEN_2
|
|
|
|
self._vmops._vmutils.get_vm_generation.return_value = mock_vm_gen
|
|
self._vmops._vmutils.is_disk_attached.return_value = False
|
|
self._vmops._pathutils.lookup_root_vhd_path.side_effect = (
|
|
mock.sentinel.root_vhd_path, mock.sentinel.rescue_vhd_path)
|
|
self._vmops._pathutils.lookup_configdrive_path.return_value = (
|
|
mock.sentinel.configdrive_path)
|
|
|
|
self._vmops.unrescue_instance(mock_instance)
|
|
|
|
self._vmops._pathutils.lookup_root_vhd_path.assert_has_calls(
|
|
[mock.call(mock_instance.name),
|
|
mock.call(mock_instance.name, rescue=True)])
|
|
self._vmops._vmutils.detach_vm_disk.assert_has_calls(
|
|
[mock.call(mock_instance.name,
|
|
mock.sentinel.root_vhd_path,
|
|
is_physical=False),
|
|
mock.call(mock_instance.name,
|
|
mock.sentinel.rescue_vhd_path,
|
|
is_physical=False)])
|
|
mock_attach_drive.assert_called_once_with(
|
|
mock_instance.name, mock.sentinel.root_vhd_path, 0,
|
|
self._vmops._ROOT_DISK_CTRL_ADDR,
|
|
vmops.VM_GENERATIONS_CONTROLLER_TYPES[mock_vm_gen])
|
|
mock_detach_config_drive.assert_called_once_with(mock_instance.name,
|
|
rescue=True,
|
|
delete=True)
|
|
mock_delete_if_exists.assert_called_once_with(
|
|
mock.sentinel.rescue_vhd_path)
|
|
self._vmops._vmutils.is_disk_attached.assert_called_once_with(
|
|
mock.sentinel.configdrive_path,
|
|
is_physical=False)
|
|
mock_attach_configdrive.assert_called_once_with(
|
|
mock_instance, mock.sentinel.configdrive_path, mock_vm_gen)
|
|
mock_power_on.assert_called_once_with(mock_instance)
|
|
|
|
@mock.patch.object(vmops.VMOps, 'power_off')
|
|
def test_unrescue_instance_missing_root_image(self, mock_power_off):
|
|
mock_instance = fake_instance.fake_instance_obj(self.context)
|
|
mock_instance.vm_state = vm_states.RESCUED
|
|
self._vmops._pathutils.lookup_root_vhd_path.return_value = None
|
|
|
|
self.assertRaises(exception.InstanceNotRescuable,
|
|
self._vmops.unrescue_instance,
|
|
mock_instance)
|
|
|
|
@mock.patch.object(volumeops.VolumeOps, 'bytes_per_sec_to_iops')
|
|
@mock.patch.object(vmops.VMOps, '_get_scoped_flavor_extra_specs')
|
|
@mock.patch.object(vmops.VMOps, '_get_instance_local_disks')
|
|
def test_set_instance_disk_qos_specs(self, mock_get_local_disks,
|
|
mock_get_scoped_specs,
|
|
mock_bytes_per_sec_to_iops):
|
|
fake_total_bytes_sec = 8
|
|
fake_total_iops_sec = 1
|
|
mock_instance = fake_instance.fake_instance_obj(self.context)
|
|
mock_local_disks = [mock.sentinel.root_vhd_path,
|
|
mock.sentinel.eph_vhd_path]
|
|
|
|
mock_get_local_disks.return_value = mock_local_disks
|
|
mock_set_qos_specs = self._vmops._vmutils.set_disk_qos_specs
|
|
mock_get_scoped_specs.return_value = dict(
|
|
disk_total_bytes_sec=fake_total_bytes_sec)
|
|
mock_bytes_per_sec_to_iops.return_value = fake_total_iops_sec
|
|
|
|
self._vmops._set_instance_disk_qos_specs(mock_instance)
|
|
|
|
mock_bytes_per_sec_to_iops.assert_called_once_with(
|
|
fake_total_bytes_sec)
|
|
|
|
mock_get_local_disks.assert_called_once_with(mock_instance.name)
|
|
expected_calls = [mock.call(disk_path, fake_total_iops_sec)
|
|
for disk_path in mock_local_disks]
|
|
mock_set_qos_specs.assert_has_calls(expected_calls)
|
|
|
|
def test_get_instance_local_disks(self):
|
|
fake_instance_dir = 'fake_instance_dir'
|
|
fake_local_disks = [os.path.join(fake_instance_dir, disk_name)
|
|
for disk_name in ['root.vhd', 'configdrive.iso']]
|
|
fake_instance_disks = ['fake_remote_disk'] + fake_local_disks
|
|
|
|
mock_get_storage_paths = self._vmops._vmutils.get_vm_storage_paths
|
|
mock_get_storage_paths.return_value = [fake_instance_disks, []]
|
|
mock_get_instance_dir = self._vmops._pathutils.get_instance_dir
|
|
mock_get_instance_dir.return_value = fake_instance_dir
|
|
|
|
ret_val = self._vmops._get_instance_local_disks(
|
|
mock.sentinel.instance_name)
|
|
|
|
self.assertEqual(fake_local_disks, ret_val)
|
|
|
|
def test_get_scoped_flavor_extra_specs(self):
|
|
# The flavor extra spect dict contains only string values.
|
|
fake_total_bytes_sec = '8'
|
|
|
|
mock_instance = fake_instance.fake_instance_obj(self.context)
|
|
mock_instance.flavor.extra_specs = {
|
|
'spec_key': 'spec_value',
|
|
'quota:total_bytes_sec': fake_total_bytes_sec}
|
|
|
|
ret_val = self._vmops._get_scoped_flavor_extra_specs(
|
|
mock_instance, scope='quota')
|
|
|
|
expected_specs = {
|
|
'total_bytes_sec': fake_total_bytes_sec
|
|
}
|
|
self.assertEqual(expected_specs, ret_val)
|