Matt Riedemann 9e2d63da94 Validate new image via scheduler during rebuild ... During a rebuild we bypass the scheduler because we are always rebuilding the instance on the same host it's already on. However, we allow passing a new image during rebuild and that new image needs to be validated to work with the instance host by running it through the scheduler filters, like the ImagePropertiesFilter. Otherwise the new image could violate constraints placed on the host by the admin. This change checks to see if there is a new image provided and if so, modifies the request spec passed to the scheduler so that the new image is validated all while restricting the scheduler to still pick the same host that the instance is running on. If the image is not valid for the host, the scheduler will raise NoValidHost and the rebuild stops. A functional test is added to show the recreate of the bug and that we probably stop the rebuild now in conductor by calling the scheduler to validate the image. Co-Authored-By: Sylvain Bauza <sbauza@redhat.com> Closes-Bug: #1664931 NOTE(mriedem): The backport has to explicitly use the filter scheduler in the test setup and move the start of the compute service to after the placement fixture usage. This is because cc83335987 is not in stable/pike. Change-Id: I11746d1ea996a0f18b7c54b4c9c21df58cc4714b (cherry picked from commit 984dd8ad6a)		2017-11-14 10:14:46 -05:00
..
tasks	Merge "Cleanup allocations on invalid dest node during live migration" into stable/pike	2017-09-15 22:19:13 +00:00
__init__.py	move all tests to nova/tests/unit	2014-11-12 15:31:08 -05:00
test_conductor.py	Validate new image via scheduler during rebuild	2017-11-14 10:14:46 -05:00