741f163fc5
fileutils is graduated in the oslo.utils library. Remove old implementation of the read_cached_file function in the nova.utils and move from the fileutils the read_cached_file and delete_cached_file functions to the nova.utils module and the unit tests for these functions. Implements: blueprint graduate-fileutils[1] [1] https://blueprints.launchpad.net/oslo-incubator/+spec/graduate-fileutils Depends-On: I51ba9076e1fbc16145ee2311f47b7768c16dcb20 (requirements) Change-Id: I849f1c74ec811dbe82ba6270569a008a49eab465
129 lines
4.6 KiB
Python
129 lines
4.6 KiB
Python
# Copyright 2012 Michael Still and Canonical Inc
|
|
# All Rights Reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
|
|
import os
|
|
import tempfile
|
|
|
|
import mock
|
|
from mox3 import mox
|
|
from oslo_config import cfg
|
|
from oslo_utils import fileutils
|
|
|
|
from nova import context
|
|
from nova import test
|
|
from nova.tests.unit import fake_instance
|
|
from nova import utils
|
|
from nova.virt import configdrive
|
|
|
|
CONF = cfg.CONF
|
|
|
|
|
|
class FakeInstanceMD(object):
|
|
def metadata_for_config_drive(self):
|
|
yield ('this/is/a/path/hello', 'This is some content')
|
|
|
|
|
|
class ConfigDriveTestCase(test.NoDBTestCase):
|
|
|
|
def test_create_configdrive_iso(self):
|
|
CONF.set_override('config_drive_format', 'iso9660')
|
|
imagefile = None
|
|
|
|
try:
|
|
self.mox.StubOutWithMock(utils, 'execute')
|
|
|
|
utils.execute('genisoimage', '-o', mox.IgnoreArg(), '-ldots',
|
|
'-allow-lowercase', '-allow-multidot', '-l',
|
|
'-publisher', mox.IgnoreArg(), '-quiet', '-J', '-r',
|
|
'-V', 'config-2', mox.IgnoreArg(), attempts=1,
|
|
run_as_root=False).AndReturn(None)
|
|
|
|
self.mox.ReplayAll()
|
|
|
|
with configdrive.ConfigDriveBuilder(FakeInstanceMD()) as c:
|
|
(fd, imagefile) = tempfile.mkstemp(prefix='cd_iso_')
|
|
os.close(fd)
|
|
c.make_drive(imagefile)
|
|
|
|
finally:
|
|
if imagefile:
|
|
fileutils.delete_if_exists(imagefile)
|
|
|
|
def test_create_configdrive_vfat(self):
|
|
CONF.set_override('config_drive_format', 'vfat')
|
|
imagefile = None
|
|
try:
|
|
self.mox.StubOutWithMock(utils, 'mkfs')
|
|
self.mox.StubOutWithMock(utils, 'execute')
|
|
self.mox.StubOutWithMock(utils, 'trycmd')
|
|
|
|
utils.mkfs('vfat', mox.IgnoreArg(),
|
|
label='config-2').AndReturn(None)
|
|
utils.trycmd('mount', '-o', mox.IgnoreArg(), mox.IgnoreArg(),
|
|
mox.IgnoreArg(),
|
|
run_as_root=True).AndReturn((None, None))
|
|
utils.execute('umount', mox.IgnoreArg(),
|
|
run_as_root=True).AndReturn(None)
|
|
|
|
self.mox.ReplayAll()
|
|
|
|
with configdrive.ConfigDriveBuilder(FakeInstanceMD()) as c:
|
|
(fd, imagefile) = tempfile.mkstemp(prefix='cd_vfat_')
|
|
os.close(fd)
|
|
c.make_drive(imagefile)
|
|
|
|
# NOTE(mikal): we can't check for a VFAT output here because the
|
|
# filesystem creation stuff has been mocked out because it
|
|
# requires root permissions
|
|
|
|
finally:
|
|
if imagefile:
|
|
fileutils.delete_if_exists(imagefile)
|
|
|
|
def test_config_drive_required_by_image_property(self):
|
|
inst = fake_instance.fake_instance_obj(context.get_admin_context())
|
|
inst.config_drive = ''
|
|
inst.system_metadata = {
|
|
utils.SM_IMAGE_PROP_PREFIX + 'img_config_drive': 'mandatory'}
|
|
self.assertTrue(configdrive.required_by(inst))
|
|
|
|
inst.system_metadata = {
|
|
utils.SM_IMAGE_PROP_PREFIX + 'img_config_drive': 'optional'}
|
|
self.assertFalse(configdrive.required_by(inst))
|
|
|
|
@mock.patch.object(configdrive, 'required_by', return_value=False)
|
|
def test_config_drive_update_instance_required_by_false(self,
|
|
mock_required):
|
|
inst = fake_instance.fake_instance_obj(context.get_admin_context())
|
|
inst.config_drive = ''
|
|
configdrive.update_instance(inst)
|
|
self.assertEqual('', inst.config_drive)
|
|
|
|
inst.config_drive = True
|
|
configdrive.update_instance(inst)
|
|
self.assertTrue(inst.config_drive)
|
|
|
|
@mock.patch.object(configdrive, 'required_by', return_value=True)
|
|
def test_config_drive_update_instance(self, mock_required):
|
|
inst = fake_instance.fake_instance_obj(context.get_admin_context())
|
|
inst.config_drive = ''
|
|
configdrive.update_instance(inst)
|
|
self.assertTrue(inst.config_drive)
|
|
|
|
inst.config_drive = True
|
|
configdrive.update_instance(inst)
|
|
self.assertTrue(inst.config_drive)
|